From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29739EB8FAF for ; Wed, 6 Sep 2023 05:52:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A79AD90001D; Wed, 6 Sep 2023 01:52:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A04688E0014; Wed, 6 Sep 2023 01:52:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A41290001D; Wed, 6 Sep 2023 01:52:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 743338E0014 for ; Wed, 6 Sep 2023 01:52:22 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4DC29B3CF8 for ; Wed, 6 Sep 2023 05:52:22 +0000 (UTC) X-FDA: 81205102524.06.2EDF702 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 720EAC0015 for ; Wed, 6 Sep 2023 05:52:20 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ZOiWJv/7"; spf=pass (imf28.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693979540; a=rsa-sha256; cv=none; b=FpSCK2SO9Mbd4zpula9kZU+nnnkat0Qp3ZvyFepE07+O3I0AII6JN8RknVk1WKfuvE6ZhJ 7wQqWvNi9MmbOEU97sOL4yfoTHMW0qughnpf328Wuencxwsfcubvph7xyhVrEtyCS43oHQ bQaKyUQfiBxwk/W1ObNMcAwabmuLmGY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ZOiWJv/7"; spf=pass (imf28.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693979540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7oBroSdJKa/XGQNFjilG4BQjGiI7AjaAD4cAdBuTzN8=; b=76n9U3OpI6HIvGAWJlwu3wHL2NVrxh0NqYqpvw//i34e5u4DWViz0rD6Wjv5oCSB9wDX7D Z4MD6Aa6cvmfu2ckY7YKDFaMD9oaQfTLuGQ3TBnZjzYuarrc1u8yx/iQH8fCNGXuNGJQU/ E/T2jxn0Ls/bloLqoHRQWGt4qjZmlhg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693979539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7oBroSdJKa/XGQNFjilG4BQjGiI7AjaAD4cAdBuTzN8=; b=ZOiWJv/7ll6tvDwgm1Q/grHlZCatGFexbc0qbKPcN6vY/4c6LqjgJmmEw6dV97OyzQ6/7W xl+kML+RgLs2A0fWkjzBSTf4+E1EVUcnewwTq1tDuBJSqt+T1B4RnqyaycWbEVjljrmTU9 2zFI1fIrpNV8vo9YFSfDFgcri1IKlpY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-299-nMmOOAXlPamZNekQSAY2-A-1; Wed, 06 Sep 2023 01:52:12 -0400 X-MC-Unique: nMmOOAXlPamZNekQSAY2-A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D55AA1817929; Wed, 6 Sep 2023 05:52:11 +0000 (UTC) Received: from localhost (unknown [10.72.112.85]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3159B140E962; Wed, 6 Sep 2023 05:52:10 +0000 (UTC) Date: Wed, 6 Sep 2023 13:52:08 +0800 From: Baoquan He To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko , Christoph Hellwig Subject: Re: [PATCH v2 3/9] mm: vmalloc: Move vmap_init_free_space() down in vmalloc.c Message-ID: References: <20230829081142.3619-1-urezki@gmail.com> <20230829081142.3619-4-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230829081142.3619-4-urezki@gmail.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 720EAC0015 X-Stat-Signature: b8bnufjpcszcj35k4tnya1yxs7qnqoaw X-Rspam-User: X-HE-Tag: 1693979540-872798 X-HE-Meta: U2FsdGVkX1+tpdlo3f4e63we72lOtyDT/33d9m2SgCZx/E1ZC1yA9hvhqyp+QacnIyXSanXPqO4/WwD20jkXf9CDwBbsxSBOx/hPYO8H6g+0wfI5s3ElM0kv2m5o+o8ZzX2TdiTEMcuIrb4EscpU1wk9UqNygOQG/sylKHHsyf4casWWmqQ2NtcaJLDmiJS84cJWlKdoQJm2v1XCyQBMp510Ls3hWQkGL7jX0PNWrE48Qkels2CU2Huq7JYvCUAtghY5JvyPbYh7SX7ArZaAKd1b2EN3fgxT7eFU6+aWhnXynM1MN8COTVg8qzc2GFdchYnG8CTOP2uyJO9ErWwhcKEdOj82xFyg2jwsQ0KgyPTYl/iGp6RzjOB7hGw1ypOaQbbaQAi6W8l7jRflW33usfjFl3ueRuRlWSZ+EA8kVvsHLYGkHvWBIWxHdpIdbHGFZ8SkTAa0sH79eoBaz6Nbbv6tJfP8EW8GANUd1U1KtT1dl4BW/kHhCGW/775pFlchBzGW9CplBF+ozhUk96Apq5/lqw7jBZ5zrZi0wtYTvpCPrTiOAi7kZ5g6NWDTYqNCdbsJbSkcE6/Edi0fBLRZ3XMRBKnM+AOt9tv6Gjab588aethJLnxlLq88yhXq2N3MCm+WJjNc5PG4OqDgveobOto3T1Ml526luKmy22wpisCK1PAldVXMm6gaKWMMCm3ljHK/Fhuapmxu5aJWxtK9wcBrEL8P+uDKssdF2N5eQjGfgyYnRQKCG81IbjHwDydBDUnwNDI422nOtH5L7rgT7FG4BHsO7TfnycflSNjNMmjUl64fn5BYa/EXthO/59za5pUwwQqwdD6X7IRLZXtEg2DwRI9zomfxxhzVO+Y4LyJ2oSfYKv4fA9HRBV4h2xzIXeezirLRRxrUdJ6hmqqv42Vn7iwQiwxAoCtJzMcZXfil5sNFUb+0/L/nKeD8Bag+Q5r3tP6i2W8xeQ/+tSI Z4sxFMV0 YKOuxeemu3BkqyvZRRm4dE54FMKXQUi++O7nSY6loZee2JmJPK4GxGcEJ4PsxAGU+nfb9iSgdRU9lRMcjdd6DT/iwoV7nTwll/YU/VeMV27rdLkf6uPeDaxb4BVqCSPZYrESbiPOqx4l9tFtcfpqCfFEw0iiQjqF4JIQheBJb/2e+z+VeSmGYDrGbmU8hcd/Ddr85ocGDwzVgfV4VDns27VbQgCLYF7LPPd0MHcVEXSk5eRSUg/4/b6HljdouRU7/On3nx0ErEcWB9f1fZWRbXrrlatLeSE96TXgd6gRTbWy4x3Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/29/23 at 10:11am, Uladzislau Rezki (Sony) wrote: > A vmap_init_free_space() is a function that setups a vmap space > and is considered as part of initialization phase. Since a main > entry which is vmalloc_init(), has been moved down in vmalloc.c > it makes sense to follow the pattern. > > There is no a functional change as a result of this patch. > > Reviewed-by: Christoph Hellwig > Reviewed-by: Lorenzo Stoakes > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 82 ++++++++++++++++++++++++++-------------------------- > 1 file changed, 41 insertions(+), 41 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 09e315f8ea34..b7deacca1483 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2512,47 +2512,6 @@ void __init vm_area_register_early(struct vm_struct *vm, size_t align) > kasan_populate_early_vm_area_shadow(vm->addr, vm->size); > } > > -static void vmap_init_free_space(void) > -{ > - unsigned long vmap_start = 1; > - const unsigned long vmap_end = ULONG_MAX; > - struct vmap_area *busy, *free; > - > - /* > - * B F B B B F > - * -|-----|.....|-----|-----|-----|.....|- > - * | The KVA space | > - * |<--------------------------------->| > - */ > - list_for_each_entry(busy, &vmap_area_list, list) { > - if (busy->va_start - vmap_start > 0) { > - free = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT); > - if (!WARN_ON_ONCE(!free)) { > - free->va_start = vmap_start; > - free->va_end = busy->va_start; > - > - insert_vmap_area_augment(free, NULL, > - &free_vmap_area_root, > - &free_vmap_area_list); > - } > - } > - > - vmap_start = busy->va_end; > - } > - > - if (vmap_end - vmap_start > 0) { > - free = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT); > - if (!WARN_ON_ONCE(!free)) { > - free->va_start = vmap_start; > - free->va_end = vmap_end; > - > - insert_vmap_area_augment(free, NULL, > - &free_vmap_area_root, > - &free_vmap_area_list); > - } > - } > -} > - > static inline void setup_vmalloc_vm_locked(struct vm_struct *vm, > struct vmap_area *va, unsigned long flags, const void *caller) > { > @@ -4443,6 +4402,47 @@ module_init(proc_vmalloc_init); > > #endif > > +static void vmap_init_free_space(void) > +{ > + unsigned long vmap_start = 1; > + const unsigned long vmap_end = ULONG_MAX; > + struct vmap_area *busy, *free; > + > + /* > + * B F B B B F > + * -|-----|.....|-----|-----|-----|.....|- > + * | The KVA space | > + * |<--------------------------------->| > + */ > + list_for_each_entry(busy, &vmap_area_list, list) { > + if (busy->va_start - vmap_start > 0) { > + free = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT); > + if (!WARN_ON_ONCE(!free)) { > + free->va_start = vmap_start; > + free->va_end = busy->va_start; > + > + insert_vmap_area_augment(free, NULL, > + &free_vmap_area_root, > + &free_vmap_area_list); > + } > + } > + > + vmap_start = busy->va_end; > + } > + > + if (vmap_end - vmap_start > 0) { > + free = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT); > + if (!WARN_ON_ONCE(!free)) { > + free->va_start = vmap_start; > + free->va_end = vmap_end; > + > + insert_vmap_area_augment(free, NULL, > + &free_vmap_area_root, > + &free_vmap_area_list); > + } > + } > +} > + > void __init vmalloc_init(void) > { > struct vmap_area *va; > -- > 2.30.2 > Reviewed-by: Baoquan He