From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37793EB8FAD for ; Wed, 6 Sep 2023 02:47:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4061900019; Tue, 5 Sep 2023 22:47:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F02D8E0014; Tue, 5 Sep 2023 22:47:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DECC900019; Tue, 5 Sep 2023 22:47:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 829CD8E0014 for ; Tue, 5 Sep 2023 22:47:57 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4A604A0BED for ; Wed, 6 Sep 2023 02:47:57 +0000 (UTC) X-FDA: 81204637794.05.D4F7709 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 1A34A8000A for ; Wed, 6 Sep 2023 02:47:54 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Xus+g8X6; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693968475; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FyOQexAs6+4xUIpCpqEinm95Edgh4iUWzXpJFb9NwXc=; b=RDxYo2x71eHnDB/A1c9KyQuP2r72+acAJfmIHIt//eM0apu8roe2cgDUisfCTnyPvuINBP W0XKFphtIY7f1JJtf9TrEZcVan+ttyWQt6l8cz3p5/4doXMwK+XwiP6lBX1kl3R04vl49y H8LfZUUnEmgea5UXMOK06L1w2ABT1j4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693968475; a=rsa-sha256; cv=none; b=Y4SwpHHoEr83S0lQU5Wcr/sdqVnjQspBdMUj5Q4n9XTmm+peoWqtyEPyM56Vvaa3ymK4ij 7Ltuudoqz9ZQ3e2FSDxak5Yu1KjI8OZtMW8KfExG1UaWkZAltUpDooKfB54Ih7Ha61cZGx mtFCk0kG7h+TMiYgKiY3bRbviPTQOnU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Xus+g8X6; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FyOQexAs6+4xUIpCpqEinm95Edgh4iUWzXpJFb9NwXc=; b=Xus+g8X6RO0Bduxvh5iJC7PU2P 3b9w0fJVn5KLvsZY21/k5mVZnThC6QSklmZT4E6e8uBXzf/vl+moh3JVhulaPhLpXXjKn05A8hP17 0XTermDYie0UIJGytaJOlhv6jPBHs2Qf3ILzlwkbfSoTcVvQ0CC5GFYWk1dSZEsoMY8UYv/g/GSsR LumLgZAm4ZBcS7OmyGCOTmQfD5tmVhjMEnP1VZ0yKGgX+pjCqJ2mZD0aIg00SUtJs/c8ltA8Pjn2S flRfee40Ufk3RLpI+SEyVfqXIav772T45/NUoCtiyih7dSV/+36aK2eAbRzqnNCSHerimFSF/+Pes CDYctwLg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qdiZz-00FwMl-1X; Wed, 06 Sep 2023 02:47:43 +0000 Date: Wed, 6 Sep 2023 03:47:42 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , Mike Kravetz , Muchun Song , linux-mm@kvack.org, Yuan Can Subject: Re: [PATCH resend] mm: hugetlb_vmemmap: use bulk allocator in alloc_vmemmap_page_list() Message-ID: References: <20230905103508.2996474-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230905103508.2996474-1-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: 1A34A8000A X-Rspam-User: X-Stat-Signature: eg5w317qjmnq5bbzqcqn8igtoype1ta8 X-Rspamd-Server: rspam03 X-HE-Tag: 1693968474-223402 X-HE-Meta: U2FsdGVkX19F3zZq9Ym/vYyZ9+/DXkjDffOTOe/zWSqLsVAX48CAq3z5ndHwO5GPy7fWO2H6gFXqveWUKcZ7HCq4jUevMCU32N1dEDTXDXrefTHI7ZrH4rxDwPDfkyiycZXzj5oIiKP82A1D0VbUOGtcuGWU900dLroMjoCWgnhFWjTsolnwAs6ATTsj9rz5ad0kNf/mzznm/p15qDxaBiW9QgwYdifgGw53/CWpeMRtHFkXqblvt2ilatatXDlyx7dVnmie3AuW1XGlrvbkYbBbeIplwbgl06HfrtrwVP15hscvqJruJXNsXtl6wBgIuxyyD3/d39+J7GPrSsm+0j4KvnPgHxUUj2CK1aRwuDJ9U7GJCcCw5mb2YUIKPgNvsV3o7BjgTJZ+uAVt4tukbC+hoFUVcb3tzhCsLoUsmJ7wcY2Tp7MaYxydUS6eXo4EEMOjCMU1mT1OdqHF4ufqSdOp28pEp/K+Rqv/dUf6rro2W7fflolCeVyOLIxeqcmK60kWQ6ZEZXBH0MTI2hH++y/FzhVtFZT81yYSRCl7DFMPLQROG24Zn23lKwP/SQtSw7G/XjKcd4ra/ruDeO0McOfVXbcHAZ7zmMcTl/0fW1wKHjpBoivzrIcdiTDPigovWpycvdJrXt0Jx5uxEyUf+sSxPjDaWxb3WyzMl8xIIu9fq8KLaUIhH6OzVPPecBjlQxbz96j1xK57FJ507uHozUmVEz5Xy6Jr3eeiow6utsYXnWIUY+BfG1u0+W6JNknqOhsn87gE8axGyb4g0IDcGdxFtsMvEPu5FOqNYxAvMyyoWVx6GSYUM6z5MN+oZiqWV33nz6840FkSXvpNJlkXNSW1RzHeTzjO0fqDEdA0pPJDURjUuniH20w2u7UFPknsHZkM4LtuUp0JbXUVnCX1QSn9Y10Zi7smV/2FE8LQ6zl/l4VxRN1EzugNI2EkiTEcxpDJS8pv018a2dzHWQL /sUNJH3c QBzotmASW7qDKaWgylxzAQJ1aMYfWgdtGyZJNC4foOJtuudJJuymDINdI9oCh1/qB5BT0067kVKj/ooBzCg5OLKVw39xbTUrFYl6UaPc7omtIjiE/iFPpKbMzTWFUOIKsK1b0XM8tmjO9TPuwX2GAY06M3DKL/2SrTeV6CNhXzDD1m61m73y/Gaa97Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 05, 2023 at 06:35:08PM +0800, Kefeng Wang wrote: > It is needed 4095 pages(1G) or 7 pages(2M) to be allocated once in > alloc_vmemmap_page_list(), so let's add a bulk allocator varietas > alloc_pages_bulk_list_node() and switch alloc_vmemmap_page_list() > to use it to accelerate page allocation. Argh, no, please don't do this. Iterating a linked list is _expensive_. It is about 10x quicker to iterate an array than a linked list. Adding the list_head option to __alloc_pages_bulk() was a colossal mistake. Don't perpetuate it. These pages are going into an array anyway. Don't put them on a list first.