From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ED29C71153 for ; Sun, 3 Sep 2023 22:30:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F2D528000F; Sun, 3 Sep 2023 18:30:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A38A28000D; Sun, 3 Sep 2023 18:30:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26B3228000F; Sun, 3 Sep 2023 18:30:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1947628000D for ; Sun, 3 Sep 2023 18:30:58 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DCDBD1603CF for ; Sun, 3 Sep 2023 22:30:57 +0000 (UTC) X-FDA: 81196732554.07.C4FEB9D Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) by imf14.hostedemail.com (Postfix) with ESMTP id 1E84E100029 for ; Sun, 3 Sep 2023 22:30:55 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=m5UlscoG; spf=pass (imf14.hostedemail.com: domain of david@fromorbit.com designates 209.85.160.54 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693780256; a=rsa-sha256; cv=none; b=DrsNcqQ2cojXadjV6w/uo+NQCspoP4Obm7Ahyx16lh0N5CdVLxzKjHUCSBwTfeuRLNHrJK cZR+Xvp+ECp3zEjqd17yVG72rES2qLzr8g+9PYrMuqQJAUp5Wv31UrYxikOe/hHYEzf6ws HcPlNw8QARlgZT4d84Sn65Kgp1w19bw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=m5UlscoG; spf=pass (imf14.hostedemail.com: domain of david@fromorbit.com designates 209.85.160.54 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693780256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nv6YpToDNZJcA/Ccz8YHJKQ8zE37n7OYKvDh05ivZ8M=; b=eFfhCqaizoIEUfsh6IoMcBLhoSMaky6sHeB9oDFSkjO0CxUOtvObyogVOq/dXxnI+rGa/K n+fOxCgl7WqJNXXW+bNG5O+tLJuZ4pDtNZnjKG8l6DSYdskEugzepFt9Bx8vG0Q7yN3d6h vcJs/SFKlIzjuCF2/vmeG7JQFw2ONsI= Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-1cc87405650so783577fac.2 for ; Sun, 03 Sep 2023 15:30:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1693780255; x=1694385055; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Nv6YpToDNZJcA/Ccz8YHJKQ8zE37n7OYKvDh05ivZ8M=; b=m5UlscoGmqxmGbjTN05rt6xMWcEmTHgtMTRApK0PG9KALyzMKwf1L9FBa4xqLgP/3Y uhtS6LVQ/PFyOkSBPjblAXO+XRt1aRbnDDYQdw+L40PFcVpayhRq8ZsI0RJd9zdlBUZx JQ+eKPntbMFVAQ3RGUIxp+ho6EuBJXaN8jL9HdqWUJ2L2+Y9ues2hcN/uX9XKaJ4IOZR uaWKV3n1QAl0mv/EaO1ta71Kj0JpoGuHbtI3880KKGuR/olSqA8drRJtzm5PYj1xwb/A pcv8Hx0zVSv2IZH4FQeZom7CakLqooio79XgoAEDIQIRAfyTcU7B+Hg07HrWizvt6amT bDwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693780255; x=1694385055; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Nv6YpToDNZJcA/Ccz8YHJKQ8zE37n7OYKvDh05ivZ8M=; b=DqJEjS1AHboowgJ5Ge7Oo4Sa7joPdos/9If27Ml02EObQQVAalRqNnBky9S7EK7e0V k1/ZCsdrnjUERDfrzVjwGy+P8NBT1ql9aT7ZAKeVimp5Aaw8OTtevw5rY75HTNxvGJvy VGGQ2O51lqBWjaRPSWYUIhy+wPrqw9Trtd2iNDWTx/CHWSymw8K1Mnc34JH7mUquT4Gs qAl4uA0sE7kRB2uUJ6cEJLeRZgpNmjPf0FoNzBUUCtjZms8ZNKeOlBHLPU+NiF0h3OiP L/OgAmXUPiIoHpUMQUowGlKP9chQ8/LOTcRhgTaHornPnTb96Kgbf+6omySwMJlP4bmC +6Iw== X-Gm-Message-State: AOJu0Yyqjubnmh3iKpkFKvONY9u3/9IePcICviD4RQTI5WSzDUlhfRib KoGhppp3oFaWjB1FyJTIfKRZHQ== X-Google-Smtp-Source: AGHT+IGLu9Ypqvz2HQH6Ke2apJHDtGTD5ZHmV6+9u1MT+8XuCmbNG2jkA6AQg79Zc5mY+kWQOWShIA== X-Received: by 2002:a05:6870:568d:b0:1be:c8e2:3ec3 with SMTP id p13-20020a056870568d00b001bec8e23ec3mr11536784oao.14.1693780255066; Sun, 03 Sep 2023 15:30:55 -0700 (PDT) Received: from dread.disaster.area (pa49-195-66-88.pa.nsw.optusnet.com.au. [49.195.66.88]) by smtp.gmail.com with ESMTPSA id i15-20020a63bf4f000000b00565e96d9874sm5648132pgo.89.2023.09.03.15.30.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 15:30:54 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qcvcK-00ASFy-0F; Mon, 04 Sep 2023 08:30:52 +1000 Date: Mon, 4 Sep 2023 08:30:52 +1000 From: Dave Chinner To: Hao Xu Cc: Matthew Wilcox , io-uring@vger.kernel.org, Jens Axboe , Dominique Martinet , Pavel Begunkov , Christian Brauner , Alexander Viro , Stefan Roesch , Clay Harris , "Darrick J . Wong" , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-cachefs@redhat.com, ecryptfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-unionfs@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, codalist@coda.cs.cmu.edu, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, linux-nilfs@vger.kernel.org, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, Wanpeng Li Subject: Re: [PATCH 07/11] vfs: add nowait parameter for file_accessed() Message-ID: References: <20230827132835.1373581-1-hao.xu@linux.dev> <20230827132835.1373581-8-hao.xu@linux.dev> <642de4e6-801d-fcad-a7ce-bfc6dec3b6e5@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <642de4e6-801d-fcad-a7ce-bfc6dec3b6e5@linux.dev> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1E84E100029 X-Stat-Signature: 4rpeyf8quxhqm1prmjsc5hoktqn3a3af X-Rspam-User: X-HE-Tag: 1693780255-556934 X-HE-Meta: U2FsdGVkX18wVMo+HKBe6/DIPHxy7o+QvY7eThwrW4A97F61cDn/URqVEyv6+Ub3TpDFfqqq7vV+mGjWLm4rK5FvuNG0DReBi1y0Q7BYznYGHwUpxmhJIf9dbnDYZ7KlC1ZsPJKdvNki7EXhQMMXH1macceUeuN+xQdQu0xANffalqVDGCXFIO6gprY++aBbcXWnEBtwPlnsKCu1KLn5Epd7fZPtZZ22ExruPtMLEkeGZhDMq7aZPtgDNtqcEWpf9rSn7WT7PnTyXgY9IjvBT/CUxZRTL7Je5Izcd+16aAqxA2TlAh9fPrQMRv38lMOCVQpjK9vO6Xxvsr7SRXwe5F/x6bw9CP5MzkMNqauAnR8/DWP4USxE63Sa3fZH5JcLr1ez8keJ8Xt33nn2k3wy5jeq4EH/fIIhycvF7qRtZ0Wql3K2TwdKVnHGf5Vrxxz0OaTWFzIQdccf4w+I2eff4QJZcGhS2oSBs6MK19LKKEpdeZ8HpUAIFSB00Ywf7tTnrQdpbdiTiHBY1fYhn5FH7M8MYX1qqOkYQuHEEen1UEnbIaVp3Ovv6h1kFXjIbluavYealTWSUBgN2b7pXEpTvSit4kD7BJu7mi/nYqRp+maykvdPP7FmaD2v+/pf4nblLqbh2fOJ+M9xtG0IDdkW8QdgeE5B5Cc44Qj5/w/GVVHFz5wvonh2ZBv6I+BO0jqnVA/WvGpDC06STbPwZbeu6BnQi2f/Vf9z/5WikFtMSgNY89lxw4gG1MEcoOV1NMB6e5xDkTgHdXNWLixkQZxSkyooHlLpsETmY/o80PVz3gGlYEkJGd3vcpgX9zFR2LV61riLr7pKd3Jvu4SAQ6ZMiyNnYxvbBMGu0n7RMgoNKSsVN/gusRCLtwVAbmM8rC1iD3q9nnXTkXLXnxr2Z2MH0WWy+8Ys9mdeflCcTgYfk0tj+l2K64r9jeYgMwFcqAZqWcUDQ+oHyUHDNNqfCxm iU4pZsQn uhytGSmzOeBO8ZtljNBUlaVRe8890ckc/QGA+QWtKSRglz5W9nCcKSbSRvXBlxHlh8s+K4+GkB87Glalu6nKbvVgwHbhIaJYxAhzX91VkVeNgcTfydq4WS70CQC3H/+Em6pDXBByYmzK3pqoDK4juabclxf882bsuvKJOSLiXVLi52rPViXYolEI9eJIPS5I+vH5pVyN6BpFVsQWUxIMfOo1uEvZp/Gr6gs9U70tjQHWoG7vs1NHSBWWNRDQcslPGKVa1+YXyHVepqPxPH9O/f35YSsIL0imWKauZ4F9mxq7vXXhPKGAvmSPIzPG07AfMb1IA1Gnhwkcv1uwtBL3LZLainQ+qzqswHswHQK8qO1wvAefMi5rWjLnLQfsejER46jpUnGluRsCP8N2vSIVm0Ky5Um1s3gUutzKybyzG2hkNoWU8hqiq7S3aiRM67lpXhNoKyMTOmjKIzbP4mDiGbxNJoWlY+N6KA5S80JoQTl/fZxu/Thg2Ew2dkDIvTW+zJ1uxCLt5dIPJB+CG4nOpkekEsYMMW/gTC7mYlrPE/pD+2nUMuSz9iWkgMk7XCzXrma7o/Tht4qbjJhW2UGngKdtRPo1XWFc+2v26p9PxS9ARUvbfXrlKY6+3zesUnpHik/TD0RwGsx9xyBq0uBroL4AYChjzpbQ7Wmp8rlN1wRYxhpCXYeMy5TG836mQD3lsqOlWCgMIFHzHndI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 30, 2023 at 02:11:31PM +0800, Hao Xu wrote: > On 8/29/23 19:53, Matthew Wilcox wrote: > > On Tue, Aug 29, 2023 at 03:46:13PM +0800, Hao Xu wrote: > > > On 8/28/23 05:32, Matthew Wilcox wrote: > > > > On Sun, Aug 27, 2023 at 09:28:31PM +0800, Hao Xu wrote: > > > > > From: Hao Xu > > > > > > > > > > Add a boolean parameter for file_accessed() to support nowait semantics. > > > > > Currently it is true only with io_uring as its initial caller. > > > > > > > > So why do we need to do this as part of this series? Apparently it > > > > hasn't caused any problems for filemap_read(). > > > > > > > > > > We need this parameter to indicate if nowait semantics should be enforced in > > > touch_atime(), There are locks and maybe IOs in it. > > > > That's not my point. We currently call file_accessed() and > > touch_atime() for nowait reads and nowait writes. You haven't done > > anything to fix those. > > > > I suspect you can trim this patchset down significantly by avoiding > > fixing the file_accessed() problem. And then come back with a later > > patchset that fixes it for all nowait i/o. Or do a separate prep series > > I'm ok to do that. > > > first that fixes it for the existing nowait users, and then a second > > series to do all the directory stuff. > > > > I'd do the first thing. Just ignore the problem. Directory atime > > updates cause I/O so rarely that you can afford to ignore it. Almost > > everyone uses relatime or nodiratime. > > Hi Matthew, > The previous discussion shows this does cause issues in real > producations: https://lore.kernel.org/io-uring/2785f009-2ebb-028d-8250-d5f3a30510f0@gmail.com/#:~:text=fwiw%2C%20we%27ve%20just%20recently%20had%20similar%20problems%20with%20io_uring%20read/write > Then separate it out into it's own patch set so we can have a discussion on the merits of requiring using noatime, relatime or lazytime for really latency sensitive IO applications. Changing code is not always the right solution... -Dave. -- Dave Chinner david@fromorbit.com