From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0883C001DB for ; Sat, 2 Sep 2023 14:00:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF2CF8D0017; Sat, 2 Sep 2023 10:00:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA2F38D0002; Sat, 2 Sep 2023 10:00:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B43E68D0017; Sat, 2 Sep 2023 10:00:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A20F18D0002 for ; Sat, 2 Sep 2023 10:00:11 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 64D05802EB for ; Sat, 2 Sep 2023 14:00:11 +0000 (UTC) X-FDA: 81191816622.15.1CEFB23 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 4AE37140021 for ; Sat, 2 Sep 2023 14:00:08 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="M/kbn/GS"; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693663209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ykAU0IuBWCOAh/V+bHoSxJwmB/ONT4m36dnHXVeI+gc=; b=xM1+0Htltz3HNWYq2VnO3pAuVTwB+Lk9g4b1DcORj1/xVGWGApqf9LmgSTLP6b1sUzIyTY 05tNCV+L5BqZJW1amPz5rlbx3JhuHeCDOPgV0tD8bVMHcFydoa1WgNAWmxk8t4uXVn1NVq xPeUltjLrA4S9cMELn7IvUvMRl3popw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="M/kbn/GS"; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693663209; a=rsa-sha256; cv=none; b=ojkyfp3t8LaYYzGDa2/JBn3o1VRI44eFOGMfQ3b9D/r38XpTGsnVMBDMzQBpw0OmHYKSJx r553U8umIi8rBXC5Eckdok57eIa00UGtxZGi2v/TIfsDz4j3+aojpJoxQKxaBonvehyt7f t07X11E2hiDVpqxNXGRZiZe84YcW2V4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ykAU0IuBWCOAh/V+bHoSxJwmB/ONT4m36dnHXVeI+gc=; b=M/kbn/GSgML7w28FfggmH7XG6B AoIOPSIS/rWN+MsWq75QfC/Aee19klAuIvycRMJdm8AER52SmM8ldLrimDyFfGzgfA1Lh27sJMhjx 9yR6IcYoIrGndMgjYzvRoVm4M/ZCmqT4UI5tCYhmnQUr66neucxUcFUTIXtw2EMPmynRUEf96gTef F7fCCcZU2Z6YpiIZfwoADbPIrShS3D2YGkNno4Vrc5chfgi8c+J1r/XUDm2LU5pVzVck07858xIDd e7YyQUXHRVLmmrJ2hEWQiN04YMXTLjuPogl7tDhN6y4GH1ZZAKxIH2VC7FBmAjAZduDxoiuRKz6Xp RntoFSfw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qcR9o-00EvUv-Kx; Sat, 02 Sep 2023 13:59:24 +0000 Date: Sat, 2 Sep 2023 14:59:24 +0100 From: Matthew Wilcox To: Vlastimil Babka Cc: seanjc@google.com, ackerleytng@google.com, akpm@linux-foundation.org, anup@brainfault.org, aou@eecs.berkeley.edu, chao.p.peng@linux.intel.com, chenhuacai@kernel.org, david@redhat.com, isaku.yamahata@gmail.com, jarkko@kernel.org, jmorris@namei.org, kirill.shutemov@linux.intel.com, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev, liam.merwick@oracle.com, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mail@maciej.szmigiero.name, maz@kernel.org, michael.roth@amd.com, mpe@ellerman.id.au, oliver.upton@linux.dev, palmer@dabbelt.com, paul.walmsley@sifive.com, paul@paul-moore.com, pbonzini@redhat.com, qperret@google.com, serge@hallyn.com, tabba@google.com, vannapurve@google.com, wei.w.wang@intel.com, yu.c.zhang@linux.intel.com Subject: Re: [PATCH gmem FIXUP] mm, compaction: make testing mapping_unmovable() safe Message-ID: References: <20230901082025.20548-2-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230901082025.20548-2-vbabka@suse.cz> X-Rspam-User: X-Stat-Signature: 3roc4r487515557e651jq8thahpmjtqs X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4AE37140021 X-HE-Tag: 1693663208-809116 X-HE-Meta: U2FsdGVkX19UW+IFPsuYQjGblMb0QRUaC74AunKfnEdWM/FyKLYh3au8huKAlojm8sPEZaPbSXLk6T0a0y3LKuvev6KDaF1tQdvNSJusYrzYaJEQBflb7aT9L+cFWzdJ5CjCVFiBcIyNidj3XyFV5roZVykKf9K+egriB23+UOotlbguRYye+oaoYOZxniRpq2APXMrFlpxU2518kFjo9twTG0TEDXxU5ujoEC6+hHQLGgMwbZL8Zsw0yrAXoo/oBSHzbE7UuyCdGG6deh5LVX1FhtBANX0W8kaI4hLYxAjh+OXYgCBG6Ln/PTmeVfuMAGYiKPxwjh2onPbWglQ9dylOXgpgBqzINx6hMPtHZ8O1zeTsT+nB9m8QTOca8tNMC6tEA7v/TJen5vC5GjlLYNOrxGshLpoZaX+8Ya5ZE4IwQfkzFrGDu16fkGeaeTLbhA7ownSRDScaXN+1/IU3OiIwYvfHInj4nM8+RazpCbgRb7Otpnxb/IF+5LVNG+CUGJVtjbC1qTHAz0Ut8/CmTK9X/6ok/QC8pZEsDCSOIXw85pZ60eR2KE9xhWrbqGaTyfZWmefrjKiwS56dYSf+9RA9yE/GQpN7p42gFBJpIx5hGYS43ijj5Xj/oUunb/8yNOIyzpCq7KGu0a7qHyaVMZ5fdDD0fdKTk2/TQ7pRh2DAXfwvR28y/6aSIM+xaLVkA4RZwNNsAofkA7zouiTWLunkzoIaaRYIIp6bTM4344yvOf15TOiOo+/ZjQ9SSQ40V5fNTmBFrOykDIATs7yI/3yp3KXN9B9uZwZJKhWI4LE9hDtrUsF/lcTKVu5yRbXTa5jOa2pKlLWpoJdMUmZoLpRiYX0CHYZOXLIVvPIMat6wwLoeBF/k1QI5l9NyhkClQFlyg/fFQSvRKRHWWMEQRIDtXyOCf5jx3hmeKS3IcJSwC908ZyjfMCsZyX1yIm3pzeGxQGamgAaOhfmGgfg z2wSN1gv xGb81tjtpXjvINE5DdEcfdO+OqhQ1G1KWx2NnCLEZhHpYaASXwEzut75L2BJ25CdIO+P37w+yw+mP37UZVZCYO4XrhxSpBsXOoO5bqVCtq8HZfyOruKEmtscrJY9sy+N4x6xpDUrnUD2jzrsPMy9LTu24YxdMKkW/DIOjQwst+cBHYkt7R34ZGOYtaV26BBjbm0VfuyrETd8ouNViceL8/zffk2lpcS0mzbfebVyC71lCXHGPN8WjQE93AtoHbRANNf9Y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 01, 2023 at 10:20:26AM +0200, Vlastimil Babka wrote: > As Kirill pointed out, mapping can be removed under us due to > truncation. Test it under folio lock as already done for the async > compaction / dirty folio case. To prevent locking every folio with > mapping to do the test, do it only for unevictable folios, as we can > expect the unmovable mapping folios are also unevictable - it is the > case for guest memfd folios. > > Also incorporate comment update suggested by Matthew. In the meantime, 866ff80176aa went upstream earlier this merge window, so it's going to have some conflicts.