From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3057CA0FE1 for ; Fri, 1 Sep 2023 12:48:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D00388D0009; Fri, 1 Sep 2023 08:48:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C89208D0002; Fri, 1 Sep 2023 08:48:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B29688D0009; Fri, 1 Sep 2023 08:48:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9F9378D0002 for ; Fri, 1 Sep 2023 08:48:21 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7323AA0267 for ; Fri, 1 Sep 2023 12:48:21 +0000 (UTC) X-FDA: 81188006802.19.3C32147 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf21.hostedemail.com (Postfix) with ESMTP id 728351C0027 for ; Fri, 1 Sep 2023 12:48:19 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="g/Yuzk+T"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693572499; a=rsa-sha256; cv=none; b=TgtOEQkwFIRQK4neV7InaZbRrc6+92r5yvq8kuibDQg4imZa3qcpB7r9KdLuaOrZEDTKRC ZE95ZGSgaL3Ht0jgw2HASLdlqqCRhsA6rdfh7gge81Ap+yjCA4Pw8/C7s0AwVRrNokyk9T tZSdEshBbLA7RYwY61Y0reDeismrWIo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="g/Yuzk+T"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693572499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eGOXW07GjMYn5LTraXxTz7P1J4B8hc0PWiBAI2yKczI=; b=YL6AWPNbR/EVg/oKhwnSctWMJgnBwT8p/C4hySFXRkcQdcwTqlcDWpN/w8FdJBqS8wW5RY d1qAbOnUDssG/qYuBK5VjotHVqmuR3JpI/olByak5rqqb5yriYOr8jwYWwkTmzEUy+LVgt POg2hkTFfNq1T1JJuPCTJ4kmooa3+Pw= Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-500bb392ab7so3341960e87.1 for ; Fri, 01 Sep 2023 05:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693572497; x=1694177297; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=eGOXW07GjMYn5LTraXxTz7P1J4B8hc0PWiBAI2yKczI=; b=g/Yuzk+TLw+0YBGegpVgmFP4MvWuxae7IeE4BnjOtWU4hfbOuU0OsbyokiZNwRdwve us6ERYIbkf/J2Js/hEzHEmgztF7QCswyukcmM4U3C08bDc6UQP6cUsjJ2qd/jU1BJzeC ppcJvvyexRwhiEypjr8pgqTALUQMawoWIqJOgAhA4y8BpHjdbhYC1CrPXpx3GfNZJz53 Qtkq7XN9niKhw/lznO8o5lufYXuOvLQnzhxwPLIWKbzBMnQOTlPJ3kBbSgHJ9IlqPbCw +5zriZxw21TMI/VaCJfnaRKd0v0Gv/PZpJbH1goTMO/dpG4djGwfDzKBxsyMQIKaeE71 Lo/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693572497; x=1694177297; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eGOXW07GjMYn5LTraXxTz7P1J4B8hc0PWiBAI2yKczI=; b=Y/o+aL8Fk6JSYMYqZLOlOsaid4JOaMj+Dodg2yJcei+TC6y+lmiY7oU1Gjmgab+tJL Tcv/EAOi9+HLIZ/gbXr7SMUZXHHZTd6UbbGaW6xF229xxuZmmd9or1S6stTqf+2kZPAp ZSQiTpyApo+ekR0aVpiIQsBYjTVKNXtZrPg9Efv+VrtB7cW/S60l+02t/TB2QbKjFy+w jVVB1/lx4j0VsIVDxMmhVsY4udQnY5FfI9bSBXsAFvVEdYvZJb7ocxYNmGkUL2PxkqZz r7UNfjLsuvzV/DlmUuVYQB1qFmSH9Ekee/eGVVOOI7j4PRP4gr9H8I5GSLvxI1+zbNN1 qFAA== X-Gm-Message-State: AOJu0YxjP5dgVnQZPhAGB7Nx9ZEC3D5aHDmpjmm+lI37RSoNLbn7vDNw 4TDvrDkJKA6QhUje0gVG20Y= X-Google-Smtp-Source: AGHT+IHgGEx64XHT9liHgSNAqotT+BxSq3/EKTJhW0vZg/JjPNnjhpHtMddphgYnIs8ztDR+zSEkIw== X-Received: by 2002:a05:6512:3a83:b0:500:b7ed:1055 with SMTP id q3-20020a0565123a8300b00500b7ed1055mr1865540lfu.56.1693572496905; Fri, 01 Sep 2023 05:48:16 -0700 (PDT) Received: from pc636 (host-90-235-3-170.mobileonline.telia.com. [90.235.3.170]) by smtp.gmail.com with ESMTPSA id q4-20020ac25a04000000b004fdfd931888sm640741lfn.293.2023.09.01.05.48.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Sep 2023 05:48:16 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 1 Sep 2023 14:48:14 +0200 To: Joel Fernandes Cc: Uladzislau Rezki , linux-kernel@vger.kernel.org, Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Zhen Lei , "Paul E . McKenney" , rcu@vger.kernel.org, Zqiang , Matthew Wilcox , linux-mm@kvack.org Subject: Re: [PATCH v2 1/2] mm/vmalloc: Add a safer version of find_vm_area() for debug Message-ID: References: <20230831171827.2625016-1-joel@joelfernandes.org> <20230901001917.GA2723108@google.com> <20230901003321.GA3389909@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230901003321.GA3389909@google.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 728351C0027 X-Stat-Signature: yz3xx66b3x6czksd1y8myab3gfdncoz5 X-HE-Tag: 1693572499-417251 X-HE-Meta: U2FsdGVkX1+b8tc95Clumq5ad7xCfJttltljBzRoQKJGwVLLA9FnJOugW2gS5LtW4qqBDaPiGPvBKOy8W4B3FnunfYk0RM5Y+PXDCmen3U5Y3WORZAtIc847dfLvjyzRrPJkUYR7lZ3cDInNo9w74za09VvsphH4IQYfQkApth+mDmr6D2rjD0WnOQSaONv+EpBtHejnsfdxkUm4jh8R6naMhNoODwIC1c/OJbVXebq3bk3xHt8pgiDmlfg5a+yb1jxOMd9Ig3gKl8PRcXok0ysp8dNCsL6j56+GAlbx0UTn8+fLbDSNqHncPmd0h2qkrwIpV4NDACdhJ9wWzNWTpBJKiU3MLQSsayXNqE/S+mydJjuQe9ZB4zGcXpvTHnL4KMx6fKM9dyaUBP9qUajPeOHhd6P8gNhWnoi9EIgOdUgJfyDlh0B8Upm+ooH3cc74pT86byLolLyQu2CKCcfeKui/bOqubCpSWSj5CQKfQAYWzKbcIwjlNnjjDWwTWm79fcHwVGGjJU/USVsjEF0F2YMucW8/1cVaOl5atUJRelVYyMd/+Hgs2gQpmQta5r4e095/9RHmOmrcf93NLgV/LmdoSG/Xu6xXwLU+hibEMTS2E+PB5zK0DVKSvhSTkPN8CL8xs/M8EEsa1HP8xEMJy0L3C6KDwTKTRZPze7kKn6pagdrzujhwFlQpymvceBITZ1aIKqDLtUaeFhXWNAYZtGHPzjGekJJq1L0yCKHyhMo5JOFRNI0wJCWSnaiR8+OwAYlw3iI8VEMSdpIXDGpK+kgwRZCKA29nKZvrQ1WPo6/czgCXMidsJj7qOrNOyXQ8qI971GyBsIkIzJjZngOWrH9iU7ZfpZX26//WC0Fo/BrHl9IFdTgTWxu0Sy5XCdWdakl8nqEQ4IwwgQXSah9RvyqEexOkKcXEpIs4NedW8wbd9BOhIwip3HLENH9iU8p3Z/HGgFKyAjD67pn0lVz C2oosSg4 7bXB71mUrrsy+1/KxPz4OTFT0fjD/JMXX2jpz0rlN3AaC1/dtQgvF/rJzdAQJMZabxRVTuA33OoHsR9oGJoOl/M7+H+qqW+JDiCyET4IMyV4lQM56a9qBpizvXtRb9+1PxGxEmwBtfmuozdNKAzs6Jt0zKTS9HS9/QZHcfTWMYd0kyLMRyAtM8qrsDfkz+IGk+WU3I7zB4Q0Ye/f1bZ6Sn9/HJErKiiPkoICVqVNxHmQ0Kyu6zxwsQpyaulV7nOUEND/Kg8uFtshXU+EsAQizJM4hHV33zHGs0TeXii9aXawmNozI22l55n1L6jLsO/odVbfpLno38kf/u94D8F2e31y1sXoB425OJYIVsV0fgqpFTGt9LvEmi22G7/shVeYsXC2fNQjoEJxUDwRQJjmY1HqxPejXjiHQpZ6JMa/+hbNVUFzW5Oi5ZMK07vn2iXONjJv1/Dojjnc/3UHt3zu+jNryt0t+8iDwK7dnvkTuYn7nPKchDlB+bM1wFNREkuf8bk1wY3e0j5Ia9CTF4kSohvXBQGwAlpGtIjP4F4WSNg7B5t+dL3sCVIMDSOkHoJ0PnEORjqC4kPLDgLwi9SGqSEe3aNoT2RSjrGVc/5VOSRKgXQ7lEOV3RmhUqGSjCUV08Q1fuxNBQurz+ndbWERIS0dlZ+RV73HoTbBfuSW3jsRvGGgdPgG0uJlvkKHcqJjQfEERxwmbnCPdTuP6b1JuJizYaSuUF6ssbW2VpkuydV3tJWqJpZsZ4GbLggR7SWNuo2NeRXWeTjHos8eJReYWS70Ty4Yp8a2nVKeWVCLZB1wOoQGhEwR5uNGBmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 01, 2023 at 12:33:21AM +0000, Joel Fernandes wrote: > On Fri, Sep 01, 2023 at 12:19:17AM +0000, Joel Fernandes wrote: > > On Thu, Aug 31, 2023 at 09:47:52PM +0200, Uladzislau Rezki wrote: > > > On Thu, Aug 31, 2023 at 05:18:25PM +0000, Joel Fernandes (Google) wrote: > > > > It is unsafe to dump vmalloc area information when trying to do so from > > > > some contexts. Add a safer trylock version of the same function to do a > > > > best-effort VMA finding and use it from vmalloc_dump_obj(). > > > > > > > > [apply test robot feedback on unused function fix.] > > > > > > > > Reported-by: Zhen Lei > > > > Cc: Paul E. McKenney > > > > Cc: rcu@vger.kernel.org > > > > Cc: Zqiang > > > > Reviewed-by: Matthew Wilcox (Oracle) > > > > Signed-off-by: Joel Fernandes (Google) > > > > --- > > > > v1->v2: Apply review tags and test robot feedback. > > > > > > > > mm/vmalloc.c | 39 ++++++++++++++++++++++++++++++++++++++- > > > > 1 file changed, 38 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > > > index 93cf99aba335..f09e882ae3b8 100644 > > > > --- a/mm/vmalloc.c > > > > +++ b/mm/vmalloc.c > > > > @@ -1865,6 +1865,20 @@ struct vmap_area *find_vmap_area(unsigned long addr) > > > > return va; > > > > } > > > > > > > > +#ifdef CONFIG_PRINTK > > > > +static struct vmap_area *find_vmap_area_trylock(unsigned long addr) > > > > +{ > > > > + struct vmap_area *va; > > > > + > > > > + if (!spin_trylock(&vmap_area_lock)) > > > > + return NULL; > > > > + va = __find_vmap_area(addr, &vmap_area_root); > > > > + spin_unlock(&vmap_area_lock); > > > > + > > > > + return va; > > > > +} > > > > +#endif > > > > + > > > > static struct vmap_area *find_unlink_vmap_area(unsigned long addr) > > > > { > > > > struct vmap_area *va; > > > > @@ -2671,6 +2685,29 @@ struct vm_struct *find_vm_area(const void *addr) > > > > return va->vm; > > > > } > > > > > > > > +/** > > > > + * try_to_find_vm_area - find a continuous kernel virtual area > > > > + * @addr: base address > > > > + * > > > > + * This function is the same as find_vm_area() except that it is > > > > + * safe to call if vmap_area_lock is already held and returns NULL > > > > + * if it is. See comments in find_vmap_area() for other details. > > > > + * > > > > + * Return: the area descriptor on success or %NULL on failure. > > > > + */ > > > > +#ifdef CONFIG_PRINTK > > > > +static struct vm_struct *try_to_find_vm_area(const void *addr) > > > > +{ > > > > + struct vmap_area *va; > > > > + > > > > + va = find_vmap_area_trylock((unsigned long)addr); > > > > + if (!va) > > > > + return NULL; > > > > + > > > > + return va->vm; > > > > +} > > > > +#endif > > > > + > > > > /** > > > > * remove_vm_area - find and remove a continuous kernel virtual area > > > > * @addr: base address > > > > @@ -4277,7 +4314,7 @@ bool vmalloc_dump_obj(void *object) > > > > struct vm_struct *vm; > > > > void *objp = (void *)PAGE_ALIGN((unsigned long)object); > > > > > > > > - vm = find_vm_area(objp); > > > > + vm = try_to_find_vm_area(objp); > > > > if (!vm) > > > > return false; > > > > pr_cont(" %u-page vmalloc region starting at %#lx allocated at %pS\n", > > > > Hi Vlad, > > Thanks for taking a look. > > > > > I am not sure if this patch makes a lot of sense. I agree, this is a > > > problem and it mitigates it. But it is broken in terms of once you drop > > > the lock, the VA should not be accessed. > > > > Just to note the lockless-access issue you are referring to is not introduced > > by this patch but is rather in the existing code. Also just to note this is > > debug code. > > > > > Is that a real issue or it gets triggered due to some syntetic test case? > > > > It is a real issue. See 2/2. > > > > > If i were you, i would go with open-coded version of trylock. Because > > > there is only one user so far. > > > > Taking your open coding and locking suggestions, I came up with the below > > which actually results in a smaller patch. Does it look good to you? > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 93cf99aba335..aaf6bad997a7 100644 > > And with some trivial compiler errors fixed (sorry should have build tested > but wanted to just share the idea earlier): > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 93cf99aba335..2c6a0e2ff404 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -4274,14 +4274,32 @@ void pcpu_free_vm_areas(struct vm_struct **vms, int nr_vms) > #ifdef CONFIG_PRINTK > bool vmalloc_dump_obj(void *object) > { > - struct vm_struct *vm; > void *objp = (void *)PAGE_ALIGN((unsigned long)object); > + const void *caller; > + struct vm_struct *vm; > + struct vmap_area *va; > + unsigned long addr; > + unsigned int nr_pages; > > - vm = find_vm_area(objp); > - if (!vm) > + if (!spin_trylock(&vmap_area_lock)) > + return false; > + va = __find_vmap_area((unsigned long)objp, &vmap_area_root); > + if (!va) { > + spin_unlock(&vmap_area_lock); > return false; > + } > + > + vm = va->vm; > + if (!vm) { > + spin_unlock(&vmap_area_lock); > + return false; > + } > + addr = (unsigned long)vm->addr; > + caller = vm->caller; > + nr_pages = vm->nr_pages; > + spin_unlock(&vmap_area_lock); > pr_cont(" %u-page vmalloc region starting at %#lx allocated at %pS\n", > - vm->nr_pages, (unsigned long)vm->addr, vm->caller); > + nr_pages, addr, caller); > return true; > } > #endif > Looks good to me and thank you for fixing a locking issue :) I think you will re-spin and resend it one more time? -- Uladzislau Rezki