From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC2FECA0FE1 for ; Fri, 1 Sep 2023 04:16:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4ABDF8D0017; Fri, 1 Sep 2023 00:16:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45B948D0002; Fri, 1 Sep 2023 00:16:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3237B8D0017; Fri, 1 Sep 2023 00:16:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1F7AA8D0002 for ; Fri, 1 Sep 2023 00:16:58 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EAD6F1C8F85 for ; Fri, 1 Sep 2023 04:16:57 +0000 (UTC) X-FDA: 81186718074.29.6A286AB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 324EC4001C for ; Fri, 1 Sep 2023 04:16:55 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AYt3BAn4; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693541816; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w8wHlDj/Vk60ZnTLWI+IS6+oVbcAr8/wfIj6Dy0bMVI=; b=GnFOmpuYYfHnggeAxacPLbd/vGmBITreww0KI8gHRDF7scD9nTT+iQdDuhu6Z9EJjZgU21 s/MVN0pXATSXpzJiUplZnu+e0+rTBckw4SWBYoRG7nEu48+W9UZmifQewY+/yZPkr0FUd9 BRH6/FjVSpFObgUvijgSWNzjN8++/zk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693541816; a=rsa-sha256; cv=none; b=ODNiRsBii01majreioGVZfFKXgrRJPl3Kv0pkYf+1RspcJQdWzS/Gyk2qSfm2l5aQMVYOd Y4hVoXsfc6PaUjewAmPt9eercyXSjzMi1EEddsCTm70q9PHi4H/syoWlEBOcs9lVsuhI/H bZjOiWR48qZTDnOuXPnEZfOTYxgc/eE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AYt3BAn4; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=w8wHlDj/Vk60ZnTLWI+IS6+oVbcAr8/wfIj6Dy0bMVI=; b=AYt3BAn4SolX9gh7EquGkO+v+8 pz8ajucTICOXMYeSc4yUZ7fQ4ZRYkvX2LZ9aEVVyXNrHwhWSxMRE8ok1NT7Qosion4kRzJp6HLBBy yUdOouFfI3R141xguZkD/zFeUJkaY5FS6YikY0hOm3d+7Ye7EMdwG+BuW9n2HhZGexmdUPbI/fUBg hNVGa18c5iuMJkZZFocWmaKh+eWaCL4NrPubr1ENR1A+PmjxLJz9U2QmygjcbPE5Baetfk4DxV9S+ sDLzzf5fVkLZBtHioLRWdYg/CWhzCAPK+gGQcFryvzfo5kzRkI99/bguPs9A/+rTWhpQPferWP4nB TjO4jORA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qbvaY-005Mjc-9W; Fri, 01 Sep 2023 04:16:54 +0000 Date: Fri, 1 Sep 2023 05:16:54 +0100 From: Matthew Wilcox To: Ryan Roberts Cc: linux-mm@kvack.org Subject: Re: [RFC PATCH 12/14] mm: Free folios directly in move_folios_to_lru() Message-ID: References: <20230825135918.4164671-1-willy@infradead.org> <20230825135918.4164671-13-willy@infradead.org> <1cbb6a62-bea8-4bab-8855-cc6470589bab@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1cbb6a62-bea8-4bab-8855-cc6470589bab@arm.com> X-Stat-Signature: z7jogmfkqjmtyn1etgup3fjdn9bs4bz4 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 324EC4001C X-Rspam-User: X-HE-Tag: 1693541815-911562 X-HE-Meta: U2FsdGVkX18EoKVdYlZhLv4vEAOFQ2JithH6uHKUuAuJ6NQx6Y6nzOBe3A+TSKgBuasvSBd52PB4cuwRGz2fZa6QczOlAjgyt8u2f+bB9UqK9Av7hij7152tUPbURPAybvEkJfh4d5uMYb7BtooJmIrudHrYhq4sr4ThQcLWVuuCFns50iosLjC+vF48e8MvaUaGk+cfNk20rHa3emGtD+tXYtxALvfHFannRtCzSzZYaQkt1Ls3jxufMx+Xy7ndGYEb50b3yPOBQUhZ/QdAIpzjdtA4V164Q/L2j4FuUtTsjqBcS4800iulnaH5On4NbmEtumczKIdoCj+6eN6swOGH3KlICk7pUW0xaJxB6wP0TAcrD2AUd63CMBp8+UZPfJvtYbz6UXqB3rYYpoB0cbT+BTnPNUEJbZyeVMu4SRUw2KfG6q5oEicCf6l7GvikdtL7H+1iLDNxzirz7CiV1+G2S1AA7ijXPqQ4dg6g/xVkJdjS43VQd3iJ0YPHLh4yb5cyo5X/xjsQbvOBgvCJd7L6R/gJBkik1dvvOJ3x2PytOop2y3kN5m8bWVv0k4i+vF33hTcz8s2yRzACHsBH19ir4N296NoYUzOdvQTZ2aA/7TmZZ6veiSM91B1301jmDAUf0eS1EbHasWhKfjN824EYAkiAm9jXmTQvB1xuNupGDw3yCySYyZnVum/ImdN9Zu75kXD1HGirgXS+ymVGcUzMRI93KRelOwzCKx5BN/7CdGVHXyRqydkeefGiT+/Ci6uomcqgn8gX/7Zs9K63LNo58U1rFgnWKQMPdedYCmhl+c39F6ILJHjw4x3tv0kyO9/kVPu9RtoqBcOFKsNe4lCgLQX3ODLsAcT4FuJsnzjSTMqnfyAbrTqQW3qppEidjZNtKvjMAtQFUPmRIzMYdBMOpKA6emVynGlcvtvUwqdG1v7VaZLlg8E1wJZJkuXxA631HR4J+2r4NwYjzhu ivZYltzf NzMFCa4Thz49bo4a31N4Lc9kJ3CLbOarKTpG9etO01OFvyF/wJcKXfyTwitMXLSHhbHWy4hd5pyq0b9Fqqcx+1oWM8SSNW1aw0HSrJb9W5+no8d4o0rZsN6FBHLQd2XIHEbOw9CMK4M0Daerf006dWc2l3uKkxMEVyMlxCWPX8WtvKJ/ZpflF0bgIl9mcl65V1mN8mjsFHdFNtMQ5vZhgO9LrqQpAXA2vevdcbB38yc3Jt+A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 31, 2023 at 04:46:50PM +0100, Ryan Roberts wrote: > On 25/08/2023 14:59, Matthew Wilcox (Oracle) wrote: > > The few folios which can't be moved to the LRU list (because their > > refcount dropped to zero) used to be returned to the caller to dispose > > of. Make this simpler to call by freeing the folios directly through > > free_unref_folios(). > > > > Signed-off-by: Matthew Wilcox (Oracle) > > --- > > mm/vmscan.c | 31 ++++++++++++------------------- > > 1 file changed, 12 insertions(+), 19 deletions(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 965c429847fd..d5080510608e 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -2489,8 +2489,9 @@ static unsigned int move_folios_to_lru(struct lruvec *lruvec, > > struct list_head *list) > > The comment for this function is now stale: > > /* > * move_folios_to_lru() moves folios from private @list to appropriate LRU list. > * On return, @list is reused as a list of folios to be freed by the caller. > * > * Returns the number of pages moved to the given lruvec. > */ > > I think the "On return" bit is no longer true. It's still true, but misleading ;-) I'll amend it to - * On return, @list is reused as a list of folios to be freed by the caller. + * On return, @list is empty.