From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A250CA0FE6 for ; Fri, 1 Sep 2023 04:03:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00E558D0017; Fri, 1 Sep 2023 00:03:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED92B8D0002; Fri, 1 Sep 2023 00:03:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA2108D0017; Fri, 1 Sep 2023 00:03:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C79FA8D0002 for ; Fri, 1 Sep 2023 00:03:32 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9E9FC16010D for ; Fri, 1 Sep 2023 04:03:32 +0000 (UTC) X-FDA: 81186684264.13.BD113D1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 084EB1A001C for ; Fri, 1 Sep 2023 04:03:30 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=BJRfh9k0; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693541011; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a3BmFQMtMx05qWXDIewWkhlQfwjopJC+FXRM4M51WUM=; b=NaGwwzLBEcuwhC/wz3C5f9uKJCoFkRwqCYl4oLqciQMMdviA1XlpFX0cf/iigJXd9ueB0h 3fNjqBuMVFa1K4aeZunQPiFxsYT8eZxU6gI4HYZmbIlAzpGIM8kwXR43WyfHaWzN750BTp mtn2/T1LP139A1x18kx6UB1G3n2wTi4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=BJRfh9k0; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693541011; a=rsa-sha256; cv=none; b=buSIprc35o0P05Lv6hld/hOs/JYcI//HL4S61XrV+JTJz9kypJi8vfiPLHChCDbMvHyFJk 3nhhuZYbAN7eFhnJtyRFPNy4X9W3EE8dJ6jqo/uTFIlSxm9OtykB/4YaBrZs/9Zu0Y0Deq MzKke6BFuuk6AXbBY0Y02z9hmubpzSA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=a3BmFQMtMx05qWXDIewWkhlQfwjopJC+FXRM4M51WUM=; b=BJRfh9k0IkVPc6mxQYxJzqEbIA NRPaYeOkWjuQg2rNXJaOjvzCOYc3Z3KGKGGyAltxwHD8FXFOoPm3N/Ut28eCZudI/apE416wsbR0w B28TtHwFB7dJTa2lI/MXRUXwsmgK7+fC7DkSwCGmq4Pu3V0+p0tL/VrUBfOKLUCMspQU4XZDXEt15 I3YBW5iKmhrV9Tx0r0ocv82adTESofnmK+HuCoG8Y9tfRpqnQW3UV0tf5MstQm6OcZpKx4FZeQU42 mEcZYigUgr0o11PqJ4bNCYnQFNL3iZGdC/ReXwSRMPV6nmVHln+oZn1SAl+lYaVqqz8CwWM1DAmKS 5M22CHwA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qbvNY-005K4Y-35; Fri, 01 Sep 2023 04:03:28 +0000 Date: Fri, 1 Sep 2023 05:03:28 +0100 From: Matthew Wilcox To: Ryan Roberts Cc: linux-mm@kvack.org Subject: Re: [RFC PATCH 02/14] mm: Convert free_unref_page_list() to use folios Message-ID: References: <20230825135918.4164671-1-willy@infradead.org> <20230825135918.4164671-3-willy@infradead.org> <035c50f0-5bbf-4e57-bef1-aa4b55c7cfd7@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <035c50f0-5bbf-4e57-bef1-aa4b55c7cfd7@arm.com> X-Rspamd-Queue-Id: 084EB1A001C X-Rspam-User: X-Stat-Signature: yrf9yjdu98p6kb6pguxe3ix9nn5ciz3q X-Rspamd-Server: rspam01 X-HE-Tag: 1693541010-404852 X-HE-Meta: U2FsdGVkX18dDjYbyV9z+DMUXbqj/c0KinLVLgQdffs689nA2qH0zd5/Q935vI798pFh/jf7I6PJSiyPS3nW7g0XrctuVXbgWraRKUWLowEXHXvA0lTUIJg/R7H10MfezU80vAmlGQfZ2bEqyAc0c0a8RTHhMrdRHeEqIoDp20vrMYIu0MjU1pYHbb2/yqjpjRjRmUT4TeXG9u4L3991SFwHwZ5pYrXCd/Ww3AWnpEohKOcM04YEK4HhcoOVJegurOm5WcNScq6+YdMTtb1VFcCOsLzrglvMX3THlqnvw9JMThUfqV8LhCzXm23eNDLyB0O2nIt6mduElBig5B3Pv/MZQZRhgHrX80Szej/0BoErhjxwq3ze2kCUkXK9uN2SuvX5rSvnj2XopRY1590/8fCz7vWGTg2cevzP6zVXg+K2JCIvYElNJbiUz5TvP5ZMumB1ppe4T8HAB/IMpjx06fLD85rbSKVyBFvaBrqTiqXZ8uFDVIa2Iws7PYGTNNJatxofMrs//oZmFGI5lp7z5gBCzcCsURjl+LuK/viGh5iGPuukJX5xvwQQI7pFEuBWqWJRBVSIy4AE9ggHfZBoca9s8DeT3Ddoo2yA3dJnNDGeDipMslGOcqiUXqlLHix0dM+RU0wGwFKpgLFcaUC9UYNehoRTLlGvkuMPayCPQd8XL5S/PNIpXPHHaXu4MENm/YkrjvxboEmVPvRjOtCYX8KrKoRTeuz3PH8JOMtd8rY22UtrNVlGQbRIP/6HXE42OrbyYC3LHip7DM0QCjk1jEhiDGw32fkREzQ6rFbn3l4AjhRvPkvP028zA5GlVePtDmlh4tI0QdjPezgE0vbd5LWpZgJcaJWdVhKY1k5wKJ5PhjIKKX4dFAkYtxcU9MW6rPBDAkrI43ULrPf3KvHDLBq95GsjdM14j3vFqNHBpHlvIQf0XgkXYKEa/XYzqh/u5z77Fbd25wejMawxgko A6DvnOe5 xxodOf0e0v1dY1XhQr1BigM+lOZCOEJnOfozGK8HBtFrXkU1BFjxevQlT2l3mrDY1HwaSq8R+Gq228SfKl1Qphkmh8kLiDYCvNWm3P41zoumkKq38SHInlw913Lzztw1pchHGeYIxOkYVte1Pr7WxAeIlLpkWY506W4qHmizWon5JEHzWGWzpV/gBgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 31, 2023 at 03:29:59PM +0100, Ryan Roberts wrote: > On 25/08/2023 14:59, Matthew Wilcox (Oracle) wrote: > > Most of its callees are not yet ready to accept a folio, but we know > > all of the pages passed in are actually folios because they're linked > > through ->lru. > > @@ -2469,17 +2469,17 @@ void free_unref_page(struct page *page, unsigned int order) > > void free_unref_page_list(struct list_head *list) > > Given the function has *page* in the title and this conversion to folios > internally doesn't actually change any behaviour, I don't personally see a lot > of value in doing this conversion. But if the aim is that everything eventually > becomes a folio, then fair enough. It makes the next patch _way_ more obvious ;-) If you merge the two patches together, almost every line changes.