From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3762C71153 for ; Mon, 11 Sep 2023 20:00:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CB9F6B02ED; Mon, 11 Sep 2023 16:00:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77B636B02EE; Mon, 11 Sep 2023 16:00:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61E0A6B02EF; Mon, 11 Sep 2023 16:00:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4F8B56B02ED for ; Mon, 11 Sep 2023 16:00:31 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0D604120BEE for ; Mon, 11 Sep 2023 20:00:31 +0000 (UTC) X-FDA: 81225383862.26.2F70789 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id C0AF2100017 for ; Mon, 11 Sep 2023 20:00:28 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=G+mMyzz1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694462428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c7k1BCCMhUdMc7MBxV2Fkz09e2OQ+XzuBURjAWODFmw=; b=PTUxUoy+ZxqNJAfDG7WwBl2TQNFiv19LYsazly+0JcoEIObqA4jOSb4xxYLw3UJ+mXXjcY fEbkK8sRcw45tSIJhSw5oFrtjehw5lh+BPXVN0YxX6fzbnC97MfEr/HHII5Xix1WOVPCsp x6TsoSYs9ziRclaPYIZkkoJLhCK8pl8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=G+mMyzz1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694462429; a=rsa-sha256; cv=none; b=QpnvMUpdDaSTKmjliBGnT4ijN+MziQmU6+muyNl1srRt6wpjqc3JjhWza+tmTyrIoUaf4c +YEdPqWZojfg8jwfFspR2Qln/tZ+3hF5Bqxp6Q7KwOZpZluY8gzHyAnG8DcUM5ESDyEeH9 XmQRkLPxRBMk0gVCL/7M7CneWCKaoE8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694462428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c7k1BCCMhUdMc7MBxV2Fkz09e2OQ+XzuBURjAWODFmw=; b=G+mMyzz1NzZr3KcF1g3m+mP3DkLs3YMPJwFsbMZZ+0VWKg3g0+7alXfxot0XFnk/aFtpQl kDDO4vZi6ksiJGPfhJQsNh1+wj/0kh+kq1TFOJsdJg4/0467iMaDGBucvvkBo1oEbbRWZh JD9VFF2OfM/LikhHiqz30Lz/GZcm3Co= Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-604-2BZjG6B6Mu-sEuFM4rQo4A-1; Mon, 11 Sep 2023 16:00:26 -0400 X-MC-Unique: 2BZjG6B6Mu-sEuFM4rQo4A-1 Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-3ab5129ad9aso1212408b6e.1 for ; Mon, 11 Sep 2023 13:00:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694462425; x=1695067225; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c7k1BCCMhUdMc7MBxV2Fkz09e2OQ+XzuBURjAWODFmw=; b=GX09FJbQUTHiyDYkK98wtE69FEgPmwrIDyct5yP57Lwhoi1Rw3FRYnckYRZRlTtpYb LNZdYgYXJ1Y4dLj6FUe0EKaOWejQOP1Em3GOL2Auejl1vua7vQ60Ig7Jx11mozzOdcH4 w7OTmvVGWgEQ6ntiFNp+sTycAzc97XeMEs/nf6jWC8O1ZfGswOMZ8Rd0/eGbu48nWd+B RVcsmsm48g2fZvB46AnheaKfwscohM6INz0cn7CBdc0aDICtAocZ6/Ii+8/pulZxkeBu dZBM5id5zkJ5GRoUNDgTYkvlgVcq6YadLL2FU4FWrWD7AMBK4WejwfyjdVFJO6o5+1Zm 7SoQ== X-Gm-Message-State: AOJu0YyI3o8CjCmfLm9HE2mMfbBquJzZB7e69UDzN7pm1pImqSxSERJ6 c4QVflPU+bc0WK5PYLMo4hNVjcpLNE+JmLcsGPHzw7zl6IqSc5pNIw6uYqWiQ/7NkUynIKVtcB8 syADCdozJhkE= X-Received: by 2002:a05:6359:6393:b0:139:fd45:5db5 with SMTP id sg19-20020a056359639300b00139fd455db5mr8262759rwb.1.1694462425126; Mon, 11 Sep 2023 13:00:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHLSLn699Uw0nOKsm/qG04I1zHHRgNNS45OC8Q8LJ5yPwlslg4FRPCQrknANhYmqNDDC0Bcjw== X-Received: by 2002:a05:6359:6393:b0:139:fd45:5db5 with SMTP id sg19-20020a056359639300b00139fd455db5mr8262746rwb.1.1694462424820; Mon, 11 Sep 2023 13:00:24 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id dd4-20020ad45804000000b00655d6d31470sm2273025qvb.43.2023.09.11.13.00.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 13:00:24 -0700 (PDT) Date: Mon, 11 Sep 2023 16:00:22 -0400 From: Peter Xu To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Anish Moorthy , Axel Rasmussen , Alexander Viro , Mike Kravetz , Peter Zijlstra , Andrew Morton , Mike Rapoport , Christian Brauner , linux-fsdevel@vger.kernel.org, Andrea Arcangeli , Ingo Molnar , James Houghton , Nadav Amit Subject: Re: [PATCH 2/7] poll: Add a poll_flags for poll_queue_proc() Message-ID: References: <20230905214235.320571-1-peterx@redhat.com> <20230905214235.320571-3-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230905214235.320571-3-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C0AF2100017 X-Stat-Signature: f6y7gccn5y7xw6fff7szaoze9opqupwu X-HE-Tag: 1694462428-404469 X-HE-Meta: U2FsdGVkX1969c3PITpp3h9+UcAHID34n+0djSKp7Pen87EH0IZSPm4Ff5jswBwZnTXzooAQxeVPpKwtAz2KaRKVt9oTaQeoIMqc9HBzBiLzaaza4kRwrOxJsDxmwkwHhtGHnX6h3QVDLCOExqpC6aRIxq6+DYawUJxkvcf+qZE+GwES4bjAzDddXFKBYNXuNHNVlHLkjiaow/N7NVcYqm8Ye7Y4MpRUpMxIa4wt2orzsUiMLhpkNcLLQ97TSu4owmPDoMnWvHqK/zt8/kYWwSPB/D3NZ2EUbm9Fsgz6dIDn4WvBYuB7ZE80X8Uvbu0iPn6WTvFqOoAVcZGTg0rXu4D5ztKxOT0gLS9tgOEOixC6OwDVqePMyu18vz2Ao3Y303aQAX9bBgIti2Hdx0YTDOlnO27VPkMPZDwb1/5Rv5Wt01Kd9kVCj9Fvs56qQZ3UldDkgy4xDet+x+mUnWTBRvTWv8+gO5beXZHwRbARpUfet+hGYzcThQr+++/gCrEe1rdX7XgiKXOfTaSADT5050nEsypF4T1sXqRwuhGuK8g0TaS/SPVbZW6IwupXUrXyG/eNL82sUma3OlKa1csI7mCuHaG0PyZWN8x9vHEiCebR07vlJO/BHPwulNpDtnPCNI71x0a9MAld76Kx+tTIdEJv4LqtelqdZr7dDM4cNhL5STiTwIvag8f68lHCfg/76fTQYKIvPJa6OS2S3BK/xWDvErUOAaYhY+XQNtfov/gkT/X82aT/t1EWaX4k6sB0rdFc6b617jYXQj3Z+EvOgWXcyOAaEF24qWAvpBnDliQ3iukE9LJa2nNg5X5gqTYGgWrE0wXlvYhW50ma1TYkUGJTkD1utIpLMcYQHXah/gKYiXIb3kOh9u1SiZCvP7lLPF1WeAxeaELpBrW6xuZZegFxLd+hzlDcu7q8KS0/Us6IkEqfT3NoZuPNxBQqJiQd7naJyKpNJdIH1FwgeW0 E5Bd3pH2 yNVsTYNtlPt+0i4vPwfPYcvolHPB5OGiL8ZHRLcKKmAdRjgqtaToiMC+loYQnCsolhULrYwjxbFZ6tPW61Qa3lpj1BDwnFzdSHjv1EwHG8ZAzCNw8/8tekCGKGDZA+0J3B8BV+R2k0MqyQs8sVXxXP/cQBOk1fp4L8SZMHZUP175Iz4QOujLHw2i6xFTM9riw9JKnOGN6Jz6zc1Mv5QuWwPEsrY2vm+xVobVZA1Ak4RHhAEA6hpxxokPtfNAV+Z2hRn8V1wAFiON1n/J6HWl08y0dKcCb0w5NO72dSIsKl+Rxlzqlk0YiBGMFKlBBRWO5qZwRGxEymSn1F6hevqKGE2fphYv6/8jfybhRAc4Mam6ywVzZM47wefeMftN4PJH2vQFsXC7Fj5x/EH2Z/f0VOe5OREFA254L96NmvlDzj6wMa7dJh4JZOIl9TBTv4Z3VOLq9jM2cPiipSHyRf2adjev6wwySOmVn+Gq1mQ42p623riaRWfJhzsrZMj6XyPopgRBe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 05, 2023 at 05:42:30PM -0400, Peter Xu wrote: > Allows the poll enqueue function to pass over a flag into it. > > Signed-off-by: Peter Xu A fixup for this patch (should fix all syzbot errors): ===8<=== >From ba55ee0539a7a80b98e7a5e3942c0ee8cabe5f73 Mon Sep 17 00:00:00 2001 From: Peter Xu Date: Tue, 5 Sep 2023 20:05:33 -0400 Subject: [PATCH] fixup! poll: Add a poll_flags for poll_queue_proc() Signed-off-by: Peter Xu --- drivers/vhost/vhost.c | 4 ++-- drivers/xen/privcmd.c | 3 ++- net/9p/trans_fd.c | 1 + 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 02caad721843..00813db53ff1 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -152,7 +152,7 @@ static void vhost_flush_work(struct vhost_work *work) } static void vhost_poll_func(struct file *file, wait_queue_head_t *wqh, - poll_table *pt) + poll_table *pt, poll_flags flags) { struct vhost_poll *poll; @@ -162,7 +162,7 @@ static void vhost_poll_func(struct file *file, wait_queue_head_t *wqh, } static int vhost_poll_wakeup(wait_queue_entry_t *wait, unsigned mode, int sync, - void *key, poll_flags flags) + void *key) { struct vhost_poll *poll = container_of(wait, struct vhost_poll, wait); struct vhost_work *work = &poll->work; diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index f00ad5f5f1d4..43e65186f25d 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -914,7 +914,8 @@ irqfd_wakeup(wait_queue_entry_t *wait, unsigned int mode, int sync, void *key) } static void -irqfd_poll_func(struct file *file, wait_queue_head_t *wqh, poll_table *pt) +irqfd_poll_func(struct file *file, wait_queue_head_t *wqh, poll_table *pt, + poll_flags flags) { struct privcmd_kernel_irqfd *kirqfd = container_of(pt, struct privcmd_kernel_irqfd, pt); diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c index 91f9f474ab01..2912c4b086a2 100644 --- a/net/9p/trans_fd.c +++ b/net/9p/trans_fd.c @@ -545,6 +545,7 @@ static int p9_pollwake(wait_queue_entry_t *wait, unsigned int mode, int sync, vo * @filp: file pointer being polled * @wait_address: wait_q to block on * @p: poll state + * @flags: poll flags * * called by files poll operation to add v9fs-poll task to files wait queue */ -- 2.41.0 ===8<=== Thanks, -- Peter Xu