From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CEB0EE57DF for ; Mon, 11 Sep 2023 18:55:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3EF86B02D5; Mon, 11 Sep 2023 14:55:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEF706B02D6; Mon, 11 Sep 2023 14:55:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB6DD6B02D7; Mon, 11 Sep 2023 14:55:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A97426B02D5 for ; Mon, 11 Sep 2023 14:55:56 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7834AB3C16 for ; Mon, 11 Sep 2023 18:55:56 +0000 (UTC) X-FDA: 81225221112.05.59F3580 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf01.hostedemail.com (Postfix) with ESMTP id 7529F40009 for ; Mon, 11 Sep 2023 18:55:54 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=FpkyH7ex; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf01.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694458554; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X4v+SVoqNGZrG3L1cc4+LLVgiWOB/yAKVlnaBwPQuJw=; b=e6r53BXipRQ21zOLrI2YamTiQpZi3FLN58BjVA2XkO2pdV3ZJfF0zp47gVVIEUAWl+TOA1 rWCYmy8QitkDkodnJWMrOYqNiZCbPFqxyOS3XYz+Ta7SnbeBkqbsy0hgHl3PfMLqqYoxFK azGqRrqVFMMMQb+lGJB4lHQ4ynFTj7E= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=FpkyH7ex; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf01.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694458554; a=rsa-sha256; cv=none; b=c7+s+DkqhtOYa2pKA8LmKrHw39Vb+oJv/IfCIhoQTEYu54VMUN9QDbaNYN0mnsVsrutCgY gGCy92dMDfrfxtFvs5UC3Mdu76N6jY1NTbmYQNL54R4VPqpamBbr25+cLlYOdwFLtDG2Wf SCZSUg2VvX8b9ba6r0F9KumMB+yhc0I= Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-68fc081cd46so1218208b3a.0 for ; Mon, 11 Sep 2023 11:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694458553; x=1695063353; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=X4v+SVoqNGZrG3L1cc4+LLVgiWOB/yAKVlnaBwPQuJw=; b=FpkyH7exevCTQOFNOFwtkJhbLHVpxzgG9ZZHSf5wajdi965/suK4j/Z3bB0V87LIFG 70UGu1/LFDDqzm7yWs1t+9oQsfnWs0kdHC4NztRzbXVF4/MPJ1NbZen2qNYqSE+Y1zo/ wNT+ITygE4kA6WPFzSnFIogAzh4CRJCk4Hnqijegc6nnxkRtrRJpDXJMjg5xMkoPwqy4 lpktfmfVzZD61pjjC3NbEW8ypg/9cxwtRQ9ARViLBCVkACvIRtVJsWGZjAOueaWFnju9 O+7bcMQ/8e56YHBQqPCu8Iz3uE6+Rp4ctqr3MT/nWaqtsp8EE7YVm8hKAypXOCIIzUp7 6k8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694458553; x=1695063353; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X4v+SVoqNGZrG3L1cc4+LLVgiWOB/yAKVlnaBwPQuJw=; b=geBcrUlR7Y35sMgW8pF5WFxs/X7ev2CvvRvetPmO2KRCEPsRoI98HuBlEscuNONn1b Lt20w93X/FZvag2nUy22T21dKC1iSQWZsUWAOckdwa7viang0UdyMCvKEPstuS2uyWJM NTpq0gszxxOVkqFNseeUsC0xNbGR8sm/iq0gKr3vABgo4irFR1+cvKBiVUq3BMoWUoj+ +6WxkfY5CnPTlOGVbQabOAh1mSMmIWTsYM02R+hM3E7TqLIer5AboXv4SFj30FcnbiaR tznN0zJkudMBn91JSEJ3FHQlhaFswPE03wwukLMy984Bkn3ECdyG1YMF2IiGuChxnqGU WH+g== X-Gm-Message-State: AOJu0YxUc5DwCvs0OPoZlQfKz2A2Nefc21JfkWbixsRDEapGSDliC3Zj 2Qn4YLdWQGSiLHxAaWoWG6M= X-Google-Smtp-Source: AGHT+IEorBOJmt+LDA4QY7gxpy//vazvi1cD7qOl3PDBlyGrzPrLA6zDS+OwMSagdNQj9a2OZaemfQ== X-Received: by 2002:a05:6a20:842a:b0:134:9f4e:623f with SMTP id c42-20020a056a20842a00b001349f4e623fmr10184955pzd.14.1694458553196; Mon, 11 Sep 2023 11:55:53 -0700 (PDT) Received: from localhost (dhcp-72-235-13-41.hawaiiantel.net. [72.235.13.41]) by smtp.gmail.com with ESMTPSA id j10-20020aa7800a000000b006661562429fsm6085648pfi.97.2023.09.11.11.55.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 11:55:51 -0700 (PDT) Date: Mon, 11 Sep 2023 08:55:50 -1000 From: "tj@kernel.org" To: "Yakunin, Dmitry (Nebius)" Cc: "cgroups@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , NB-Core Team , "hannes@cmpxchg.org" , "mhocko@kernel.org" , Konstantin Khlebnikov , Andrey Ryabinin Subject: Re: [RFC PATCH 1/3] cgroup: list all subsystem states in debugfs files Message-ID: References: <20230911075437.74027-1-zeil@nebius.com> <20230911075437.74027-2-zeil@nebius.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230911075437.74027-2-zeil@nebius.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7529F40009 X-Stat-Signature: c5r7378i3g3cycscop6hnx5mui4ek4z5 X-Rspam-User: X-HE-Tag: 1694458554-213537 X-HE-Meta: U2FsdGVkX1/pI5T82vfCJnBA7MJXHslFbObQ1qosiBd/aZrP+H5f7ViXiN1NuwVJ/Azfguhd5ymJvop18SJbSzbDdTDQ+Ze30ecaISALPfrmh0phmLfnstthePQoS9Vxq2wh3cAApauPHzDjuYLlhhTsKQSAy7qgOf3CCeBEFn+4EGU4qZjpt9zHm6IDO4qGZLU6632nuKL9WAMlinPYSaGlKSh4J2FIyUkGQG9abjb2ODeN0FkIPp4KpTH7vlXpQGqaM1MULCxExid/1oHMdpcLXGBE3b0NlamqxvPySr6jIkaXTJatRkF3F6rh3CQjnv2zIGhRScLj8L6pZRJgofaaRHqIng0f1m7bBIQf6GvEJ/fJeAtR/tUeGgVepBr9nyCPL4HmlcT4TkmVMnIieArLs4xQadxW01l7dMOMdlnR6KG6Nw8Ow3tInMdi4I05ey4EYvwKI+l+9DMKn+yD+gXC+VLldViWfN8eQ657U07Q+F3r4Cj6ZrNRpqdEUS1RUuYlu3eT3EODGUeIqnNLGVC7O8WwIuPSDzM0eROrJJhlcrfIrWOdKnMhI7kAEzqSTmFmLz3FjLrNhV2umChpth4zwxeb2zr5k6vghXlE9epU2cS3kP20cbcLdGqzMr7Vg8myDDMugwVD7NJ2AusQcnyhiX+eAnaUsuLmf+qTF8tnvcVkAxiaoJid3kSaZJ2gaXbm862WVP22+lKZjz0MHH8nMH6rgigZ+VEPJRv9DFL0vTtFLCZN2Ce+SnpwZ/dyOe98QtvMCSGrt+TGWqD9zhlARAhSRLOyNIVWooEZJ5EmZ++W1wUKMFgHHWab0IG1koBdmxEWaStWaW7VCiDg/lNuXSTb4xpjySLlfYRxVgnUJx8uAfPMSGA0sKst4/FobPDMtd+MFZmyBy1IJ1lrNNzCddob2ZWn2XNGn1lRG8XRqum/1EzIwZ6Yx+h+xgEaQpbAdvcLuP76Xhpm9Ru eDnz6G8J 63Us4UV4i0Y8281YbLpyq97esgBpC+hMKuYbtHMKD5vWP/ddGBhc/NK7q4L1EyXnyFKypKBTTH9/Zct+JDjiY6cjVBdHJaVV9W6G9gGFwFCy7FR6FJSUXpxTenTuix7ftmQjFoau5FqNUttD5Ywg+ihj39GhknDQeR+4FEOOQR7y0r5+9m2cuR9Y8YIXZ4kkil/4WleYUuHLKnpByv7CLzUm0qkLkC2JVQiR1tMM9AIbnpJDqbJrPF3tuThMrvemEpO23OeBsTLajqiA5ZhTSRh3+PZi3jTGzT2CRiqnyuSgdox5K50R37KdwsrsbxoKKBGcLrWjQ5aKHIEJA+ZHYakgCxfxQHA7rCRRlP9t4RK1b4nt4AHfK5j6gi3C/Uty2B7Sg28Q3oVXcRciLqu5I6PWlecfRPcm+KlCSui5Qyb42V5wh3x0nbmHvXHGZuhfbocXpvnUyyRa00TlSf0yg1j+IW7sPlAQyaUDc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 11, 2023 at 07:55:15AM +0000, Yakunin, Dmitry (Nebius) wrote: > +static void mem_cgroup_css_dump(struct cgroup_subsys_state *css, > + struct seq_file *m) > +{ > + struct mem_cgroup *memcg = mem_cgroup_from_css(css); > + > + seq_printf(m, "mem_id=%u memory=%lu memsw=%lu kmem=%lu tcpmem=%lu shmem=%lu", > + mem_cgroup_id(memcg), > + page_counter_read(&memcg->memory), > + page_counter_read(&memcg->memsw), > + page_counter_read(&memcg->kmem), > + page_counter_read(&memcg->tcpmem), > + memcg_page_state(memcg, NR_SHMEM)); > +} Can you please take a look at drgn (https://github.com/osandov/drgn) and see whether that satifies your needs? We can easily add drgn scripts under tools directory too (e.g. iocost already does that). Thanks. -- tejun