From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1562EE14C3 for ; Sun, 10 Sep 2023 03:02:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99DBB6B0123; Sat, 9 Sep 2023 23:02:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94E6B6B0124; Sat, 9 Sep 2023 23:02:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83BF56B0125; Sat, 9 Sep 2023 23:02:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 772916B0123 for ; Sat, 9 Sep 2023 23:02:44 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4205512083B for ; Sun, 10 Sep 2023 03:02:44 +0000 (UTC) X-FDA: 81219190248.27.47696E9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id A6318C0015 for ; Sun, 10 Sep 2023 03:02:41 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hDFo2iqp; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694314962; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BDaxoltn3/UZiOrwW4Wv/EpuuPmh9gcWTTnPbzfAnLs=; b=wy3GSUczqtDIeJKro/atcaLQaN4+wz4n63kf0gIJesfLUSwyoB4qEJPagGzIGDP4suVsaQ dAep3rrI+TlZslA/v7HYJBJMInO2KNh70pcvOXE6lKq9Kl8ADX1A6HxImOhoiM3vgBZQg8 9QuHyM6whQV6vx6SZtPnf5+zXAMX0rE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hDFo2iqp; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694314962; a=rsa-sha256; cv=none; b=3IQjejtU7KtUdFz6AD5JVeDoKOgjn3zdk0NYrKgm2XLBw2SqEQ732UhZTQteoBflqb6IzT vOCmdumsWY1UnxrfYRdkjasteADtNUbmeOrZwRsh+EoQ35ZUUxfvI1C2wgCrY9yCByT2L2 U6OY/oxWWkiaNWLwTx6KUgJbBr1JdQM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BDaxoltn3/UZiOrwW4Wv/EpuuPmh9gcWTTnPbzfAnLs=; b=hDFo2iqpTUgigrRKVdsPNJTzIG 2fQPelSUwOxxNzBfKNaOgBo89JptFra0YyvK91cc/0Ff2LGvtUMTl+MCPYLNZj1MS7uR6aMNcpkCe 1o1xwlpJv/vAnlBaexk0EOaIndxYXrDiRbmEaPnzGkGjWa1ToNPZTwE4wBXo/tAlg3dp6PwDZlI8f KPYsk7C6KUnBqgMOYa0ttSGyWUmpfyzHbGB6+O4vOjD2VsDlYAXpoTL8C93E5dwZmFmGdZJW7WQNu QN1D2xHDZKswW7TEnfysJY8BB9+49cCt7GL8GWEc+zYhHNVBmhvE6W0USvjmJxH71628iGilQMVAE wIyOAgiQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qfAiW-009vBp-Js; Sun, 10 Sep 2023 03:02:32 +0000 Date: Sun, 10 Sep 2023 04:02:32 +0100 From: Matthew Wilcox To: syzbot Cc: akpm@linux-foundation.org, fengwei.yin@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [mm?] BUG: Bad page map (7) Message-ID: References: <000000000000d099fa0604f03351@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000000000000d099fa0604f03351@google.com> X-Rspam-User: X-Stat-Signature: 46sgt6jh87ctg8mjwy8m4hygdqpekptu X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A6318C0015 X-HE-Tag: 1694314961-396321 X-HE-Meta: U2FsdGVkX1/7z9JCf857udK0rads5ZMVDnGCH3XzncqJgPnh86Cf/Ymk4Ps8CdLjpFDlC9B609i3s1h8GvLmjwq9SAaAzpSkDZtxbPQ0CCSd0UZW2J0mFb4LJ83ULp24jRn40H8al9FFAwrunTmF7yjd7KKJ+iGYn9ZbVz5OZ+UghAiNbjN8L2Lic9JPF14GtXXRqLpii4eIhAyYAYFaVip9ALsmOw8jxa4PPuUzm7lXGQSutfD1DqwJ7naCKJd54OEXJ6oNFoQOkq6Y2HFwPTEpbrKK+IqUhYNbyXm/LVmcu0GEfeY8BuFw1OCLz7R3sn4DFokIiTY8m9ZlMsNco2bIzb1SmK1oH6YR3b8KBGm0xlxzhPx9IB1QsWjdjgZYYNuPQ5gPNt8M2TUTfq2KDHkAc/H5TVIfYa9NYXRAnjDMOiVTf0VwVR73afqIOjevSrEWPhPe3Abt01/M9vI5S8TxvxilGY6dVgKePVRbq9uyiRHjKwizCeDODH0cQc8ZSSy+wdruPzBgekBlcDGiGPgLK8OHTJKIotBcDcXHD+pz1/ZMSX/TXvqaKRVrr1YUwC7gmWCRqnuAlhAzTEePELHfnu+A1IoqYQ3nlC/gidXUEsEwQ94gru4rifkbiGFckH8B6on19wjAXYNHsp5KvpNs7qtsUKB/BkTum/SwBXw2VsNJ7mRuVJSYU9fRVsNLdTI+mpFzAfMCA8uUMzkM0SCkmqZhPfmi29DL7kU+b9BBHABDWdRV+jAX7ijbAgk3gU4yh8uCzqI1m8WAxjAGfRSsqJiLVD5aLCwq0fa+Rlec/QMrRZQ9EnkdTpzl41CoZ5IsoOs7Hlk2NtjoJrBiqwVjhe2SDgD5Tk5JFwXj5xdvCHugjND+ktpqoWPcb4/hATWv7wczWOYyjGPOPsmmznkddG1ARLNaQIJ+Q2MZOSdiBQUoiyrxpKtTjJVk3RRkgBZwY3pZF8nkfB7THhR JVOCyJRy OhqJRdK3p3tG5V+bi7l31RTCRdaXfl+Ti9/rWnqpy1jwDTa9dtn4+SLUvaCi2Hu/s07u/kPFRB64KMa4zhbS04qCCS+o4oieK6XaLlGbClf5pRGWfjioBs7uLnPUI2Owguq3DSYqntD+wFfs3vYxFtOo/VXY/KPTa031Jiy6wJ5ldHQtndIMGIwcOioRiZQfJZK998oKziUywv9zmbZNP/v2D00TlFoIdQf6v8WmMmMoo1yTOUw2r10hzwmHBPYEGMWBmML+Pp9x6k5N6WK8ULEJ+vcgs92WqfEgIFlbDoB1oYrM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Sep 09, 2023 at 10:12:48AM -0700, syzbot wrote: > commit 617c28ecab22d98a3809370eb6cb50fa24b7bfe1 > Author: Yin Fengwei > Date: Wed Aug 2 15:14:05 2023 +0000 > > filemap: batch PTE mappings Hmm ... I don't know if this is the bug, but ... #syz test diff --git a/mm/filemap.c b/mm/filemap.c index 582f5317ff71..580d0b2b1a7c 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -3506,7 +3506,7 @@ static vm_fault_t filemap_map_folio_range(struct vm_fault *vmf, if (count) { set_pte_range(vmf, folio, page, count, addr); folio_ref_add(folio, count); - if (in_range(vmf->address, addr, count)) + if (in_range(vmf->address, addr, count * PAGE_SIZE)) ret = VM_FAULT_NOPAGE; } @@ -3520,7 +3520,7 @@ static vm_fault_t filemap_map_folio_range(struct vm_fault *vmf, if (count) { set_pte_range(vmf, folio, page, count, addr); folio_ref_add(folio, count); - if (in_range(vmf->address, addr, count)) + if (in_range(vmf->address, addr, count * PAGE_SIZE)) ret = VM_FAULT_NOPAGE; }