From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D21CC83F19 for ; Mon, 28 Aug 2023 12:58:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD7B68E0018; Mon, 28 Aug 2023 08:58:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D87AC8E000E; Mon, 28 Aug 2023 08:58:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9D738E0018; Mon, 28 Aug 2023 08:58:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BB5C68E000E for ; Mon, 28 Aug 2023 08:58:52 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 89C8612023D for ; Mon, 28 Aug 2023 12:58:52 +0000 (UTC) X-FDA: 81173518104.17.1EEDACC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 7F592C0019 for ; Mon, 28 Aug 2023 12:58:50 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DwxaEdEk; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693227531; a=rsa-sha256; cv=none; b=QKfgqvJ70CHndFwVOuAWPBbXBWQCujGkTz07phMqQX1eh5lhKMV6vkNaSLie+tuDwMfvrH 0d9m9cSIWZj0ZkX2zXFXzqKalPtZ9KSMR2WMYEut3d/izrjf2z1lNt2FlqmXdKw6DVMS9n zvT2kTkDNL6nn5LgkaFklFQ3GC6s+1c= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DwxaEdEk; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693227531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sW6LnirGj6+UAWdXfqY7HvMqDfZlm+4cGoHT4etwnio=; b=3kUKGhNYxG3msgnv8aC3zdqrpGmkYw4uxUJ4yMyQ2mqkmnWqPG9XyZmkEux20E4e9O0bSV Pk8EMrl8yOPyGdsrS19ys/i+7qqzbBR8xN6XpgLeqFn08zA0XWlybNJJVSqOanN41Jj0Go GhYheLlaObFkQBqPHeEwWefN4uKu7CY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sW6LnirGj6+UAWdXfqY7HvMqDfZlm+4cGoHT4etwnio=; b=DwxaEdEkOpnHUeh+o4K6hwLan+ J4jaFWBUR3yQ8qBIJGOGRiZ69PArsWJEltwc9GFb+6rpYbI0sn+uvAQ9H1Qoo6FYAaDEMTgmP6SnP YefpfQQfdJaKgSgL4ayk/6Fd+F7vHy7OR5EXrtVKsvCycvMj1BGoN6KB5vt9AhZALiYefwPdwIpCK PC/jazFaJ1vUh9Vyc/FsI+75VfPkBmpR1JDL91UQ8qq2lptsdZ5oHcxMzwBsNlALQNyvoMg62r120 8/e0XK56De7ZVoQS4XfqDDSX04PZtEpxkp9EZEg3vFNKVEebAXsDtdFEZ0yjX3fk4yeKziwG7S51h osWPvy6Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qabp6-000Mau-9z; Mon, 28 Aug 2023 12:58:28 +0000 Date: Mon, 28 Aug 2023 13:58:28 +0100 From: Matthew Wilcox To: Xie XiuQi Cc: akpm@linux-foundation.org, irogers@google.com, acme@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] tools/mm: fix undefined reference to pthread_once Message-ID: References: <20230828122157.1541087-1-xiexiuqi@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230828122157.1541087-1-xiexiuqi@huaweicloud.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7F592C0019 X-Stat-Signature: 343jb4ni68byd7of4cfsfapod3bpyiwc X-HE-Tag: 1693227530-853448 X-HE-Meta: U2FsdGVkX1/Z+NOoldePomJuA/8gdEoA3WuVzrh9pqfzTZ1DVFGMKbFkn4Mwep+pcv2ZYv1ynPnrJM7/HQbAL8GUiSOKxuTrf80+rNDYmo+pOWgmNK6owzY6RP42MQhr7PV5kdQCd9QQ+5eZJ8dNOetj6/B7vYvt2KKI4/CtKKb/j5qtGNelGnXq9AfwJYHBo7dY8PTQc9wSB/nSca0l/A2mJ1eTgzPzpYep0tWKiTZIh3ym7PwgYFKrPBQSSe6iFOoQK4Put+1Icc2lKlDpNm3QcZHwPbU0rgnQwcPi5bwsMGkt9kWICPW0g2z21UGzvY7FeF2ucnKdSvoNxdYy6wt0ZwbLRkMTldcLds/+t10afIiLmKyio4dXp9so2qMbyXY+kb3HD15eQNIk+Ng7b0Y5qX7MX4Ys5UzUmoEYVsvwBNncGct2mEAYPFrLhFVJ3b1eGneHcF7lrtmPcQkyitzvuFp9+u/7N9TOrqtXWCKzYhFFMtqqqWfGDa5TRjBCAdc55UMknCRy99cXvKFcmbAZWQAbnFxL3ugR+5HQI9Jy4nCYYUrD32Oe5WTwJ1vFYT8vQrH2OsiWDfgxkTOnw7ncrZYHMbj+8F7UpDc3T7euKMVQB4BjE3n6vUhsD2FYyKZva+X+6osBWH2IgfHRwp4OxXyB9TsulzTs9V4P2eX63P/QqZ/frXDHFCL+hwouHcNzOiGjtkup2efEzjUcRvPW25ktG6XdmS/Zy3h5Bxffen35eTxmZUzR/yggcyupZpEn3j7wEb2WirkNFoPTCw3GacYmAMcRum/AFO8YDv+IqH+qWKKBlsp0OFto2t48P3paKpaaAglnVMCOzZQtm+5swBstftRM16qD2DOVzxFPXY4y5s+bFmUsorPpu/bl56EiXZxyt7Spl7c/Y8p3it7VAAy+C9ZU+htZcbBk0L7zGAR2QggQHFJWZ91qxkPnWwKKtKjEGv3HHJOaRfT d9NBeBNi tYMsfKgT+XUZpirJiPJd17tvEmezo6WktAhG76FJ0CYiKcinTDibliir/CdxEDtsAKCRW2RUDOxxXD8Hjvd4ZXX3M4DdpfIo6DKwa7A1dAnwLVJRn0b72+ItRi6S5B7huCVOfS1JOEzFheNk79qZ6ylp4VrDWJrm93Za2lRSBB90A+h1/ggjeEDcWtw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 28, 2023 at 08:21:57PM +0800, Xie XiuQi wrote: > diff --git a/tools/mm/Makefile b/tools/mm/Makefile > index 6c1da51f4177..9997b2e401ae 100644 > --- a/tools/mm/Makefile > +++ b/tools/mm/Makefile > @@ -9,7 +9,7 @@ LIB_DIR = ../lib/api > LIBS = $(LIB_DIR)/libapi.a > > CFLAGS += -Wall -Wextra -I../lib/ > -LDFLAGS += $(LIBS) > +LDFLAGS += $(LIBS) -lpthread Is this the right fix? I'm pretty sure you're suppose to use -pthread in CFLAGS in case there are other things the compiler/linker/whatever need. '-pthread' Define additional macros required for using the POSIX threads library. You should use this option consistently for both compilation and linking. This option is supported on GNU/Linux targets, most other Unix derivatives, and also on x86 Cygwin and MinGW targets.