From: Matthew Wilcox <willy@infradead.org>
To: Xie XiuQi <xiexiuqi@huaweicloud.com>
Cc: akpm@linux-foundation.org, irogers@google.com, acme@redhat.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] tools/mm: fix undefined reference to pthread_once
Date: Mon, 28 Aug 2023 13:58:28 +0100 [thread overview]
Message-ID: <ZOyZ9FgRUOGPh3qm@casper.infradead.org> (raw)
In-Reply-To: <20230828122157.1541087-1-xiexiuqi@huaweicloud.com>
On Mon, Aug 28, 2023 at 08:21:57PM +0800, Xie XiuQi wrote:
> diff --git a/tools/mm/Makefile b/tools/mm/Makefile
> index 6c1da51f4177..9997b2e401ae 100644
> --- a/tools/mm/Makefile
> +++ b/tools/mm/Makefile
> @@ -9,7 +9,7 @@ LIB_DIR = ../lib/api
> LIBS = $(LIB_DIR)/libapi.a
>
> CFLAGS += -Wall -Wextra -I../lib/
> -LDFLAGS += $(LIBS)
> +LDFLAGS += $(LIBS) -lpthread
Is this the right fix? I'm pretty sure you're suppose to use -pthread
in CFLAGS in case there are other things the compiler/linker/whatever
need.
'-pthread'
Define additional macros required for using the POSIX threads
library. You should use this option consistently for both
compilation and linking. This option is supported on GNU/Linux
targets, most other Unix derivatives, and also on x86 Cygwin and
MinGW targets.
next prev parent reply other threads:[~2023-08-28 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 12:21 Xie XiuQi
2023-08-28 12:58 ` Matthew Wilcox [this message]
2023-08-31 1:13 ` Xie XiuQi
2023-08-31 2:25 ` Matthew Wilcox
2023-08-31 2:57 ` Xie XiuQi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOyZ9FgRUOGPh3qm@casper.infradead.org \
--to=willy@infradead.org \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xiexiuqi@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox