From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C5B6C83F10 for ; Sun, 27 Aug 2023 13:09:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16923280001; Sun, 27 Aug 2023 09:09:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F3568E0001; Sun, 27 Aug 2023 09:09:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED77E280001; Sun, 27 Aug 2023 09:09:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DA7938E0001 for ; Sun, 27 Aug 2023 09:09:44 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AF20C120111 for ; Sun, 27 Aug 2023 13:09:44 +0000 (UTC) X-FDA: 81169916688.25.40CCD44 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 2953F1C001A for ; Sun, 27 Aug 2023 13:09:42 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf20.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693141783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JMj+gc9+ykWtPPSG9qr188ZvTMIRMHigdtCLnBTRgr4=; b=1wR/yPRObWD6aq4rMxRx+vLkFiKjBGwht6eqrvhpFAOJIS+2pGZo1f1x7Um49jY+12J3OR uk7cXNL/N2OaDzwGIdaLWHlaOLdyDeJB+rw9g3UZLPan94kt4a303hKcABAkUiv0KJyyD6 ghV4y/VbfRINcjUOwG6Si1IdTJqjyBw= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf20.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693141783; a=rsa-sha256; cv=none; b=m4S9TAE3noQNwW9RXazOSD4TxLNmAJh6Mej81p+V8+5oIosVh2QN25YnAm1nhlROdOgION MJrEzbr7qSu9Gs/Nt1vjvnkLxk4PBk3crH2K8DsfQvokCW/Wyy6z5ezZv2IARlROCtxfmD m5M16pmqxFqW6LfgUUB+1bjd3KCyDyo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5212E62280; Sun, 27 Aug 2023 13:09:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43E63C433C7; Sun, 27 Aug 2023 13:09:38 +0000 (UTC) Date: Sun, 27 Aug 2023 16:09:36 +0300 From: Catalin Marinas To: Florent Revest Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com, keescook@chromium.org, david@redhat.com, peterx@redhat.com, izbyshev@ispras.ru, broonie@kernel.org, szabolcs.nagy@arm.com, kpsingh@kernel.org, gthelen@google.com, toiwoton@gmail.com Subject: Re: [PATCH v3 2/5] kselftest: vm: Fix mdwe's mmap_FIXED test case Message-ID: References: <20230704153630.1591122-1-revest@chromium.org> <20230704153630.1591122-3-revest@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230704153630.1591122-3-revest@chromium.org> X-Rspamd-Queue-Id: 2953F1C001A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 6uxnnp4r8mrdx8cdbqx8ch87u1eg1htq X-HE-Tag: 1693141782-93906 X-HE-Meta: U2FsdGVkX18vizsMqZamOengV2/8Sf31LyKfcQ/CjK+w2+8L/5ZgOE8xJqjSDWn/wCPTx9DH3prCOR4uqnjzjM+1B4tXXaK6uqeCno4oTsTJY+EFBNA63yGkiOLrU7V2l8TI8Oa+uchcT21DX4+JT+/Z4bMqBWddHZRwfLG8H04FDrXV2hbjOED+vT2SIZowNnp72ywhSGvnwDkeKxDAwldr/3QigtngjFkofrZrEhTqd4sZw/q4OWhMTyTmDUa+fDAVp+ra7NgyhT2dp9Wm8/7BE7j/KAupdz23ruAI9oviZQNzx1Effw1JCoynaQ/a3apWloydRSG5GZ0ISYudxQKIAauvEhIPfEzeJdRGiPdWUs6GGK6aLhTJocKoheJyOGJ56Wm91CCqdAgJetcKefzuM/2nVJI7s1uzh/6EKSykG5dm86Vw+jeow+qz0OPjXtz5cseoEFfNyfYUe4UygFB043Qs5jmmQay9FZzYGNo0vTAD1MIf9A62DtaBsr6Ctnfx00z/4gKV96Ao6Ed8f+1s+TF3ZcFlGAM+uok2Jef0iq/7gvL9K+n3MZEK4gUVmWC9zb+9YEcZJH41+6IQDhzJF6vf2AEQaPqPu20cZVLGYtoZCE9LEVmkg1Un/evzhMv30rLZVHTooQBqWe5anqFBn02MfEO3IMlX3wTSTAwHqZDy5erCJPVRKoQMVEmPBUT7Ucop+6WxNbte+NYXZT01ioT7Ejv3IgzeqexeQNA78WjpDyjCrE9199XyT7z3Wsr8bdly/jwWynSBVGMWJJQkS1F0NsXHK0MVEd6/XCF5kUt/bD4lpGv9WjeYN5S/fJ7qSoXepVJwU+mDjhgpJIpenGnWQm7xsslXLKqRCRMLXWKCLMNy0XYv5msuN0Xs4enz7/6QXbwsW2F9hAaN85MtAEzahxkUppwS7GhNZzw+2COW13CrEq+yj6+EYuZE/0TjvUoVYC+JjkpB5mO QSreb5Ze OnfsN+RRinl7LHG9QzKfu26tMspf9G/CQAKB6Dgy3KBjDTW0CXSjV3FZB8q7HZXjLsrCwa0atGOUEUIqNuj4qlHKVzGAG0cOZMJD9/i/rdfBxT8Jb/xOh/uvOLUdmzqDoqh4OB7t38w9LovisTjIxlD2if6TPdJaVsMTx+UD99RbOdav5qCrTD/BXla4drIXhiwonqYsdAyLq6BMHzKp4cmoUQbgUTP2CQ0tBzsEYrPvfmgJdzgWRW8QfL1Jqj/TF1m2SSal/c04ZO4vlBM0V4yQJizJwbbM/A6G8uDUKaJ8zPwPpqlHnekeZeTtUWW76GiLwmJeLnnqrUUJtqsWQuplTBYqeqw2JY3urEaLxFhTclNWGeTPZK64RmvsTm7wgxvIE/p//l7vqb4JQ6WbhFexEb+5K3WbMNhO4bFvTPpYybYByhoUm5WPY4uJR47ADaGBMx5NL10qCmgir1TnGZxNMF4b2rs5hbBxbcik8/wIRdXPkYNUNhc7OU8NqauIBQEL6k0V6GITblmC8SAr6TjJGmAB4MKjbmLqfwdBYpghSDpXC5Tl3TUgpHnkgb3aH2MCLT/NU3GfB3/ey9mBz1Y409bSYcVRw0u4RHDdrumYfzcZRV/lhRa3GPQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 04, 2023 at 05:36:26PM +0200, Florent Revest wrote: > I checked with the original author, the mmap_FIXED test case wasn't > properly tested and fails. Currently, it maps two consecutive (non > overlapping) pages and expects the second mapping to be denied by MDWE > but these two pages have nothing to do with each other so MDWE is > actually out of the picture here. > > What the test actually intended to do was to remap a virtual address > using MAP_FIXED. However, this operation unmaps the existing mapping and > creates a new one so the va is backed by a new page and MDWE is again > out of the picture, all remappings should succeed. > > This patch keeps the test case to make it clear that this situation is > expected to work. > > Signed-off-by: Florent Revest > Reviewed-by: David Hildenbrand > Fixes: 4cf1fe34fd18 ("kselftest: vm: add tests for memory-deny-write-execute") Reviewed-by: Catalin Marinas