From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD6EEC83F10 for ; Sun, 27 Aug 2023 13:08:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B53C08E000D; Sun, 27 Aug 2023 09:08:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B04038E0001; Sun, 27 Aug 2023 09:08:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1AEA8E000D; Sun, 27 Aug 2023 09:08:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 94CA88E0001 for ; Sun, 27 Aug 2023 09:08:02 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6DD61401CA for ; Sun, 27 Aug 2023 13:08:02 +0000 (UTC) X-FDA: 81169912404.02.5F5FDB0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id D7F0AA0007 for ; Sun, 27 Aug 2023 13:07:59 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf15.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693141680; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RqsVP/m+Twrr122fRHdbqlhMIYGKbARLYmQ9FWiSn04=; b=6jwmKxSFrMJidOA6JhfyCsiOsO2LeuB0NLrjZQrH4e+RAx6UyAWsLEvPvHO642L7t6ktG+ uz6qGifcqhqtvB3S5mp0JPBzmssMiF1pyUVX+3txFAlKXTYgJD24gcPD0EXMsltHKln1/y NGNWnbgA5cQlGkH2Wz7+PNQsIWWPqXQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf15.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693141680; a=rsa-sha256; cv=none; b=BaFb5WUoO5IpX3s4MYIf0hXF2OAScesBh9aHRZs7cQj7KmuIpf/SHZpuDZ3ie/a8embbmi BiZ+ceZS/NAQDNQItPbnYTUUvjWvmk9vxj/gvr1zOkC/hFFY9LgZyMQgNM7uwdzdh4HuYm A0CmZlVdc0Z2vsOKItD/XYXBHdBw4vE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E58BA60FE8; Sun, 27 Aug 2023 13:07:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D53DC433C8; Sun, 27 Aug 2023 13:07:56 +0000 (UTC) Date: Sun, 27 Aug 2023 16:07:55 +0300 From: Catalin Marinas To: Waiman Long Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yisheng Xie Subject: Re: [PATCH] mm/kmemleak: Move up cond_resched() call in page scanning loop Message-ID: References: <20230825164947.1317981-1-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230825164947.1317981-1-longman@redhat.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D7F0AA0007 X-Stat-Signature: b1kyyjipwfapxku9jifh4iro8b7sefxc X-Rspam-User: X-HE-Tag: 1693141679-506391 X-HE-Meta: U2FsdGVkX19qXL1ySArLRBeant5mKdY54+AbaHL3ejzFiLTVMEJqqW3u9Si1gLZhdxNuSbjTcY6Y51I48iSMd3jINMO+qxmbmRFmE/BauoCSLbWc/T3rH2z2I3L9wmRpXE8IbUIiGeeCyeC4Z9oxBLxlbuljDoBDifPYGjEKEs0afkHP5DWvqf3ZRTPjoD9nIfSOF4JygEct558LxDCYEaEjWEo2Aae7gs1WnUS2sF6DskE/gk18HdS9GOohDLmaJKlnEfM6g7+i7NpUYX3wyKHf28y6yNE+QPtNfGC4IBThKneSNwJgN6dcW9Q66s/e/mIpfwUDAGPp0thlmYSSttvY5ZHGM820FIt0WJnntqdC655zOE1QIYTlcFnWNQlddh/DG+vknkc73p3LurAe//jF1NPpt+jXdJPViBY8hhwyu/51ik1NAF37fWMq/W6xUfn8kG+wQJl/L+yzF4OAFLVfBrDNTKIL19oAgadqezwcB8ZzCc7lWsr2JtfcvGna6dyR1x5lgJ/BCrSYYx6arB6lKx72FDAzdAdhHEt16Wm5rZTIjS8i7maXdZQQ69Eo6UOSbg/STBLTA9pvQ0LM/Z69NVV0Kz36gBOfS0J8MkTcI6bqqz083X7pZVHXCtFB3EfozW8uXIZcZYNMc0wK+r/TjHCBRT3H8byWWsu8zBGlaMt1JhdyFkKQGwIjpGj/XLoj0EgqDfxNgiJAEpRzuCE4sxWXOyjMf79BSj5kPQrExqaD+8KDQPuxgLFtJ2pJiTB25hvh8+GAMarC+D3dqdqGkvPq1gBH6HWZ7MYCx8cIGEzxs0/i6iaGb2prDCOYxvI8ZRCLyzn8GFnjuHZ04TykcQe/zadZ/wUDMbOaFmCZZMGw4xeD/JS2up63ixGMlOEdbCaBc6yrQwbSWyx0C13EUS0coEYvQ6CloGTFloW2E4XyE+tca+N41Lmfq3VWM/LMcOn+BMu6JKo+nUf gJ6ifUmf dHud4i+gIsEa6VjM++LQMpUnUh6rYAuNYMDoxD1m7hkf5BROMev/I2Ikyr56jnWca1ihyo9w8Yqkj//23BAYFex/h/1V9qgAM759k5wpMckgqkD8/VKdQ+0Pq/TctoWT/KLnPlwCVGWBDsurLaE/tULSBNXYBiiNO9ANXX84J/C1A7zI5Safw0NxybsEA9RovrY4Jr0EdUYb+dhTH65z9uzdnwZkU2iLEyg7aEPj0x2In2qpAJ6Ke1ok/DDDE+fbzcfV2w9yAvAGW+d2sDmESF7wJ48XmVGpXUSZPs9Nv8fqXhhLYInpFjWVPYggyUV+eveEB7a3rZ3L/UUO2hrch72DZTKZiCNTu348CeD83u3argETWOiyBM38wKrnLTbO90TSqqTJZctN2P1RMczNTFO5MfkPhw9uspIo3tgnCNywNG+ZKDouhsqlErFql4g0c/MRoHMyYxLKl6UhveQcgwehZ+QrSoSf75le+p2J10CO3rzcDOLlCXjHo2ZXt4BFHGuCyrAOz8h0Pqi37TqXll2ZiISkXivXLwN64 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 25, 2023 at 12:49:47PM -0400, Waiman Long wrote: > Commit bde5f6bc68db ("kmemleak: add scheduling point to kmemleak_scan()") > added a cond_resched() call to the struct page scanning loop to prevent > soft lockup from happening. However, soft lockup can still happen in > that loop in some corner cases when the pages that satisfy the "!(pfn & > 63)" check are skipped for some reasons. > > Fix this corner case by moving up the cond_resched() check so that it > will be called every 64 pages unconditionally. > > Fixes: bde5f6bc68db ("kmemleak: add scheduling point to kmemleak_scan()") > Signed-off-by: Waiman Long Acked-by: Catalin Marinas