From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43134C3DA66 for ; Fri, 25 Aug 2023 21:59:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3879680016; Fri, 25 Aug 2023 17:59:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC1D868000E; Fri, 25 Aug 2023 17:59:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93C9E680016; Fri, 25 Aug 2023 17:59:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7E38968000E for ; Fri, 25 Aug 2023 17:59:49 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 538911A07C2 for ; Fri, 25 Aug 2023 21:59:49 +0000 (UTC) X-FDA: 81163994898.13.20782E5 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf24.hostedemail.com (Postfix) with ESMTP id F2B99180023 for ; Fri, 25 Aug 2023 21:59:46 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=fromorbit-com.20221208.gappssmtp.com header.s=20221208 header.b=41e5WqQO; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf24.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693000787; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wCmT1oESbAYhZeNNKJ5ShtRN4csCjH3Kne0S41EAnjg=; b=Adg/Io8ozshXwrzWLr4+hEGXfF9mKd9PlXpW7ilkcqwEDf/1yiw1Fj0THJcYCtOEWqSUFG VqMq8kKJZbJDJojekPp2akIFtKJzRwD84JvqRZcKo+YaoBfK88TcIa6rhja8LbaNICsdmu y0QbvLjqv/3gYi5rn9qXkPHcSJbcDDw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=fromorbit-com.20221208.gappssmtp.com header.s=20221208 header.b=41e5WqQO; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf24.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693000787; a=rsa-sha256; cv=none; b=W3PO2/vvxSdOiTS0Pc3rRp5HiR9eoX1t1YbIQvQntrroDyfOumRvrGaAR0gsk0kkDxZ/7d wmdNvrveZt6i5rvRfXZR8AoIda/VFyH9qlxwaEvmpjlhudoGPnvjha3cspAEgRY0tty5eP fUJFUO4lKt0Vvpo+hOyr/6ZS6JkNqFU= Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-68a402c1fcdso1086719b3a.1 for ; Fri, 25 Aug 2023 14:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1693000786; x=1693605586; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wCmT1oESbAYhZeNNKJ5ShtRN4csCjH3Kne0S41EAnjg=; b=41e5WqQODP0hmu8CXJSYnJoxP9CYCTQIjvtSx0suLjuCd2LQoihd/jLrKiko4xwooZ 7dYHeAbwy4v/acegR7zM2t87koKR6b9HdwUQM9+1khEZHSlP6Ay9Gyi1BnTTJyQ+N1sf Tihv+CPf4TPS3j/ZySi0TL4gDqhyuMZ+nJxTaDnexRh6Pcmjy8aRHLfP/t/1vg9xEN/C 0OJKzvJcUqwLuYg4eu+OPeBIRa0lo/YObVmgzaCCijZ7OHy87LLvHUMM6er4JE4Dhtu4 AWYpsvb+nGYnjp1AziAY3+XfPWUVf+GXDgs/Cvrt+UTpnf3nupIw3K4PynKsZ49o3GsI BY9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693000786; x=1693605586; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wCmT1oESbAYhZeNNKJ5ShtRN4csCjH3Kne0S41EAnjg=; b=IU0cki4ktNP+2/lczCpJ5kHAVAWb275NAkBfp5JcLohVeO0pDlILzqfHB1KhxQpe16 YU/u6Zp8JkAS9wT+TxiXcp29zjrm4anMHwBtsqiYoul3qJALHybqWlqDzviJL5zCTO7p TZpc2immXliUmt7rFEkggp/96qbIXP+s3mFZDxydSKVdyn3BgMGHVwBaWEVsLRYMZs5j T3UvYcVt4HgXIw7kUjenigxoFLjF6lYHQz3X5WL1uFeDv1LXYWHVxb1f6WfLCV3yJV4i leGtvSGdIvOZ7R03obocPyrvPIn/gMUeXAOsEZ7hd6tHzPfhHVhitsv6vWsXfo9EIP+7 2cUQ== X-Gm-Message-State: AOJu0YxcB9egutKk06Wn/hEFJYyYkNz3gGUrypgSvuYHUsfvsBINvzMI uiSS3PAEwtfEAwBEV8OQSsAIvQ== X-Google-Smtp-Source: AGHT+IH1qPsbAkUY/ApYOINMHsRtAsDWZuWyGwI872JdnDKqNbs04KgeM02oT1drFck2zagaT8PEnw== X-Received: by 2002:a05:6a00:cc2:b0:68b:a137:3739 with SMTP id b2-20020a056a000cc200b0068ba1373739mr11002510pfv.4.1693000786153; Fri, 25 Aug 2023 14:59:46 -0700 (PDT) Received: from dread.disaster.area (pa49-195-66-88.pa.nsw.optusnet.com.au. [49.195.66.88]) by smtp.gmail.com with ESMTPSA id g2-20020aa78742000000b0068be98f1228sm2025436pfo.57.2023.08.25.14.59.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Aug 2023 14:59:45 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qZeqF-006VO2-18; Sat, 26 Aug 2023 07:59:43 +1000 Date: Sat, 26 Aug 2023 07:59:43 +1000 From: Dave Chinner To: Hao Xu Cc: io-uring@vger.kernel.org, Jens Axboe , Dominique Martinet , Pavel Begunkov , Christian Brauner , Alexander Viro , Stefan Roesch , Clay Harris , "Darrick J . Wong" , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-cachefs@redhat.com, ecryptfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-unionfs@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, codalist@coda.cs.cmu.edu, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, linux-nilfs@vger.kernel.org, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, Wanpeng Li Subject: Re: [PATCH 28/29] xfs: support nowait semantics for xc_ctx_lock in xlog_cil_commit() Message-ID: References: <20230825135431.1317785-1-hao.xu@linux.dev> <20230825135431.1317785-29-hao.xu@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230825135431.1317785-29-hao.xu@linux.dev> X-Rspamd-Queue-Id: F2B99180023 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: wxmi3g97x8ag3y8axa7do4qnj31uxrhs X-HE-Tag: 1693000786-53308 X-HE-Meta: U2FsdGVkX18bc0Ss0z9WuqeVOGtdPUf0IrbyB4gjFlDCzquDgYsclnugbSYdK5Y8o5AVSwEbVb1xbrgw1bt3B8LgqF0wi4zcbMLfR0HNntJgOvflOiZlkPxAJfStkLuErqdE5j2nRzAPZBE1B2Vh5P1F8XpMSLclyaKCNfRB1Eb7QX28BbTIcZXYOomXnmGARuZKRXOGVuP+ibBiaw7kGA8VvBPCX2E45NbufrCAo70vrS2uyxp8F+boxVpwU4h58Rj7o6b1vtCIw0RVDIwuFjr1ESoSyh+6APaQaVWuwA0Lq6fJ3T/k/MKcV37kUVk5aQRQC+gTB48uidM2YQd/6ZFxCAIKms5hgij7owMn3Y5LmKVoK/3vJFsUEpXPGzN1WEQMbgMueCrtisRZ8yFMddztFVmIDEtBBegWNvHBajCLXb+nSl+tMhmFlBsmN0ta2HaQF7CF1PVIgCE5sWObV2x75Hx32v64oPA2X5JuaBWDBMNblT8/dfjp8oDFWqzXaqLHI36hbeM4TjkOmGFfep1vUUgZ1nPSehzFEJUuXO7X1CYMGEfegOTeXcxIz3/9tSFUCH6GOj4Tn4GYvzWXTOu6s6/P0N6rFXhaLygCftmGMB+ITxeXu2r16jQoDHpS2EVHzxuGxVaE03HFtsa3eS9xd2b8CnReMbegLLvVpuq6sEHleTUWDS8qpfEY6FjjwDLcAkwFyCMCEAO8REoayUmQ6F53lBbyfW5qstCWyD6kh3U16Va7oDR0/E++m5hSqBotUIebs5EBvhHVfBB+i1O994hQrq8i4YIYFXymYGZg86LS7KJuuK7cRp4YPGjNEVy1AJu2d7QTlh6bfUoH7SjJKeMcppNtBUkLEE/lf1COxtMnT3n/LjPx2V+eiOh1l2htr/GYU3+lQcvbqyDC4kkBU6EIllhYiZOdvWqRftyC1ZTua0tkXAGvWSVkgUk3+LyuuLkXPPLQw0BA0Q6 YPdSWuy8 WPBMXqB1KRNFBp4AZQpO3ANAQUlyoZuwiEmvBAzydHslqMoa7Mc4+1R9qShVnjKUvfABzyh52OI9BZkA4NZIDiBifHQg/hXQNKMEpamN7FEL0YOzfMLPDYCoeG09caYvp4XRPk1t+wnEdFxWpncgGdgUUPUs1vgI6912dx2wJTSvRY0jR+fbNaZYKpAuyAZoGWGZ6u6VT8Da8Tyzp6DceMPbEZi1hJqa8RJNN53+p2lgHxxlIGFy+VhiO5+pTHvg3zirU+EhPXzPQb+vKpHhDoypuIyvhzHuw3mc//ariEPf1JzEF6cq0QQj+jC0bhE5Mz8a+/HYqdjHLLYDx+45VFdy0yQ35BeYsFV4W+TN7zgv+bljeBrS+2d0CPmfWCgIwMbuT5tmCz45j116rWpkPQx3BS+4txcFp4mNfbjwg6o3BN36FkH+mmqOof8NzGdQ2GLsLRE8nUZa5m+qIJojiHjDw1SlthubYEaankJWBUgbXcvI6AvyFE4cB7MEroLKyK5tDRaPIbGa5Fria3ppwgm6IjB3TeXpeFA+PlBQVwz/+9Nphv214MViDfMSdNOggb2r8D1Ah+F508dNkfnYsdW1eUVElNl8uPKHtZDpgx7m7LIbQ7DYwlzP/pw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001988, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 25, 2023 at 09:54:30PM +0800, Hao Xu wrote: > From: Hao Xu > > Apply trylock logic for xc_ctx_lock in xlog_cil_commit() in nowait > case and error out -EAGAIN for xlog_cil_commit(). Again, fundamentally broken. Any error from xlog_cil_commit() will result in a filesystem shutdown as we cannot back out from failure with dirty log items gracefully at this point. -Dave. -- Dave Chinner david@fromorbit.com