From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45AF6C7EE2C for ; Fri, 25 Aug 2023 21:58:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4950680015; Fri, 25 Aug 2023 17:58:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFB2568000E; Fri, 25 Aug 2023 17:58:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF160680015; Fri, 25 Aug 2023 17:58:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9ED7568000E for ; Fri, 25 Aug 2023 17:58:20 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6BA21120805 for ; Fri, 25 Aug 2023 21:58:20 +0000 (UTC) X-FDA: 81163991160.06.76FF91E Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf06.hostedemail.com (Postfix) with ESMTP id 7D8E5180002 for ; Fri, 25 Aug 2023 21:58:18 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=fromorbit-com.20221208.gappssmtp.com header.s=20221208 header.b=1Wwb4WWQ; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf06.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693000698; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KYhyzbAkZA6I0JpkJP7NgCytRvclFoiu9vcGiedxJnM=; b=opZIkt4KnvKtDnim/l+lSgTjND0ylKRENdTlxOHGdn2Ux7/o0tu6jGQDObf9mKOjoYGtEV TewR6E5+Au3wFCXTW4jNNd9EJtWTKffVYJfwOkxGDFra9qpSgPHjJYCViYll6RVSjFzyHH JGesrAxeSuH0S7RyczOh1lYCHkNpOvc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=fromorbit-com.20221208.gappssmtp.com header.s=20221208 header.b=1Wwb4WWQ; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf06.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693000698; a=rsa-sha256; cv=none; b=wOQm7Krxbzye7RBIlDnUnkEGLi0K+MQymXqb1NbCz0L54BwX0lV90AtjW3/+cpPPoPFxIk YI0or8JiPMlXdZ9Rs4tQTyZZ/hvxSGZIRRahL556GXaS2mHs1vH2aYDxljCyU17a7nTtH9 KLpZjzZBCzYV+TlbkkjJs1gqYd7i0Bk= Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1c0bae4da38so10226465ad.0 for ; Fri, 25 Aug 2023 14:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1693000697; x=1693605497; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KYhyzbAkZA6I0JpkJP7NgCytRvclFoiu9vcGiedxJnM=; b=1Wwb4WWQO1nzo+wP8Ym9u7PtaCAogAhPk/wJ6+iajebaGRGH1bh3YUovAHvK7YwsrG Altfd+hiFr2QAEewrBlBdQUf12ReGBxFecEF9z4qSWtf7NHhqX4ZJ0Es/Ox5pMQG5qYE ON1YhPXjTA4vUUqu5PDmVynp4FbeJjsl/2wr+ltmHseTIEjBJUjWiwUMJkDEEGYrxBj+ +r63aMykB0LkDPawaZCYLBT8qIm6t5FSY8zRlinkDxCVNHc4Plq432NNO6//LCu4oULp 7N1QnclU4jSGyRit69XjN/5+++KdNQGagaG79+E8tysnI3S2OzcORxOrDNy4lC1Nj2mx DSYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693000697; x=1693605497; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KYhyzbAkZA6I0JpkJP7NgCytRvclFoiu9vcGiedxJnM=; b=H02GjXo1NZDgtCgwMoBje+2nQz1ffm9GECeLL+m6rltY7YF91N4vjNjcv4CAYnBlZ2 4CFLSap+34I53UCvm1Jx1fnbI//smaVHRHkVUX/2y1tXiVgAT9mGC6NhbqI3e+wcIYFf uiU8Z36BWci7c4Zk8ofnRGYmUEog6mkCedqJVw3RqNe29FFEtMLsBnz2szjW7X1Sgm5E GbuIoJiQbzYonPTeRkB5Y4dNbVAhsHqvOK6Zpw22UtKOaWt6Jv1lfHs8QcLhEdpK33Sg BA1WND0bpmvbrwQioMZYcJK2CydIu1WTtzHJ5AZgPcb/WwvvY7rlD1Z4Q0KbEBHkDZAZ XAzg== X-Gm-Message-State: AOJu0Yz9+1qrcuZSev+vHmMGQr9srMzrQ2YTmgKHyJr5WkVZvtNzRvwS cbDKuWA4seMkONsh0cBLMrPz1w== X-Google-Smtp-Source: AGHT+IGbNBRmb5i9MT6K586yDhJt+XUD4xbkK8zWzYl+0zg/QCNqIJVK22pGEJPGpFxCH5bzJj3AjQ== X-Received: by 2002:a17:902:c454:b0:1b8:6984:f5e5 with SMTP id m20-20020a170902c45400b001b86984f5e5mr20508009plm.12.1693000697391; Fri, 25 Aug 2023 14:58:17 -0700 (PDT) Received: from dread.disaster.area (pa49-195-66-88.pa.nsw.optusnet.com.au. [49.195.66.88]) by smtp.gmail.com with ESMTPSA id 13-20020a170902c24d00b0019ee045a2b3sm2241969plg.308.2023.08.25.14.58.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Aug 2023 14:58:16 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qZeoo-006VLc-08; Sat, 26 Aug 2023 07:58:14 +1000 Date: Sat, 26 Aug 2023 07:58:14 +1000 From: Dave Chinner To: Hao Xu Cc: io-uring@vger.kernel.org, Jens Axboe , Dominique Martinet , Pavel Begunkov , Christian Brauner , Alexander Viro , Stefan Roesch , Clay Harris , "Darrick J . Wong" , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-cachefs@redhat.com, ecryptfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-unionfs@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, codalist@coda.cs.cmu.edu, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, linux-nilfs@vger.kernel.org, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, Wanpeng Li Subject: Re: [PATCH 26/29] xfs: return -EAGAIN when nowait meets sync in transaction commit Message-ID: References: <20230825135431.1317785-1-hao.xu@linux.dev> <20230825135431.1317785-27-hao.xu@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230825135431.1317785-27-hao.xu@linux.dev> X-Rspam-User: X-Stat-Signature: z56otp1yso4ct5q9ns8uymkfdqug7ej8 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7D8E5180002 X-HE-Tag: 1693000698-967006 X-HE-Meta: U2FsdGVkX1/C7l/rhnafo24LZG1QUQb1XcFnnS7SXcgRNH6ntCXgmiNIyKnl7db9LMeGc/Cmlyat8nBNGRwnwuf9J9JiG2ZtKQte+6yf7gJ2lqaztdIrBNHcADi1+cs6US6R7vZL1CtXXQ+eP/ATz9k3E1hL9/g0nFnK2J6lavowkHtu2OnleqTxaqXbJxPkyneQDj/JV47omZcEHGaXOGjsf6Ir5De3Hkzqyq0h1Fjh6ZP4jgY0RTbguQ6ZNYStA3aRcz79MwBPEOcHNXXv5XPd6lSWtIGLlbkiC+mx2nezErbmDaSgTaQc+ANpYPrnFtuBz3A8TWPO7LLN5of9mefWy3+Vwzg5828rd7y59upxx7Yx8/UwtcwOMnu8H4/CgN3GIoFQ1oKvwyslQii+j8BbO74HGC2hFj4FR9u6/K/eIbkXN17OLALbukg9ula544cYZfKtnqewuXPDnzlLolHQSfLw/l7z6rzewa54a/7kH2kHQYj214ODLBsV4ge25jJ3SUdlAsuEWE1XcPl0ty1dCdOGaT/ZrWzjnC8Q6i855qUx5ZyXIR97nX6FYr5r4VsJ+bRTRxbOjPDoB5jk+XhvfbYGpWDTxq/P/hmuhK0peVlgs1DceG/vn9ZqsXdo3qDk8zElVF2pWU7l8ntAj19ZLaomn0JWfavBFo2tSovunm7/rOrPOUK69wTOx8NRHh49JfcKG0fCok7hUvlpwKeU/CSvOGs9slWYM9blY6BT57n5raF6kuoIb4HC0hyn4vbyqDwFeoCsKpARL+eSzJEJ7wfB9vMgQj7XRAC3a0luSHq2AKhOwWEA51HAlDgk2hUkrrjrPAgCPwqMUS3dHC+hc7DVD2gJiQXSyLE22DQNXxtxbcaJTclw305QEHT6gOhbJqbVFaQshfdze4JomuCeQgihvHgnDbjxFi7nko4nb6d1+s6sh+nVyNx1bSJlbQGKa3Z7esHW82qy7G2 fKSBsYSM UPSqQ5UaK+424w6Z16tHP9f4lsMHXzfn70DnkA12uJJBJXGXY/d+DuPCz/oefAGh4jQH8WbtTl6bZoMM/Td+MA9jeb5UNzpOc619Jhpud9ZAOtBHp9hmsLlQdT1Awap4di0AO4lnWoUpbv6e7YfPJ2+gbpxlM6IcmmmQIAlUPPic+GPwmECNy3mS6GzXpzmRkyyQLOdq1zSWhDk+v7A961qXr5XxtL25mjskVwbWxp4IiY3CCxxnPB132znLUzNRQIUaS+p3cRfsVdYE4GWFjLGRGXQ9MnzXSImifRj4G3zXvP30cvZ+vV2qcy2xiGMlQVv2C2A5oeCQI7g/UqbtMWfLx3kUxtxSpabuEeQI/VLvbk3cTYbGX/zPURLER5v4nrRqc6hYVCw1A+0UHXngCp601iuW0MBOAw85JXFVs3cUpaBCvFtP/nF6t4lY/Cq4vovgJC3o7FMVyz5bKxbOUOR0/7Yke0BkLzgU8aRf++KrvsvbFSpzo3QxMTy0YnEswJ/Fa/m01Pnv2wOF4hcUMNWHgmO4swye1mcscYmAXSFeAuoXOJjyem57WsGWQQC9v1xT0rtVRK5TpD38= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 25, 2023 at 09:54:28PM +0800, Hao Xu wrote: > From: Hao Xu > > if the log transaction is a sync one, let's fail the nowait try and > return -EAGAIN directly since sync transaction means blocked by IO. > > Signed-off-by: Hao Xu > --- > fs/xfs/xfs_trans.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c > index 7988b4c7f36e..f1f84a3dd456 100644 > --- a/fs/xfs/xfs_trans.c > +++ b/fs/xfs/xfs_trans.c > @@ -968,12 +968,24 @@ __xfs_trans_commit( > xfs_csn_t commit_seq = 0; > int error = 0; > int sync = tp->t_flags & XFS_TRANS_SYNC; > + bool nowait = tp->t_flags & XFS_TRANS_NOWAIT; > + bool perm_log = tp->t_flags & XFS_TRANS_PERM_LOG_RES; > > trace_xfs_trans_commit(tp, _RET_IP_); > > + if (nowait && sync) { > + /* > + * Currently nowait is only from xfs_vn_update_time() > + * so perm_log is always false here, but let's make > + * code general. > + */ > + if (perm_log) > + xfs_defer_cancel(tp); > + goto out_unreserve; > + } This is fundamentally broken. We cannot about a transaction commit with dirty items at this point with shutting down the filesystem. This points to XFS_TRANS_NOWAIT being completely broken, too, because we don't call xfs_trans_set_sync() until just before we commit the transaction. At this point, it is -too late- for nowait+sync to be handled gracefully, and it will *always* go bad. IOWs, the whole transaction "nowait" semantics as designed and implemented is not a workable solution.... -Dave. -- Dave Chinner david@fromorbit.com