From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5F7DC71133 for ; Fri, 25 Aug 2023 14:21:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A52A68000B; Fri, 25 Aug 2023 10:21:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42C89680001; Fri, 25 Aug 2023 10:21:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CD3D68000B; Fri, 25 Aug 2023 10:21:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1A448680001 for ; Fri, 25 Aug 2023 10:21:21 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DBD651206D6 for ; Fri, 25 Aug 2023 14:21:20 +0000 (UTC) X-FDA: 81162839520.18.F0D22F7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id 78FD314001B for ; Fri, 25 Aug 2023 14:21:16 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oBoPRF9u; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692973278; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rIMc/jDCj9ILMqoJd0dO659w/9cB73A1MIGl7MCNQc0=; b=Oth+jAxkVczJ4ekOVlCiBRtQRXu3fTuWLm5/CNvQeX8YiCnNYdm9sL30ymw26lpXDJ6gYs 60dnfLbFVG+ZLgxn4lk0SFzy9G0duyoqsAJcqhvxaCkXv20AbI6YgS0KeCLTLrwiUC/Vrj wQRMmGVVh0nZsCKHRQqmeq25QbRu37A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692973278; a=rsa-sha256; cv=none; b=8lgnymBrQThk8JhFMf+AS25khYjYwtAyKc3bPUy+rrYsFD/ztQmaS0+hfK03JqVmZY4+Sn DIJ/rHWGQFJMG7tGhykXimYQWC9BIpuhCVCfpBX7ljtWOl04DsRmW2sHqhdpz2iahdYjA+ M9xCd76UQOoLg4zo8U4TWkipTCZ8+XU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oBoPRF9u; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rIMc/jDCj9ILMqoJd0dO659w/9cB73A1MIGl7MCNQc0=; b=oBoPRF9uQlcnzO+kvA9HXiHIxh 1BCZOYk+GNL3b9Hbl9e0kK321R7GUMuXBq5CnzZVygX8jax4dLYLnGd1XSzW1m9qVXov6cTXOpVyv sv5l1EBw3uu95Jxon5Sw3wlu1qTTRFkBQCTr+N8L/Prb1jdIi5jstgZjfRsnuOwWr9LDfkxjeCY5c UoI4nSwH2jPxj2QMMHZp0Wkb5xy7QvRuP3ObBs4CYLKVGqr6YBri4brVlX/zJEjbKcNGc0kRvuWzw 6Da7DA+BObM8TzfQI+r1SxtKCOrEiJNsg27vpqxgEagx4gi10g2HUFqfKuMQw4f6GgzpXJkYlNle8 RUhWro7w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qZXfd-00HYsg-Qa; Fri, 25 Aug 2023 14:20:17 +0000 Date: Fri, 25 Aug 2023 15:20:17 +0100 From: Matthew Wilcox To: Hao Xu Cc: io-uring@vger.kernel.org, Jens Axboe , Dominique Martinet , Pavel Begunkov , Christian Brauner , Alexander Viro , Stefan Roesch , Clay Harris , Dave Chinner , "Darrick J . Wong" , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-cachefs@redhat.com, ecryptfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-unionfs@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, codalist@coda.cs.cmu.edu, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, linux-nilfs@vger.kernel.org, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, Wanpeng Li Subject: Re: [PATCH 12/29] xfs: enforce GFP_NOIO implicitly during nowait time update Message-ID: References: <20230825135431.1317785-1-hao.xu@linux.dev> <20230825135431.1317785-13-hao.xu@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230825135431.1317785-13-hao.xu@linux.dev> X-Rspamd-Queue-Id: 78FD314001B X-Rspam-User: X-Stat-Signature: x3c7srbarn8f5b8gf5fkb3bqc5scz6ti X-Rspamd-Server: rspam03 X-HE-Tag: 1692973276-721449 X-HE-Meta: U2FsdGVkX1/QwBamHKignDye8guixGDflTE38C2HpifGE2nYDithEY483IfZsHazcZuFZV25vUseTIGWcGadkMeqeAWfuTbS0qLP45VLO58cRgytayujlPYcdhJP/Ylt1rB2bFs7fdUqa/0G+bK0YPn4BUFtdHCSsTByUVf9GS6Nfbe9w/bklOLFfzLpWLmhUnydp652zpIH0N7g5nN4f5UnR9VyiGowg/VS6EfMPyAde+nLd9nMYv9KfD1VZe7itJkkjcyfPmwDPPNYOu3X8+H99VF2uO3a+jorul+1hKzQyaZvhW4dlLF56q4GNu97HKhc3nem8m2sLyxvqmNpI3tB7AN6qOxD+MHgai3aNwuW35ygvPQlU8dIJUchpv9eBSES07FQo07ve0TwGaS/hJoPhMhsJKBYiz3YMMMmRzS8Qxm56gvFTvzeoxtSWykfciU3enHXGsiGXGzU0s/2FjS44AJaU2GYPWHd3A4gNCjyq6+sYzn53yj6QBqr+WKgWwxmTVP6z37ByMdHM4T2SILsJ9r6cFpxRmgaR2oH/6Wf7nBdH1LbVZjq8dtDPeKxQhqNJBIpYf9iQSmDLvkXdeVhaA7SODXJYQbf6/MDic57Q1uVmjtcgOSVjwU8AHEzkFys7kD4knkM3bN6MI8RZ0ru2sHtTPGG59QFXBok/DU75kPkoW1eQ0mQGOdQsuuCararl/Bxalmuyu87Gv+oM8CAn1biGxtMaX9jafi0sj27q/3xOyBZ8gGvlzBGkegXlSrJ6Vk0CNjd3CAN5obRa0qjxfFD91h0p0DUqcZMCrfTldFOwaJWfWn7bg2ZIUEc9s02ZJkK8IFG5SDB3Yw3/ywvF5SJFVNd+5qyBHrFG8ZdlbP/UGrnWphJrTb2z3yQS1J358OBEqHrabc35h34GD0t18HRhOMKWP7W/rmiUQW3jI0nk9usnU7UaIJu3BTLlWTZZIyhBBrU0psdvVw 83EqDhQ9 dOzsCx45DS7c28ipblfjdOKQ8dyLka4ztYxzSjwAzdoaQ8yr+EkLawLgYRnFUYbyUboM2a6bCdTUbjs7OoLqODn/f3gevabC1Y8gqzkU1LaOoraGqji9udGKhdvgNJNKCSZ5yIlam7AsRs7iGIi7WBK5EdSy7QfGvqKPYhwSnYJ9Er//cXNL8f3EfMLExpvgymb/+up+Ilj2qjepUNFneCSauwhpEiDa07QWtwoJwTRyUdkows3oMaQW4KQs2Zinu/8/YXjAwRDB52EQynjqp1Cg6qVAlA44fsdgG4fnqFjW2+BsdZFK8bsnFznmNPUjBx6I06oYc8dxAtB/+3p9pFueLRWAW/BiX8zJZEumFYZD4ZxGG3wCH0cKUdg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 25, 2023 at 09:54:14PM +0800, Hao Xu wrote: > +++ b/fs/xfs/xfs_iops.c > @@ -1037,6 +1037,8 @@ xfs_vn_update_time( > int log_flags = XFS_ILOG_TIMESTAMP; > struct xfs_trans *tp; > int error; > + int old_pflags; > + bool nowait = flags & S_NOWAIT; > > trace_xfs_update_time(ip); > > @@ -1049,13 +1051,18 @@ xfs_vn_update_time( > log_flags |= XFS_ILOG_CORE; > } > > + if (nowait) > + old_pflags = memalloc_noio_save(); > + > error = xfs_trans_alloc(mp, &M_RES(mp)->tr_fsyncts, 0, 0, 0, &tp); This is an abuse of the memalloc_noio_save() interface. You shouldn't be setting it around individual allocations; it's the part of the kernel which decides "I can't afford to do I/O" that should be setting it. In this case, it should probably be set by io_uring, way way way up at the top. But Jens didn't actually answer my question about that: https://lore.kernel.org/all/ZMhZh2EYPMH1wIXX@casper.infradead.org/