From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25681C7EE2C for ; Fri, 25 Aug 2023 14:10:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9301D68000A; Fri, 25 Aug 2023 10:10:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E023680001; Fri, 25 Aug 2023 10:10:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7822668000A; Fri, 25 Aug 2023 10:10:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 64EB5680001 for ; Fri, 25 Aug 2023 10:10:48 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 74EB4B275F for ; Fri, 25 Aug 2023 14:10:39 +0000 (UTC) X-FDA: 81162812598.23.907E95F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id E27FF4003C for ; Fri, 25 Aug 2023 14:10:30 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=sXnwInRu; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692972631; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EU4c+QvmUrzx56YT6HV/cCIR2Pjqx+IXpn7k2GV7Q+c=; b=pQzCykZaQcUHq+a0EmAUpjRwQhKq5X6EZV32fcxY9//I+VnZvmyu2mhH9tNsuH2Q7ITm4x W+biMsemQ13Lfz6aBluMffqz8s032E5FbifAG6ZfOv+ljZJUtI0dnEROPr5ewH3lTeFEjE Ud8fcWV5a/jYqIY72SLQ7EUdDDENXpw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692972631; a=rsa-sha256; cv=none; b=MW8lUEVGgQaTZm9vg+YPw5mk7IGtwJFbPhoG8ty3oxRbWtKresiiAxX8TFDGMXRnB4aKqZ YnDwDLRLxie+F3sZo5JR/HId/JlIEs5CyRFio8onbiv3fAtk2aQdzblvm92YpOKu6V6zpv 8D2D7oa0gBawH7YmSAUv0eJq67s2x+A= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=sXnwInRu; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EU4c+QvmUrzx56YT6HV/cCIR2Pjqx+IXpn7k2GV7Q+c=; b=sXnwInRucx8CcJKwrlTfZ031er LEY7y8jsL9Hib5zZnhCnKvqEBOaupx8CYhaoOaWj/VYF41GGvSOMwZwP7gnqnUjyUY5nybhBoSrxT cix5TlGhcoCY3jjdx5/eXfy7PSYCUWLL6z2ZL1LRTqjCJLf619sI6Mfr/SSckV734m8GK683QEHy+ aF/xKkJIUvAhE/VXofyvjMKZ4LYU11OPTfozENym+/mg5hUGQWADpmiwU301hOx3e6IcpV8ta4h3y 7U3MMVZnd623qdMqd3D0FkVtdSaK+AiLgU+Qa7F9jQSRFB1EUCUT2iSVWxr49S72DAzkgcEx6R3cM 2mytwuWw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qZXUl-00HWBm-5H; Fri, 25 Aug 2023 14:09:03 +0000 Date: Fri, 25 Aug 2023 15:09:03 +0100 From: Matthew Wilcox To: Hao Xu Cc: io-uring@vger.kernel.org, Jens Axboe , Dominique Martinet , Pavel Begunkov , Christian Brauner , Alexander Viro , Stefan Roesch , Clay Harris , Dave Chinner , "Darrick J . Wong" , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-cachefs@redhat.com, ecryptfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-unionfs@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, codalist@coda.cs.cmu.edu, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, linux-nilfs@vger.kernel.org, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, Wanpeng Li Subject: Re: [PATCH 22/29] xfs: comment page allocation for nowait case in xfs_buf_find_insert() Message-ID: References: <20230825135431.1317785-1-hao.xu@linux.dev> <20230825135431.1317785-23-hao.xu@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230825135431.1317785-23-hao.xu@linux.dev> X-Rspamd-Queue-Id: E27FF4003C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: gydxustnkzw1ijjf6ffcryrzbo7zjqgx X-HE-Tag: 1692972630-23715 X-HE-Meta: U2FsdGVkX19UselRjIUCn1zlq/1XjVEmplvztLtmStyUB9v5lz134SZNT+YqlVsBF3jwLrW6G6uMFRz2g/I84/T/W6lPODQx2pncHs5N+imqIfFEtskgZSMg+M0L8n0BtMlvXUpNzG/dENzRto/EIC+4a6KbdDbPDCsLw5uP1CI9C5kh+tM0aQQwZ2sv5RPiVAQSEXjq4ZfMjrPDxB8RP0/MOWJkhMqo2qZfnVLTrIgU+Tmp5JBmNf6+EP84JHt3OCQ07OKbxrHRk5x6CErwdvhOpAXBAMSRiVnhEEKrVTAdUlRZJ3rx3/N7WoqnEGj7yjUr5m3t/Gd+I0YIIKQbFmhKs1jlqLjY6gRteHmXSLxPfdM1UWV4lp005kk7p4nE0ghKlXOrSdRnJb9fhf7cfP2klvCH8Iflp1la0o6MYneEZFXXjBb3kIi8zVe9s8k4ucIdZISlzHEhOeBHz/i16FoXvBag0ZY5tlHiXHMKeJH0OLs910ByLAhD0eFst9gJK8JBKral4Px8d789Sq+ibtJptI6MJhxWD6CqUgLEoN1Dpj8lOXxMZDRdLjexHl+XlBQRZP440k+f8H9imzAZdKZLxvBbKHrAscfhtzWG/yRjj9dtMSN8RKlsOMNwCxZX5nKZfcB9QB7DVktXqRuujEBOsXMA6BhgggpIIya70xN7zPbujsIL0zuY2+afcZ6Bn4jgp5WaiYPd6VDnwdUIYMvZFUor8QqYfVzREoWiFIpnf+M07ebmAP8aV/RS6Jq2vyFXZU49qvN3neuh5QjItkSSvDOhjUNAw9smRtD8s2rjDfO0VPNtWPRzBVWbWoLOom3t+K0subbJoZ9sVF1a3THrWOmPf8Er+QhgRTwZ1w+bnc0EgQKnttZ7ukmv41Sle7XIiW5ibvLwG1/ekwRebzmhLTPlIuO3pghRxaQmUimecl4PidG6h/zsjSEME4M2cec3IVnXBfI1nWjrc14 3WV7Z5uQ Csa2H/EsK2JM2nmg+gmQ33hUAcGwlVzCjdqcZpwdyCk/wZFA2xPR+Q2T6BHNu3wQ5iKRuy/DbopV/JtN/yNm9TFPUzMd63Xp0huYXn7vAv5drzYEutFWMvmudHaLZ3G5i4HzjJfejxwmctC1B5i17wbjW7afikk2K17tDUpaqt3cRNHsVFFSxNfseTXlxMf1y5bsFA5y8ai94/vAAeAeusIwV3NOvygEYDfrijwoVEzhH/7YIZoUrf6nUhkgojr8VU6CO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 25, 2023 at 09:54:24PM +0800, Hao Xu wrote: > @@ -633,6 +633,8 @@ xfs_buf_find_insert( > * allocate the memory from the heap to minimise memory usage. If we > * can't get heap memory for these small buffers, we fall back to using > * the page allocator. > + * xfs_buf_alloc_kmem may return -EAGAIN, let's not return it but turn > + * to page allocator as well. This new sentence seems like it says exactly the same thing as the previous sentence. What am I missing?