From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF70FEE4993 for ; Wed, 23 Aug 2023 12:16:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B7F5900019; Wed, 23 Aug 2023 08:16:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 440788E0011; Wed, 23 Aug 2023 08:16:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30968900019; Wed, 23 Aug 2023 08:16:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1BFB28E0011 for ; Wed, 23 Aug 2023 08:16:21 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E386440651 for ; Wed, 23 Aug 2023 12:16:20 +0000 (UTC) X-FDA: 81155266920.04.D0FBD21 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 469DB2002A for ; Wed, 23 Aug 2023 12:16:19 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GPm0QEcy; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692792979; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h0H52xtfgXFJKiojPzFRYLqgYQ7ep2Z8nxNUt3SOtYM=; b=QN7BJ1NDjTBeDN1f/9ceDZqqPqTLbrgcEnSfkPyQBniums4Oox/pzY7xaZYinnvWr14sPp uo+13leLfsuYgnG+yn6v3X8ye2cCjEuRiIFyxkd2fDPh4SswTzjTlu+P9a5eckHr5sbhZQ tQ/KpzYyu5Uz54zxFVr6E4Ue9UOQl54= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692792979; a=rsa-sha256; cv=none; b=Zy0ZhNZdTdrNdyrFJY0czCUHC4Z2493WsvEK5/ZTqEQ9xklWf3amIeMMTxD7222Qutajpx 3r3lomr38cq+DBLAxhG3XgPaHfLGu7Km8bjQNpWRAOBezj0y5ZDCi8UK9sNiVxXgGTdm6N bHhHg/3yBCL/HOniTZjzzp5rjQHUHMs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GPm0QEcy; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=h0H52xtfgXFJKiojPzFRYLqgYQ7ep2Z8nxNUt3SOtYM=; b=GPm0QEcyStjGCZAY16pXw8tT+b ldLMGoakETXe0XejoNRcudwYIKQzIrdWXzAZcSMrr9eePbxdW9yVWOq2/TbhzUdRRsotzxgRhERVR DaHBHD8iTv+azZNBUSt4zK94JcrnisuibvxfnVfvtbCADNzSES0nB/+pJYJyWrWongStPFBubcP5M o2hDjof0my04gfbzY/VjHI3oyZU40q5GWwnu2HKhnzMrAnNFyMtkMYabgx4+M4v+f3kAHCIaRSkNn 8qrpxDGHCU13dHtGuDFKZu1eHS4+H4iq1VB+GX8ac6fdvdGDjexaTu0KOGhvygtUTi5UetsCi+p69 heSlVxYw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qYmmU-004l34-Sa; Wed, 23 Aug 2023 12:16:14 +0000 Date: Wed, 23 Aug 2023 13:16:14 +0100 From: Matthew Wilcox To: Yin Fengwei Cc: linux-mm@kvack.org, linux-perf-users@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com Subject: Re: [RFC PATCH 3/4] perf: Use vmalloc_to_folio() Message-ID: References: <20230821202016.2910321-1-willy@infradead.org> <20230821202016.2910321-4-willy@infradead.org> <627a43c1-048b-c6c7-62ab-28dc111a055e@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <627a43c1-048b-c6c7-62ab-28dc111a055e@intel.com> X-Rspamd-Queue-Id: 469DB2002A X-Rspam-User: X-Stat-Signature: yda3wf73f6hjrzy4j7g8yent46funx4z X-Rspamd-Server: rspam03 X-HE-Tag: 1692792979-815215 X-HE-Meta: U2FsdGVkX18WAioc/zRniKldIqp5IhnnxE/nAXutbzkBWAyKe/93iVWe4J8EAcxmMZW1LvJiioGJKZT5AX8pbk25L0YDt7Cc1uI7TweInTl3A76KiaxEZv+0yj8G1eNoeSVxfJ2XUxoJCuZdqJIb9fS6n/mZC7Igt6IdeC+7Sl3tq/rJm9AnaeAH8tk8zZyctk/Z/IqerZ6aKNZoF/LOszjW3QVd7KQ11SWktP9X1r50UwpcGc1Z3uNS0UjZGRJ9X56fayDrOV1CjE4xyA1KqUCcapA5aPLzkEN1UUAqpXZVjwe92z/J9gYml1NUXKYa3v8A2KMf6GKO60VuHltbeZ71QEdC/MxEDHvGxEPA/JniCO443eDAG6CEkbTIHNQcTsgv4yvwUDtauSAQjvNr9vOLBEKZ+4nVKE10YDYnQLPfovYk4MUqjB9nrnOtykC4O6MP9khl/ivkgrSHdv019QSST9KQEby8oeSUIiowr9BGmSbFMK5AK7RaI8V7a6DkhQY5VA7M2dlXhwY4ig2RMMXpXcJx0uxwVnxH7Qe+LFyfLjln/uNMh9LoUlCgdMKe+DBzKG92ZBTqGX3w3j8YmW7xqR5P+kS+MB7NoLXOtsLDFc/7yrLzV7B8hHN7rj90IyTPrWLC2dDxMvi7khf/9DXuTK4BhL6zMWp/ZUhneDIcL0IZOm9e36IgdWxOCV7TAeQwJQXRGyYDyURWP1c3ZhK7BwyL+4Hze03Feqet0pQ6NKqpw98+lqJb/4ofVWkgZ/Ae3TkxWFk1lATUZVzDFfTCKukOxkZCkiae3pF7W/tM0MTEX3pzJXGdB1FSc9iDAcWdaNfajT9FyGCs39bKD8n2/J3PDakOPX6DP5pnFIsZunVCnVCaxn2F/I09gXcIbnN++N8fyxXGHduGqoY41InVj4os6LHvk0SCOIwTifDcC/EIwTB2gipMDPu+clzelrIHsmC520ti+g6EpV3 BCp5bB5W 9inSuFIlq0OqIVi0dHQSYFs2mRuBw5xVz7EbOnaKqXtU1lbXe9gpqI1NXE7XPXWnT4+psEPvhKNNVDMrR6Deuf74RtW3M7LMP9YUCJajTlUHQb1GIG0mptjYM9qYZibL/w64aeue9wytNknGIkaQWfDV3YzqZJslQ8VmXox19/bsSIhGu+j4eaDP8og== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 23, 2023 at 03:30:22PM +0800, Yin Fengwei wrote: > On 8/22/23 04:20, Matthew Wilcox (Oracle) wrote: > > +static inline struct folio *vmalloc_to_folio(const void *addr) > > +{ > > + return page_folio(vmalloc_to_page(addr)); > I am wondering whether we should check the return value of vmalloc_to_page()? That's a good question. Almost every user of vmalloc_to_page() just assumes it works. But it'll cost very little to check for NULL, so I'll put that into the next version. Thanks!