From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E6FAEE49A3 for ; Tue, 22 Aug 2023 17:15:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1AE34280051; Tue, 22 Aug 2023 13:15:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15D52280046; Tue, 22 Aug 2023 13:15:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F4144280051; Tue, 22 Aug 2023 13:15:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E53F7280046 for ; Tue, 22 Aug 2023 13:15:34 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B916A1A040E for ; Tue, 22 Aug 2023 17:15:34 +0000 (UTC) X-FDA: 81152392188.03.55D663E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 6940BC0012 for ; Tue, 22 Aug 2023 17:15:31 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=VFZT8UUE; dmarc=none; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692724532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EC2X8oKwCSIWlwpcBI3Hrnd8qPKLnaGSiKpmv5+mejQ=; b=NnDQdcXYa2fjHSZmsd6BbiWXugTuW7WzSmiT20fuxCLNDxQXzJS3geJmPOaBF5HV51e+Hv yGDHrNtP7RYAKRztFNy8GhfMFmKgsfQlg9ctI71mj6dCyz4S6+IHQAb2tmZoF/s7H8DWEg yJUVKaO7JB1D2wYSyLu/dHzHTwMUWKo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=VFZT8UUE; dmarc=none; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692724532; a=rsa-sha256; cv=none; b=FQyHT1CHWkPjUN7L9Sy60t9Hpb+L3EL9lpeKmqaS9GbPSoporzM8zBRbYS4c8YvQsUy6PU VDLqTvGMoCsUBFDvTQO6ecr6645G5XhZWtmzjtiH4M6tfvdWERi9SdslBRIpm6XF+RCpv+ Q0GBI+usbD2+v98g7+NjXnCyrbbr36Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EC2X8oKwCSIWlwpcBI3Hrnd8qPKLnaGSiKpmv5+mejQ=; b=VFZT8UUEY5ekfYzupBEvDwNFWE oOV4V8iSR4D5FdkaM3daPBzA79z+P5ex/ur/JgPe2bOHMvfOZMbMaNyCI7oOxCNSWkaLlcKmIVNK8 uS8xmTawDmXMcewmwmHhE/sQQg8cpFwFgcbwX0MCOxztXZfJ8wmYWmb6DLZV5x+Bg0ekQ13otCI1G 1Ak6NBmGRRQUj3AoZac9DIZgwtyKkbiES2EW3SNPzbl5omS12iD4rEP1lNFlMRWyrYqy3raMRQiZ3 3J3CcyeHYC2qSp62BDO20mRhfBGQzxM+6cOUoKd/DjDFj9Zh+ag0lNjhNuOF7ssbjMVhBt2iM6DqA vaUI9PJw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qYUyS-00HXc6-0b; Tue, 22 Aug 2023 17:15:24 +0000 Date: Tue, 22 Aug 2023 18:15:23 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, songmuchun@bytedance.com, mike.kravetz@oracle.com Subject: Re: [PATCH v6] mm/filemap: remove hugetlb special casing in filemap.c Message-ID: References: <20230817181836.103744-1-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230817181836.103744-1-sidhartha.kumar@oracle.com> X-Rspamd-Queue-Id: 6940BC0012 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: eayf87y7ctz4cu3on7bhxr66embe5cra X-HE-Tag: 1692724531-352045 X-HE-Meta: U2FsdGVkX1+45XzhqMDNbsIxGccvj1aVkEef/odAYlKCe5gNaxgEAUYiA2Ra/wTOck2lfohmhkjSKNRT8M1dQ3WiXkP2ZGhphrIEuhk4bTX3zU8+VCogM69omhPi7J2VWxgDn3oxegw1bfi8rjTQygEiLHU6ghFlglcWAWoIlxEH6Rpck14+uGox0r2eiYZgPqaLjT7h9zflNVfc17Uve2OawA7W4xaPNRGjDsrdwWghyoyM2KVAaBMmtpxSgE+a//zOlxHYJPNg/P4IDJH93BdxKGzH6MhluvwLYaX4asSDwqIOoJqwEt4/FvXFmALTCg27L6hntC0nFQZ67dCqnhjeZI0ASe95gk3wLtedkJiaNdErKVLoQVzk07uwI+UoD3TrhMwXX6B17mOs5u9RyvmTuKqgm4xffd/mOsHs24ZSB454WnEd+uxawnS4jCGtt4gxmc+8HhUit2cg4lRRvq1rVnLtWCIRieFYeZ4HjbMl6rezzFjhRyqypqRvP8UuIGjdHhNdwYqRKzAS1NVKbpIjVWwRSElp1X1LqfgLOJDwGBg6lry99EyBM4wqrrzMJiq1v7FbpaK6HpCa+Hpp/mR7TtDLY2riz4vZsgKr2NAA1uVWdE8D0qLMaZ087zhcEhycOLTMNj+XQ5e4f+YC6tWpKFqfRsZXcdWNxH+MV/MgU4/YGs9GKhukyB/q2HXBbIWXhGhNKZt2pYAoWvXiB0bOYqlziGfWJ0Y2qJYf4kMqy9AxWYXCPkESQ33ldtpFNc8srjIU14OyfI3eisVcojoVSacCky/BFomEEtVIg2Ns094gE2tPov+t12XqCm3osEIonV5HRaBje5m4UKmiSgHcg1rFA2sSSAlBTIXJfIManwnYFq7D1cT4JWqDjBrNynM8rJslRtgqGfir+h++KmaFW1CtUWAB3SMa7RAe2HUxise7qYjfPX7KGtYnaLfI2IymVxJdo11jvMQKI1j G9KXlDHl bopC42dX1D5Zl9s8Jl1kNr+b5MwHzFzgij5FBY2QP/EEG1yV+mKEe2woulXQHhe4orJ8wGcRT9nxe/Y9gF3oQovkhWXz/1papwq4QpjiKufjww8WLiUVH1tEYnlLfdrUWoDkPfle9pze0gn8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 17, 2023 at 11:18:36AM -0700, Sidhartha Kumar wrote: > @@ -890,8 +867,6 @@ static inline pgoff_t linear_page_index(struct vm_area_struct *vma, > unsigned long address) > { > pgoff_t pgoff; > - if (unlikely(is_vm_hugetlb_page(vma))) > - return linear_hugepage_index(vma, address); > pgoff = (address - vma->vm_start) >> PAGE_SHIFT; > pgoff += vma->vm_pgoff; > return pgoff; This is the last use of linear_hugepage_index(), so please remove the function and its declaration too.