From: Matthew Wilcox <willy@infradead.org>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, songmuchun@bytedance.com,
mike.kravetz@oracle.com
Subject: Re: [PATCH v6] mm/filemap: remove hugetlb special casing in filemap.c
Date: Tue, 22 Aug 2023 18:15:23 +0100 [thread overview]
Message-ID: <ZOTtK1Kfa5gCS3Gb@casper.infradead.org> (raw)
In-Reply-To: <20230817181836.103744-1-sidhartha.kumar@oracle.com>
On Thu, Aug 17, 2023 at 11:18:36AM -0700, Sidhartha Kumar wrote:
> @@ -890,8 +867,6 @@ static inline pgoff_t linear_page_index(struct vm_area_struct *vma,
> unsigned long address)
> {
> pgoff_t pgoff;
> - if (unlikely(is_vm_hugetlb_page(vma)))
> - return linear_hugepage_index(vma, address);
> pgoff = (address - vma->vm_start) >> PAGE_SHIFT;
> pgoff += vma->vm_pgoff;
> return pgoff;
This is the last use of linear_hugepage_index(), so please remove the
function and its declaration too.
prev parent reply other threads:[~2023-08-22 17:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 18:18 Sidhartha Kumar
2023-08-18 18:03 ` Andrew Morton
2023-08-18 18:09 ` Matthew Wilcox
2023-08-18 18:34 ` Mike Kravetz
2023-08-18 18:54 ` Sidhartha Kumar
2023-08-18 19:24 ` Andrew Morton
2023-08-21 18:33 ` Mike Kravetz
2023-09-05 4:05 ` Sidhartha Kumar
2023-09-07 0:18 ` Mike Kravetz
2023-08-22 17:15 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOTtK1Kfa5gCS3Gb@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=sidhartha.kumar@oracle.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox