From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A742EE4993 for ; Tue, 22 Aug 2023 16:24:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E1D9280048; Tue, 22 Aug 2023 12:24:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4924994001B; Tue, 22 Aug 2023 12:24:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35966280048; Tue, 22 Aug 2023 12:24:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 22C8794001B for ; Tue, 22 Aug 2023 12:24:28 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E08951A03E9 for ; Tue, 22 Aug 2023 16:24:27 +0000 (UTC) X-FDA: 81152263374.23.9D53749 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 3368D40021 for ; Tue, 22 Aug 2023 16:24:25 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692721466; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PHTKUA6k0Tzs1hh3RSgJs7HMgPxaXrJY/9L6GI+GzSQ=; b=ziCnGlLCy/Q+OdULR3l5vPXlmQLlPiM+akF+McypUwKrSPdjDco5X8HXr0aH6jCrI3MHCN VTOtKyBzC4WNIFMcT/04yCcMAb+GcpOsQqTno9R5zFWdPApYvM9xo7Ju2hN2ioMXSqB2tO pFm9Hym8jipflfrRUXuXjIWs0YGrjo4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692721466; a=rsa-sha256; cv=none; b=fUjcLoNwS7b6RgccaHHtN1N7PXGKq1/0Ll8sJEaldd2jghHPAb11j/CGfp6VfsmzTT/tQ+ VuTy7GztS1NThy3gbXuW9xTfJAPi/Qb/9nqPsOtS5rAbcV2EGN9HEz9y4o5elny2uUcg+g jMofSp69tUpxKGYy017jsubc38EMM/8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D55962765; Tue, 22 Aug 2023 16:24:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 517BEC433C7; Tue, 22 Aug 2023 16:24:21 +0000 (UTC) Date: Tue, 22 Aug 2023 17:24:18 +0100 From: Catalin Marinas To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, Andrew Morton , Matthew Wilcox , Peter Xu , Will Deacon , Hugh Dickins , Seth Jennings , Dan Streetman , Vitaly Wool Subject: Re: [PATCH mm-unstable v1 1/4] mm/swap: stop using page->private on tail pages for THP_SWAP Message-ID: References: <20230821160849.531668-1-david@redhat.com> <20230821160849.531668-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230821160849.531668-2-david@redhat.com> X-Rspamd-Queue-Id: 3368D40021 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ot78dk1wxugmjojdxmd98tncfccomnmo X-HE-Tag: 1692721465-772472 X-HE-Meta: U2FsdGVkX1/RALu3W+/cHwpZgdnXYEjGat1QdeN/PFjIbvLUJOYuZfp/nqSZTbi4/wkF5D0RWQqnAEiJuPlvBc7wS+6ubxAw3oe1H6njxln3hSg+Qpcs1ct4Zotb7EW1S6MTyKIZLQ6262GL8UssQqAi1wjrFrlq682AYsF9Dh8+hJSNvz7kXBV9akZQJ16D0CPZpt43uyTzP1JDh7U0g1sumy1OKN7LDtx/PLyryZ6/OBIq93O1F5Q/MJ+1zI+rY5k8lu474pRmMlxxmkKx7UXQhe832S9fjWoDOToh/blYsN/LBDxSiQTMvltHg9BKO7FlFXn9FtJM1MnWwsmhfh2Na7D/FB0EbJPW+Pi5Av8LzZBNp6z8Ns92XTBrLs6Oibyk7f3lXh/fc4bovmEgtuW3MtN+IUcc1mLHhNVaBJwGacBeDQfI3o4kVXT2FbUBVjzgMQJXVTsLsFFy4QLyXvWbsewPlIXFUNJCmpKartYHJO8QyIAAvKKB9jBQC+IL4K0Di95SrfZi9FBdA8GcYAN52MLUUCSsjWoiRmdpYXeqfghJ1p4njwPJl7iO94i9Z0MstBYBw6KDCM85uUeVI0IsjVNTdofb3VuJbU977sIk66kEByaJfXoy/542H9l31tNi+yytmGWfFm7lR1zW60z+IyvgnM6hf/t7v9xUSNa/dOgeIhgpJBaSkhk24rMHG/ae/T0nhSxUfAR7cVrviaA3QI0ugu4i3BmwRZ9DhPC6Um2fEkRPHOm/CSfON3Ow09ioE0IEPExp/CwKCgp2IKGuvvmV2APvPvl+gyI2BK9FZfEEwOeLnmNQz2auf6mF/gMTWQvlSf1LB4zz2D67WDPfNjgXkBeXtAzasmJjW3i0IvSnF73yyozUClRr7UicflABM5N2UgwzQ+NaqyeiGdGS1nVRrXuEn1ZEKqHVaz7+NmvVRTDBt+ZRcGR8ka5t30ObwWtodAtw0RhRBu3 MjLboZIE H1WZdaDcwEMgY+yPKpj7xNAnoZM56p+DrosyEE8zGA63vYNJK18Gny1MCXG5CFWpVloNh2le09dWsPZOVhHGQioPQNgyHi3eDAJRT0GcIZiiH4ylSKZycwCLxrBqODbwh/BA8/uR7UUYspSprbIIR+I2bfHOucd2VnaKWCXkmn4klwHnYkOVC1Vn7HFD6BObTVacPTgNVf2zxAPq4RTCf24QELCQlfroslXcqC6XyUSMBXTKZeGWX91PmTibWGBusIjLePu0w1FtpMu7AfPvMCeotEgmwpc38r1/39yxowo+4kE3XqgiQgMlIBQRrQECNg98oCa+na3v150c43mQmPbIdScJa/zEaHEcVYkyGw8FZJ1CdnXVzp5j2EqpKVBUlHAsq1U/HhNkRSVHNa2VCVCyVQY9BtSKYJUp/x7aETSXg7XULC9U3n/10CWg7rclfq+0coG2/fXLDtVDpFLteLTLl3ZVjbxG1dVOklA/yd1+/kFSBO5Q9Eljh0Z/okU/ssuXBJwuACQgQHhk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 21, 2023 at 06:08:46PM +0200, David Hildenbrand wrote: > diff --git a/arch/arm64/mm/mteswap.c b/arch/arm64/mm/mteswap.c > index cd508ba80ab1..a31833e3ddc5 100644 > --- a/arch/arm64/mm/mteswap.c > +++ b/arch/arm64/mm/mteswap.c > @@ -33,8 +33,9 @@ int mte_save_tags(struct page *page) > > mte_save_page_tags(page_address(page), tag_storage); > > - /* page_private contains the swap entry.val set in do_swap_page */ > - ret = xa_store(&mte_pages, page_private(page), tag_storage, GFP_KERNEL); > + /* lookup the swap entry.val from the page */ > + ret = xa_store(&mte_pages, page_swap_entry(page).val, tag_storage, > + GFP_KERNEL); > if (WARN(xa_is_err(ret), "Failed to store MTE tags")) { > mte_free_tag_storage(tag_storage); > return xa_err(ret); For arm64: Acked-by: Catalin Marinas