From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5C38EE4996 for ; Mon, 21 Aug 2023 15:53:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2679D6B0078; Mon, 21 Aug 2023 11:53:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 216E06B007B; Mon, 21 Aug 2023 11:53:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DEB88E0002; Mon, 21 Aug 2023 11:53:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EE9F76B0078 for ; Mon, 21 Aug 2023 11:53:40 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B319F40AF2 for ; Mon, 21 Aug 2023 15:53:40 +0000 (UTC) X-FDA: 81148557000.20.359FF7F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id DCBAEC0011 for ; Mon, 21 Aug 2023 15:53:37 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Box8jdkc; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692633218; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5qggBg1KMTlDyTCTq+pFzw11HOgVdohF6vY/xmOVrxY=; b=UAeNRNDLa5qhYriHd2vo54WT0+4GIV/Cv7nNyd9ZG5MYxr7okrPMIkv2kPKn9DeJJWZCKc g+nL7KHmhdS0E2hwaRAdhQdea7PrVi6/WU5XJKjW2OsaGg4fYbCfF+OzmgqlFPqxBgfmaC eEurTJCoQiczD/MC1yySfFa76m5lHoA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Box8jdkc; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692633218; a=rsa-sha256; cv=none; b=qWcI5kXbUdddq6oty66sgObxpmXktodi9kTbvAGF2zb8nSBTdyTazliNHq7OWoabNAvgbc ilfRNnNAeQVB91O8fGgkJ1/EI5C+Aw//u2zQIe2Or47q+hozyuXe9img2kwmDWmZNz39I/ YkzrA2p4BFvPlNjMpYwthm5YbbkTIbM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5qggBg1KMTlDyTCTq+pFzw11HOgVdohF6vY/xmOVrxY=; b=Box8jdkc9cnprcktYZoalTuJ9E rVLMz4fXboR6B9KNEtPRKtKNKdFFgsZ7NU3GE4xnjhc+VK4GQTqsPbStlFNnM+zDJUzUP5FAN1dte SwUXaUPgofAdSbV9/w8DmmHlelwlPvwvHKmm+r6PgFXBzWhI4hIx9+CZWdD1JsPL+K8Yh4M4ZUyck kv+X0q+RczTwerdmK+RDbog3TIjqSwO2NFhxQVjq9sEADuxSjnMoj0ElsWTXjyW0pmU/1O9Z+YjcC qWsCbNwrTa51HgaF/aqqVZ9ZgXrxmAUd9/PIuC5DeMR+qdgVAeQtM5UQFr/7Ah7idlrbGdqaxo6zn UA/A3Z6g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qY7Dg-00B4WG-Oy; Mon, 21 Aug 2023 15:53:32 +0000 Date: Mon, 21 Aug 2023 16:53:32 +0100 From: Matthew Wilcox To: David Hildenbrand Cc: Andrew Morton , linux-mm@kvack.org, Mike Rapoport Subject: Re: [PATCH] secretmem: Conert page_is_secretmem() to folio_is_secretmem() Message-ID: References: <20230821141728.2536317-1-willy@infradead.org> <96895823-ce2a-5dc7-77a1-a28d1242bc6d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <96895823-ce2a-5dc7-77a1-a28d1242bc6d@redhat.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: DCBAEC0011 X-Stat-Signature: phsjijj3yyeptxe5tfqfagy46sx9cfc3 X-Rspam-User: X-HE-Tag: 1692633217-875628 X-HE-Meta: U2FsdGVkX1+DaSV8D7xpqoQT8annb5bDqrPeE4LVXjfnAct4bfkF06kMIClIruCmF9LAqCjG9b4kres+X2OkeZkrg/UTFxaPcGB9+boFa1VqMjhkoX0mwJG0xgiRRnxACGm1c33TXIb1haTOfFT8Hp+bl02wUij+wH5sG/K+dV0XdBvAOapZex2a0DRFNwQKO0Evun46Zsdtqazw/vSfcvHbwzHAktXY2eSoinYCuVXqUtTtpiG2mBtuMx/a1fsopI8EGW3zKlCceEVGQqIJIvT/4fKapjTayjTx+cXMrvBeBlkOgwGOtzBS6erFbwt1AP+z9bijg1s1iL9iEXjCaOkaw1aFBDBBUq96MgWyLAsByf0VfJ/QpM/nMwgIiJ6lq5r13y3S3OpmkiF8BxXS6Gfh/zgy9WSs184mjj99j3PIeihSvZ/r4mKnyAklxdOnm2Li9lGyyOJOV1cbnAPYa4Bh25ReHORaDBTOhk/keyhUz42zCESFEYKE1xqv4dc1W8vuChIfHKtV8+qATjlnwNDUZhZQcY7oHNdoSYscpi3aciRawzoZ579nnfRmFkEcDSPianD87d+Z5A4edcnjrstQ9xBewuhT+mjhT1eyop2Yc9kaZBOpORuynwaJpEObbmC4R66noquK0Y8gfEloMEGj74wnKzS4ZOKDJD0/0TJdi5IhLJS4RpOwCFP4j5gX6sf3DmlCWgQd2evkwJGKdai4ZqDQehieNZy8ewXk1zHmhFduYiRjHr/KxBZEW2cwODG72cr/wusHWU79Yk2tFEuipIbH7TMRelpEy/heQNzy7Hj1OaRc/n16M+mPEYTxIpE+hyDcspcSpisKauFU4kmh+Z5VncQZqB38xJyYiQ+FR8zyz+5mjEH7KYvztBhtbpeXYtN8svMRgqPOpRn9VaCl7lr4aa5XNaug5oTMWU8tqz44mM27W3YZMkyBlsq2CbEpqrtIdogxP8OPK38 3SYVmnSl 0GZ3DbsKNHBjUwrC+xIJmmPRzYDA1U68hLDl17G9Z5vkele3B+r3YJKsTj8RM65f9e0IG973tACGe+HBPB40De5N6fqf8CS9bSOpeuu/iGeXV3slsnCMH4YYHHMQcS67qcgFQGdiwkXsu3GBOCAR9erClVs1JxIkRzPdz3m2GEHczQNmvAllvrsjCQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 21, 2023 at 05:32:50PM +0200, David Hildenbrand wrote: > > - if (PageCompound(page) || !PageLRU(page)) > > + if (folio_test_large(folio) || folio_test_lru(folio)) > > return false; > > You converted a "!PageLRU(page)" into a "folio_test_lru(folio)". > > Shouldn't that be a "!folio_test_lru(folio)" ? Well, that's embarrassing. Obviously I don't have any secretmem hardware, so my smoke-test didn't catch it. Thanks, will do a v2.