From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16111EE4996 for ; Mon, 21 Aug 2023 12:38:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CC9C8D000A; Mon, 21 Aug 2023 08:38:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77CAC8D0002; Mon, 21 Aug 2023 08:38:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66C138D000A; Mon, 21 Aug 2023 08:38:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 53C318D0002 for ; Mon, 21 Aug 2023 08:38:42 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 200BE403EA for ; Mon, 21 Aug 2023 12:38:42 +0000 (UTC) X-FDA: 81148065684.22.3A214AC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 49C8C40002 for ; Mon, 21 Aug 2023 12:38:40 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QCHoLk5S; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692621520; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f3PuHd+3Oo29kL/k7GHTJhIOx0IaiYuSIgTjmSIW73E=; b=y8hCJvWMw+DDlifPgiKEd05Li1YBTPQl25/VlsO5+V9rns527BkK6dHzcCAmCCRjc7nlqc NA+6ibNY+Pwwlx8RYpz0scipdajDPxg4u8byoWabVcV0g03LpyjzMiOHiMnjc5tBjWm0Pz SopUxUil4AcJrIrnrRerX2UojTG6bSI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692621520; a=rsa-sha256; cv=none; b=wt4f5e/uhRQ487vKLvjlJrAkB+QErdQ/SOnEz+W5LPcE3JSdPA9GF3s5G/uWPx5PJd5UTC ZBdZq9l1AVlrT1jUPvgUdY82L6gQ9NpcBLhatrSmLjX1oISovtbBeuy85HMeJjwQb0WgjV xeAaockdO52D0dQH4upirW3cq8qim2o= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QCHoLk5S; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=f3PuHd+3Oo29kL/k7GHTJhIOx0IaiYuSIgTjmSIW73E=; b=QCHoLk5S5S1i0rIVGjBE6qUveQ RX+Xy4MHXX1/Al/BtxdRkyzbzDU39wSegEAp+k+hqGXQFMesZxmLsM/qKNSq/BdEagjkFIWkhbisM MAcRyd/rbI+lgkwfpwJeJnEe0v7k5U5FavE337DcvxcXs2zwJW1xafvO1Bc0OCI9oJJ11dAhJ7Hdo mO47LaLLNcmT0xKqZEPoCDPq0yAobV1fFqQNolS9K9WmvXesmrx1wv/GXEOHMZiThV3tGpAs1i5yR OXfPGWAzItW5axn4E4PQyIYJTQFtoRU0yQFTbC0V9sxefQxEiOar/acB3NARL+SZj0cuY86eUILOw pLqHlqqg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qY4B1-00ADDJ-AW; Mon, 21 Aug 2023 12:38:35 +0000 Date: Mon, 21 Aug 2023 13:38:35 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ying.huang@intel.com, david@redhat.com, Zi Yan , Mike Kravetz , hughd@google.com Subject: Re: [PATCH v2 1/8] mm: migrate: remove PageTransHuge check in numamigrate_isolate_page() Message-ID: References: <20230821115624.158759-1-wangkefeng.wang@huawei.com> <20230821115624.158759-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230821115624.158759-2-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: 49C8C40002 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: xydf7ayofhuy8gr4afuqg8cnijdz6s6k X-HE-Tag: 1692621520-221653 X-HE-Meta: U2FsdGVkX1+RtV8ZoNIuaIgvsrUBSfd3+jtV5cNzOg5zZM82KVD9y4Xw/Zs3wlhHUqfFjRXm4exEt/aJw5ALYsgL/m13IsMh/vCO9Cv7gIepBgpnk6IFrjCQu5NvQdrdZT5qglHbUkYE5ljCfpv0gXPfrC/IYQEUEbDWJ0wDysy4pMdDJvSgfQhDK38sNDcaAZKijm6HMlLU2ipIhuU1m0FsZ+QqzsLxCcxCE9ISHF5hIZ24akJQ5XbbHXI4M/VAR4VQykxd9oHbW/HCe/xdUSZELFBW5POGytMgewgCdhPFGp3kvqlY7N8dVSmmgiXyYAKJRwxVTkf8G1BsDcGzz0p35nEdUfbXWclUxMD3LtG/HYM/iG16pPnhbfUclSF0Zk7jBpBhGyEUlm81INtUC2PyR5Mu2dWo3m6f/019tI9a5TwgFpiACXdKOXmhUUp+mopr+4UY5NTIXvJ0+75ownQx7PGyU0dRG78KD5a9FwMdHXglf6d9KRNjdgk3HrbDlR+zXLsPthef15ZVa3E6+8ETDTWfqa4se0l90zHPlt+LK8Y1DAjml5jyeEJPu7FUGiTnXW34UfDDVrA818bNSnooDa1UdKnAljOMJkK5ODp9WGfipMKmlmm85t82t+J6bghMVNC2/N+C0gODPX8swjz6P5EKhJ3vpA11B4NswjuELFnSawGClgCa6cRwqudz4QgRfRFB5DUb8dhkGof5oLWufqlJPIAh8hQ0iImKBqpDQ8xaRtup5ZAh7Oi7nZWoWr0tn0CzBDNgdU6W4sb2zNyeUfgKI7wwKQy/u+oGRFtoMbMwgF5EFdYLOVZ4hJ29crc4bRA0hG3JUzCNMBb1c8yjW1MsYIb4FsUoGylvljrZ+5i3B6119THCsAs5pwLQxXXup8FVv8jwjGduCHYs0upuLxDkeNDO07gNM5nhuvzpAgB86EaquZHC6vWPION+rSjZ2UQuefxqrRStiWY JedBobaX 4KrUPczllJQaBDAArEic6gz/1atw+YiyWFdyMInEPAeZrSbORTf4KDdvKZHRfKsnhzDvyWVKT4XLm/2Lse9IbmKqewdtStwx+1U1eDfp+JBqcD8WWvLLVza7gZ/LQiZb8ZSd1VOb3933lRV7GYGijU5JZj9MDAyGmgdbB1oNHaiuAOLm2RmfHDmDofYDfgq1OvVTPxG64/e33Gdmtx+/kP0Y7M1hJKVcQ+W372hYCyIp0UctQfFmi4MqSRTmEhqODBek33bMkCacp3TE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 21, 2023 at 07:56:17PM +0800, Kefeng Wang wrote: > Since we begin to convert the numa migration code to use folio, which > could let us to handle arbitrary sizes of folio, so drop assert that > we only support PageTransHuge page(PMD size) when order > 0. Have you looked at the implementation of PageTransHuge()? Your description doesn't match what the code does. > Suggested-by: Matthew Wilcox (Oracle) > Signed-off-by: Kefeng Wang > --- > mm/migrate.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index b7fa020003f3..646d8ee7f102 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2483,8 +2483,6 @@ static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page) > int nr_pages = thp_nr_pages(page); > int order = compound_order(page); > > - VM_BUG_ON_PAGE(order && !PageTransHuge(page), page); > - > /* Do not migrate THP mapped by multiple processes */ > if (PageTransHuge(page) && total_mapcount(page) > 1) > return 0; > -- > 2.41.0 > >