From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C8E5EE49A0 for ; Mon, 21 Aug 2023 04:26:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9D6A8D0007; Mon, 21 Aug 2023 00:26:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4D298D0001; Mon, 21 Aug 2023 00:26:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B14F78D0007; Mon, 21 Aug 2023 00:26:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A33B68D0001 for ; Mon, 21 Aug 2023 00:26:18 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 68EBDC01CD for ; Mon, 21 Aug 2023 04:26:18 +0000 (UTC) X-FDA: 81146824836.04.4414D33 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id C6BBB10000B for ; Mon, 21 Aug 2023 04:26:16 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="GrUAGT6/"; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692591976; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+ThJSbWV78NlzV1/8C4mbgmYWZr69CC6aj59sQ9jdrI=; b=bsEsIKwpsOWXkxVBqkdrdeBlAv+WUm5zB+4LZSxp3AmzB3sCh3uQeFn4cLMrDXxAd0hC2D s9bwojJ5OMCslkKvweFvrmzjVRJ0ZOXJ1NcCC8oD4CIeHVJQ3MItrlvNWmL8WCZratU+AR YtqZkaySlmcJCJTbBd72rUhBhtAT624= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="GrUAGT6/"; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692591976; a=rsa-sha256; cv=none; b=rKvlj1RxHXZZXD5E3DENRUWyRYQF9mXz+EEibT1Fxm+npaRomlWz5YcP0ROAkyD0vwXvlU PTMTNcVbTXYmubrom6PRlwlR3apqjDVZi4bAhqK/88VJiJK+OdRsN0ulpRpTeYjbMAwrdE 3IgYwfVj06i8dPmqCJ0OJM9EjGu1E4Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+ThJSbWV78NlzV1/8C4mbgmYWZr69CC6aj59sQ9jdrI=; b=GrUAGT6/KObw5bPBQ7exfokg3U ynl1o6BaBJE2w8dxWn4SHwihK33nGtJXtQSf9WII5QNzRQ2K/FxjOeVh+I3cjJNNkdtdWtKYo9QXK L1nLWdqK2Q2UfESbpjBtH/wGVGA9F2JGqgVtY6LJfU5xpdm1d9Obs7iRoLeHn5+Fk4u9lWEzssWKz v3voHD9tHVIJeSzrbvkM2TyQTv/4lGmEmBmfGOENaS2YUABDuZDOlr+lPFyQjvTKPSjdOTcR16Q+W wkXH6nfN409c0r0+HFEB6nQP6TIFVNFeqlDel+ejgohfCksc0lt18vCEm9FV/ufHxoZNkWyxoln6Q dG471p0Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qXwU2-0086y2-1U; Mon, 21 Aug 2023 04:25:42 +0000 Date: Mon, 21 Aug 2023 05:25:41 +0100 From: Matthew Wilcox To: Byungchul Park Cc: linux-kernel@vger.kernel.org, kernel_team@skhynix.com, torvalds@linux-foundation.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, will@kernel.org, tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, david@fromorbit.com, amir73il@gmail.com, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com, 42.hyeyoo@gmail.com, chris.p.wilson@intel.com, gwan-gyeong.mun@intel.com, max.byungchul.park@gmail.com, boqun.feng@gmail.com, longman@redhat.com, hdanton@sina.com, her0gyugyu@gmail.com Subject: Re: [RESEND PATCH v10 25/25] dept: Track the potential waits of PG_{locked,writeback} Message-ID: References: <20230821034637.34630-1-byungchul@sk.com> <20230821034637.34630-26-byungchul@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230821034637.34630-26-byungchul@sk.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C6BBB10000B X-Stat-Signature: sixzm6jkoaup6xmsowbbga4eu4x3kaq1 X-HE-Tag: 1692591976-547226 X-HE-Meta: U2FsdGVkX1/SznsnVK0e0x6W8BsYeEpvFV/wmXES5AFkGQgUNO+RPNOAf0EqcBIDcCZetRgoG4ZUj7+j2iTiooeYJgVlRu/KigIMTdf2LODofDI+uta/SqCrI7nHWbRZSK17LxMJMO5V9QzCpKkBH45BusBi/K1mnbOwRZRS0xTqMkVp/sV08W10bao2MUn+rROQuo/gCTsYt+u7s3ioRVLm9mJwWsi0hz/KSfLPj9NTbEcfGNP/CRgaVsa4wLuKywdohS5a4gujyaeHMRGmDvTXwYTs9gRY7mtSYaMSgRKSLsQEYYFtUS5evuUXoUVx+N4p1bRYDmpq4WRnImVDTJbqQMjuMR3iClWxqL7HypmaXavhIvwoHy0IEES2xFSkjeCzbnYj93bl4+xXHq1g2d9OdacdmdFs/q598FTSs2Lhl5J7w4p7KTv4jByLZvXOotvyjzowvqxutepRdtpeEtcl+hxEhhFNf1rDk4tOVOdQhnYD6Pbikp0KDiuWUpOjSYu8VfiJWWiX+nhHCCwgtzDBJAVMufUUOs7QOcRclLHngg8a5LPr9zCLpZMhhgT74OztuYMicm/Ifs1P0arM8RpJ3K1NHELUatZYILdMFfRvFHI7feQNjypGhaImJL1yOxMRI5s5BJK6XyDQsTT9xsKpeusUTmLHA+R/fAlBLKW/f0n5mf0qn9BT4cnWswO2h6VuXY7vVhp3zz3OWRzTUnXZbOZ10N3s+lMAXl0T7iXyBgTYaCuP/jTYe0Lv57bmmoMt+0QdgX2uWdn0hv60WlxV3PkCZUJBWsG+1dZx/ZOWKbU6jyPAEMaakHntekuye7e9YaDd7an31Llxo5t6NrTRgi+nTx/WyoxBK2dOOVCgQXJxb9p/Wm+lnYUQp1YoelJpPEBaBjoRn/7YZOH3I9hm7KzTos0WxU2/XryiCOirtVc1GHx3jk6ZZlxOJCNCJc5D1xoyDZO4MUcuiYJ u/cW1ffU J90Q5SsV88s0XCVouXcgDKajuQ/5qKsLJFqUB7uIBk1KPlRoiAfdr9RRe2ucXDCYwPHlyTlfYaAwEem4BxiBtPXS6gKZ1yS7suxiqqRile+QID89qgnDB7KoyINSrl9XX1GR+OVT3epDwzsbF+nefqJydd/I0kdp56YdA2Z8TR577ylwDYDMWRv2RsItRZWWZ7gMTq9tnaVZOu/p885kXXDfKYSLXtVUcgRcxt6mzrYwIAUZj3jpoALMvGvRbFqFZNY97 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 21, 2023 at 12:46:37PM +0900, Byungchul Park wrote: > @@ -377,44 +421,88 @@ static __always_inline int Page##uname(struct page *page) \ > #define SETPAGEFLAG(uname, lname, policy) \ > static __always_inline \ > void folio_set_##lname(struct folio *folio) \ > -{ set_bit(PG_##lname, folio_flags(folio, FOLIO_##policy)); } \ > +{ \ > + set_bit(PG_##lname, folio_flags(folio, FOLIO_##policy)); \ > + dept_page_set_bit(&folio->page, PG_##lname); \ The PG_locked and PG_writeback bits only actually exist in the folio; the ones in struct page are just legacy and never actually used. Perhaps we could make the APIs more folio-based and less page-based? > static __always_inline void SetPage##uname(struct page *page) \ > -{ set_bit(PG_##lname, &policy(page, 1)->flags); } > +{ \ > + set_bit(PG_##lname, &policy(page, 1)->flags); \ > + dept_page_set_bit(page, PG_##lname); \ > +} I don't think we ever call this for PG_writeback or PG_locked. If I'm wrong, we can probably fix that ;-) > static __always_inline void __SetPage##uname(struct page *page) \ > -{ __set_bit(PG_##lname, &policy(page, 1)->flags); } > +{ \ > + __set_bit(PG_##lname, &policy(page, 1)->flags); \ > + dept_page_set_bit(page, PG_##lname); \ > +} Umm. We do call __SetPageLocked() though ... I'll fix those up to be __set_folio_locked().