From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AD42EE49A2 for ; Sat, 19 Aug 2023 01:04:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3376A94007F; Fri, 18 Aug 2023 21:04:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BF12940012; Fri, 18 Aug 2023 21:04:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 138FE94007F; Fri, 18 Aug 2023 21:04:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 01063940012 for ; Fri, 18 Aug 2023 21:04:25 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C4BE416086D for ; Sat, 19 Aug 2023 01:04:25 +0000 (UTC) X-FDA: 81139058490.11.6B74604 Received: from rere.qmqm.pl (rere.qmqm.pl [91.227.64.183]) by imf17.hostedemail.com (Postfix) with ESMTP id B5B234000B for ; Sat, 19 Aug 2023 01:04:22 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=rere.qmqm.pl header.s=1 header.b="Gz9HN/5k"; dmarc=pass (policy=reject) header.from=rere.qmqm.pl; spf=pass (imf17.hostedemail.com: domain of mirq-linux@rere.qmqm.pl designates 91.227.64.183 as permitted sender) smtp.mailfrom=mirq-linux@rere.qmqm.pl ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692407063; a=rsa-sha256; cv=none; b=q8UhmMm370UhCrABkuHA2P6U8OX68lc/Gd4cc0UUg9Ljtdx9yO6YnBM7QopcvF3bXW5pCn Vf9QFAHW/tZ73GJ4ZDWZoHz8MhkRNltKO40mBlUG5gNLFH1SgcIjDDj8smFQFx8ovLulzv As6jtj23sWtc50xOo4VtC/fDcktyB4o= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=rere.qmqm.pl header.s=1 header.b="Gz9HN/5k"; dmarc=pass (policy=reject) header.from=rere.qmqm.pl; spf=pass (imf17.hostedemail.com: domain of mirq-linux@rere.qmqm.pl designates 91.227.64.183 as permitted sender) smtp.mailfrom=mirq-linux@rere.qmqm.pl ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692407063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z6dRNiF1rVokW5QCur71tpsdovd2Au9FcAUv5Kq2Wjg=; b=aadj2unehO7KYxiAIKJ/5nRU5OO0I9Jklw6zYnXlEKbc/sxc2mXnxQfvYDK7bryuUhtXqG VLSDKGPFYtMOAGBdlj/fGJJt2OlF7ey2F81/sIZaFNmX0mw0ex66JU8zz69BVsNkDK/vms FNKMPzWz4j9lksH4gNROe/kd/CFCT3E= Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4RSL9Z0rDnz9Y; Sat, 19 Aug 2023 03:04:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1692407060; bh=sFq9Q+VaStp1O+YV7cwSTZ53EOPS3jtEcfot7OFqKYo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Gz9HN/5ke2KWkSBGXpxjmiGIQ6pVqMNlBIiUp9oEzLyclbNE27pcaLnZmjGt8fyDG yuRmR4LoesM+ikFVO1lthn22e79wgUIVudmi7uvOWixPYQO+hkS+1AG67vfktG8r/E 09xvswvHSS03kZpP08hV29fFX8PYJrsMsOCpyaBMEQpDg2TI9qh/kT4JtD8XlSy+ul amQ6PdgWHi2pYEYYEqD8fbAyEwWFqLM2UUGENRBDQkCiZ6rcVJOtQKOqwtrcAi275N YocSGFnW+CJgcpaXU4w0TdjesZQFKuyBPLkcE1GsIm8ZGl9wi8r5TcPShBF2vXeUpr t+8Ght2q9MPlg== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.8 at mail Date: Sat, 19 Aug 2023 03:04:16 +0200 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= To: Muhammad Usama Anjum Cc: Peter Xu , Andrew Morton , =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= , Andrei Vagin , Danylo Mocherniuk , Paul Gofman , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com, Cyrill Gorcunov , Mike Rapoport , Nadav Amit , David Hildenbrand Subject: Re: [PATCH v32 2/6] fs/proc/task_mmu: Implement IOCTL to get and optionally clear info about PTEs Message-ID: References: <20230816113049.1697849-1-usama.anjum@collabora.com> <20230816113049.1697849-3-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230816113049.1697849-3-usama.anjum@collabora.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B5B234000B X-Stat-Signature: 47e9npyct349y9fbugxyydguiu88hryq X-HE-Tag: 1692407062-100616 X-HE-Meta: U2FsdGVkX1/7xClSSBfLkl8PLHs595vNL8ZcT1bJZEePy11+S4fb8RWfB9YBkhDu/jki1lVQ6E+Y5LB+07xL/YbOzdASxB4rXZvlbdri7ivhhac4FyJkZWPfZ6Lhff7Tz3qQtZKNXUXu8Eq3e7D/mXqlmLyjsoN3bkWwMQzZcwWq3h6k5f8lQG/BVgpJI8GaU3vH4oJEjNJcrKG3x3JDDCuv9MeCyEf8wEa4p28cTcUxf7xbL/98YEa9aNiQOZ2CJCIkVHHdkprFRpD9EpaXAj7b9yTHDE1e7obHpaS10yT7cIVA3lFP56s7Pbrwqg1cyad+EMBsta210rHyVYwLwt+t2a523gn00cosqiXmElpWNcA8NuP1veUeJSLOUi2dKjWB4N32K2PV1x5sHJkAN6lzcDwDFUp3MWUn/bzHg05C9II3mlaASTxP76C68N9Ai8abk2URulUxBddKgBSxFPQF4UwGZYxWHOaGefKfYO3k3JqIu7eHzlSPTDpLwKm4e27W0/oEdDyEsitlI+ViIKhsjZtHeM63JgFgX/DNWtmveiSbRMZrcZHw4nxR4W+eMcM90u/UongEP6olDpdNYnvb6GVUhmN3Rk2VydzpCalOTcezs+dsRgtZg1vPw7r36O72wgGYJNns3ik/fdkLIIMnegMDyKi8sr7bA4uTX0fEMrZsI73xK7VcRSNwGWahsPbxnV6GAonNqNIapxPIuZTL56bPPWSegZRtcq1le+yLCvV+MwrZqBGTDtX8HpQhaSKpvWvlNnNI7a/NSH9D9SXnA0fm3J9MNwX2EWG30uCX0fbHR8m55uQCcb1dn5w+j/PHpyvXcJp2XyUP2tJdZQayea2p2iUFXd5iDDNYXiuH3xL6aHt+RNmJAIo3oIoG/z4C7Ou6mybiyCofD+KqErB75tMbLkVxJb6sr1bpCkGBnEQRoe8d1lSKe4u9DbQfCH+nXhNFI86MLQtvBCa XA45u6rQ G9lkONZ7Zu+xXLmSklzUcf31dSysun1UKhJGjAbzrImEDvlQTaa3Id23dlb7DIPqE7BdgMhhri2eeO6pBLqkDpawUVtke7PhTaZvRSSiIXhU/wazySmeaK1NJg20mXGQQtXKTaWgFZVJBBzFvQFvMA8FkEv1ma0BMlitq+GgxhPbotDCxr6CIHtgEn5jqcDSPDCSx4HHYSDRF/+TQbo6tNr2MzG4vVophhNCbtf2umkwd1J8568lGubyelGqeotJqpD49PGZp6HrAaBjHt4ZIxIpK1SEJ7+BoqUu2DxZtELZUpfo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 16, 2023 at 04:30:45PM +0500, Muhammad Usama Anjum wrote: > The PAGEMAP_SCAN IOCTL on the pagemap file can be used to get or optionally > clear the info about page table entries. [...] > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c [...] > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > +static unsigned long pagemap_thp_category(pmd_t pmd) > +{ > + unsigned long categories = PAGE_IS_HUGE; > + > + /* > + * THPs don't support file-backed memory. So PAGE_IS_FILE > + * is not checked here. > + */ It seems that we can have THP for files: ref. recent LKML thread [1]. [1] https://lkml.org/lkml/2023/8/16/1212 > + if (pmd_present(pmd)) { > + categories |= PAGE_IS_PRESENT; > + if (!pmd_uffd_wp(pmd)) > + categories |= PAGE_IS_WRITTEN; > + if (is_zero_pfn(pmd_pfn(pmd))) > + categories |= PAGE_IS_PFNZERO; > + } else if (is_swap_pmd(pmd)) { > + categories |= PAGE_IS_SWAPPED; > + if (!pmd_swp_uffd_wp(pmd)) > + categories |= PAGE_IS_WRITTEN; > + } > + > + return categories; > +} Best Regards Michał Mirosław