From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 237FCC83F01 for ; Wed, 30 Aug 2023 15:08:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 747BF280047; Wed, 30 Aug 2023 11:08:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D090280018; Wed, 30 Aug 2023 11:08:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59882280047; Wed, 30 Aug 2023 11:08:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 48B90280018 for ; Wed, 30 Aug 2023 11:08:01 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 23269A02C7 for ; Wed, 30 Aug 2023 15:08:01 +0000 (UTC) X-FDA: 81181101162.18.6C179E7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 07553A002E for ; Wed, 30 Aug 2023 15:07:58 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Q19sOrtX; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693408079; a=rsa-sha256; cv=none; b=Loq5DEt2/JTvAmIavaIxje4KIg302RT+8WRLa/QVswgUQ+0atguq/Tx+K+6p3W8lHO/c/A NeWq0Y+F9Z/cinLwfm6AWC71zZ3vYz02GNKIlLwjd/3ooEfRc1slJzhZKmugr263CoTeP7 SIe82U6gvxuljWzSUKSnbi+uQvLTzxo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Q19sOrtX; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693408079; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qx6Hv03afYO2DcF1Co9RrVZaNbveLy1N2Smbr7cXGis=; b=xXkesxlRFBSLMTR6y7VQuKpvjIFhCKf+Cfea5u4TBDhmrTTyq9VRb2wgeDhVRgvHFJqzYS kK5am+lBxt/RQ9bigpcFRQ2E3aBNJx8faq8dt2f2A1gFePw0rMtfCn77OUtf8vw6Y9QhiX KfD0v5lTCv5CnktoXhwqEdwWZ41dUy0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qx6Hv03afYO2DcF1Co9RrVZaNbveLy1N2Smbr7cXGis=; b=Q19sOrtXU8MwQtRgcv5PdRPXVd ddLPWPMW4gFp2vQJueb1aicAe0VpSkCfd0ZSS+wHSXnIqP3YArq6Z5otRt3oHf+D3l4Kmb/UHj80q MwOuooHpWhFTZM4BEODK0tlxw3leCBja7a/f/8BIwIo3QtvhdJS8hEFHbiJ/c34Y4L1i0srn26Nul 3J0IKX2ds+9SU94MLd3h/F/BQcqr674y9mxOpwpSEF+PpF1gYe3Xs2kbAMBe9kHi8awry/9ZfKIeY HNR+txmBfCS8yS+hnxf10DDhUuzNmBtpHiH3+dV5NpgI2MHxKsH+6pyDgJFM/c07v4IWf6xz0Tp5a ChGzQuTQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qbMmf-00DQtC-B6; Wed, 30 Aug 2023 15:07:05 +0000 Date: Wed, 30 Aug 2023 16:07:05 +0100 From: Matthew Wilcox To: Ryan Roberts Cc: Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Christian Borntraeger , Sven Schnelle , Arnd Bergmann , David Hildenbrand , Yu Zhao , "Kirill A. Shutemov" , Yin Fengwei , Yang Shi , "Huang, Ying" , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] mm/mmu_gather: Store and process pages in contig ranges Message-ID: References: <20230830095011.1228673-1-ryan.roberts@arm.com> <20230830095011.1228673-6-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230830095011.1228673-6-ryan.roberts@arm.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 07553A002E X-Stat-Signature: 3q3tnwdexn7usmmdr571bzu49wjgijar X-Rspam-User: X-HE-Tag: 1693408078-732659 X-HE-Meta: U2FsdGVkX18VmIUqwRGCOTY/HrxLlnujFJ01wpmLVlr69A4ijC+fR/piQCicXfVOImJ1O1TKlfBY7zKQCb1pi1G5bzehQw3Zx+lqFhk9G03UAvHyLJVw1pdumyn0Dtb8zWFnxl3ZZcHYtg6tuDDC14yfVzFmHu5ijDhW6mRyZMp6bmyXVHWlIrI5Fc0PSd/De9WpKC5UPYLU7ky2c8rXfbg6BRuUJ7WCK6TWykuGHN1BEMHpWLLcV5wIg/KyAe4rmXSYh1Z+q4hrW74LLJtbyu6QZCK1epEmnp8/+DmnHixPmXt/d8Zg9fX7C9eM1TYuR0Nybhjxxz8fQNyUXyWjxZJLWE8NjPnOwch9gO6/gIEYajiEh8LZYD0vcZhC+8OtI32ttxfrcrGONzsBHJIDSOVqLwXFSN8rrSPFd3oe3qOzPmpcaJKcwop6oVpE+1kIk+WUQ3568OM+SOiA3MuizgOtGoUEe2JaxCz8hrFY8XP1+l0p6A1KAjn05VnLEYFPVmlg9ZuCnsbjAFavfZBd6qhcGCgzX871o0C6jJd1sr8PHxBwyoTIS8MZkugTUsy4FAN667aYm2xk5k79yFFVN5/bHug0iSqpQPYFlovb9yARD2jvt4QNFJdSM4qBmUoQYw8amLXe1F9NaCqSFuBv4Y+UZ/G5Vsvbx4+5cPSUo5RAypVHYjLayg3z5WYYoH11zRNJF//+aWWDg5WN9Qd2noepX25HHE4+bJjSFfzQekRqZ0AvJFviaOuQO5EAqtjKqd6nTpA5LhiDFuci6rGLuFc2yttIfl5JUrePRtDZtEfJoNcetxszPw580MynPky7TLyoFrL0fBxpwcRX4rJ5/evJfRE1XG1kyAMXrw/5DqElvuqDBCOycdMSrWn+RdCIFCelQYiJ+D7eZpDrdUk4CjIgjJTanXM+aKL2orMgfBzzXFj7i3DXnIrPCHm9UXmTbXNfFXRZL3YikU29JWn XDQnWJA1 HFYa8MLZg0tHQ7p11XNlX4Zj0ibeuoJQlvoG1LeyI0JSojkt6mfc+QqEujUTKHxFbkdE6XLfXbEKpL7VN4xXPsbC8yemM/igMv/I/0xnEUrCrBh2rm2YI4GOnZpibRPFQznEUbXt48lxOyN09zgio9lwzioEKExKeUBOE4A4i1g6UYuFUlJenAGDd6w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 30, 2023 at 10:50:11AM +0100, Ryan Roberts wrote: > +++ b/include/asm-generic/tlb.h > @@ -246,11 +246,11 @@ struct mmu_gather_batch { > struct mmu_gather_batch *next; > unsigned int nr; > unsigned int max; > - struct page *pages[]; > + struct pfn_range folios[]; I think it's dangerous to call this 'folios' as it lets you think that each entry is a single folio. But as I understand this patch, you can coagulate contiguous ranges across multiple folios. > -void free_pages_and_swap_cache(struct page **pages, int nr) > +void free_folios_and_swap_cache(struct pfn_range *folios, int nr) > { > lru_add_drain(); > for (int i = 0; i < nr; i++) > - free_swap_cache(pages[i]); > - release_pages(pages, nr); > + free_swap_cache(pfn_to_page(folios[i].start)); ... but here, you only put the swapcache for the first folio covered by the range, not for each folio. > + folios_put_refs(folios, nr); It's kind of confusing to have folios_put() which takes a struct folio * and then folios_put_refs() which takes a struct pfn_range *. pfn_range_put()?