From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7993BC83F15 for ; Wed, 30 Aug 2023 14:15:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B5EF280057; Wed, 30 Aug 2023 10:15:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 765AD280056; Wed, 30 Aug 2023 10:15:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60972280057; Wed, 30 Aug 2023 10:15:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 526BE280056 for ; Wed, 30 Aug 2023 10:15:16 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 10A3440236 for ; Wed, 30 Aug 2023 14:15:16 +0000 (UTC) X-FDA: 81180968232.26.5480BC7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id B78FBC0015 for ; Wed, 30 Aug 2023 14:15:13 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=X+Ele4QP; dmarc=none; spf=none (imf28.hostedemail.com: domain of BATV+c04187f51a783b17db46+7311+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c04187f51a783b17db46+7311+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693404914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XbQ7gMQrAcvK1XSExiaQeRITAKl62TKIPRcJwwWpzTo=; b=jNiGTx3/YEKPawWuutjG3VPj9GLEyJ5j8xuTpTJqxA0Ufa6rP7/NV0Fnlc7i9UFdTEuieB zyxJeVr6W9y3Cayp2O3culO03AeFOrz8PNoWpUNxGqFrUd+Kh5NUn/Xv2LKFBGbQPXHXWP uTfjACP6ZCQO7tu5qKMWNBHyEn3DaRQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=X+Ele4QP; dmarc=none; spf=none (imf28.hostedemail.com: domain of BATV+c04187f51a783b17db46+7311+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c04187f51a783b17db46+7311+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693404914; a=rsa-sha256; cv=none; b=xEOf+nz8jcOvA9D7peA5UcBzYR1azVd6DkOTgtnNbWlK2BM29Gue7gPsmBDb5na16v5fs3 znIhINylt6CpD388TRRfSrZqjhrf0BKNeaSijzb57d/gAj4xG/Wmgt9OLrKvLd3ZbFZlDT k213uF0Eas1Pe5OX7tsBiRurucyrFNI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XbQ7gMQrAcvK1XSExiaQeRITAKl62TKIPRcJwwWpzTo=; b=X+Ele4QPnoho0G3croIs5hHJUt 1MQWSa16yB+FN+agjMFkdYYgK+brizFBRYB9Km5kTF0czOjH6aeBVVoDbDgzcjS5ncMLixMZVpior iJLIEJ6/dUHXTJXu0/O7wsUpJuAkWqKLA2fnhX5b0ptlRjxhjcHtmhHjmBcIfbC5FQU7e9ffmT+vv FvhafUdZQOHmlAPhB4PZNYqqvyUZnW642WHwVTiTJQa5XyR5zQTRuGVvbd6jm9RznS8dV4wELXtuD m6eoBV94L1UUxjhWceioy2fDqNCRPqrNBeq6xUP3UonmQHCZld8DhRe/6wy9vw57O0nS7iNwm9EFo GB83Tk7w==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qbLyQ-00DekX-27; Wed, 30 Aug 2023 14:15:10 +0000 Date: Wed, 30 Aug 2023 07:15:10 -0700 From: Christoph Hellwig To: Vivek Kasireddy Cc: dri-devel@lists.freedesktop.org, linux-mm@kvack.org, David Hildenbrand , Daniel Vetter , Mike Kravetz , Hugh Dickins , Peter Xu , Jason Gunthorpe , Gerd Hoffmann , Dongwon Kim , Junxiao Chang Subject: Re: [PATCH v1 1/3] mm/gup: Export check_and_migrate_movable_pages() Message-ID: References: <20230817064934.3424431-1-vivek.kasireddy@intel.com> <20230817064934.3424431-2-vivek.kasireddy@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230817064934.3424431-2-vivek.kasireddy@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: B78FBC0015 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: i1bn5zhpg7ghf4syqrtdrqnn76tededx X-HE-Tag: 1693404913-811419 X-HE-Meta: U2FsdGVkX1/F7Nf1CQuVJtdRgKmFRh5tMWpb2XC+Q3Fv40rciVfufv+4sDPIYDt/Gi545ajqZQW7VosKs/fktZiDrwakoV+RXx2xVNx6/G4CiDW17CKKWWyS6dZIQK/rs315GtO9CzTB75Wx8FuoOqTzbSi0ZWnc/7pZCJXHcnkcfEOSsC0ulGRYxUPdXKyFNx4ljYPmh78NMj2M+WLM3gxQ0cmdBELDAajSJxkl6mIIzwNNlzUTAPIvJ1DfpVG/AzXQJ4oiTawG3xs5W5m6AkQxn1BEoIpyd8Nk7TNi1KarGsYePQ/v/bQ7Wtf4NL+AiTpmWl8W7rdbw8gqAN+sRgE5qHBia/nkSZi2U4XMcIcfFqrzWVEJAcOqnkZc4b3J2382JH4e4xqeWBmDIzIfCFgG6Dvba7ddf5KuOWrinZ8O8zV0XiZUQKeWTz3UHb72lcDlk6bUNGQW5CWTPRj81qLWMEz6e71GKKD0/Zav6mCzQrZCefO14ym3cT8F3zKpIhwmmXc57tP+55g3wkEW/mi6hcNZv/lpLpswXyn9ZwOnXIzqfU5h/mseCMQc68p21JEFGFxgvFEFaR2B5hgkOR5YowRiFHFE9M+WnHL8yLlc3RoAgxG+7cZohQDw8t4QtBkso6rpfLnkzf0F9386QKoN6X8GtqT10mUlr8/J4TtMh1I9hgJP0Age6U+jrtwKUPXogwnlYpftEWjCRrfbn1Edzuh9kv6VfV2JOMwufOpPbtEBU4dnv8aqAB/mDK1R/pRpF5j6oVHBOupKPK3D4IX+8SjDsaN8uDxaOtQE91M2PbrJzznADlflOucDUSK4kJd9d0y4eCGN4Qb0TARyw4vnyCpfw91q3nTMoWywdsDW4Wfw9IE6jdfsf/22xMTv7ECny1R0YECKaPWym+ur2MAbdYbdMMRib9nvY7DFRWu1Sofgym8t0sOuMHHiv1QiupumTX5rRHUY474LSs+ GA5d97Uz hHg0rs8mLYX8b70GGL/Su5FUkjS6uwuayFIEYgVg5NwaJsZl+Br0mGgR+3n7E+Qj5K9wPowTmQlYrVdTom52VmLfdmfskeDAdTJq/aGe66rY5c3ELdp2KzWhBnrvN5MjpX3fyvMxUK30rCoV9zWntzRgdOt4I2UBBaH8ziXGiD2FWVmQz69LuIJzn7HmTE2KM0OdfLsTyi9gcF5l+A24eZ0c1DnXyVza7eB5Lfk74TZAJvl5xpIlmWMe63kAA47CvPQbivXk2tOZmaocdZpd2TzjnBqhiulUUt3ZQKp4NBAVjLgKT/aVLhd5K0TDktdAWMk8MW6V6S6x8bez/g/ioSIpnokd30ohhwsnORY9P0TOayl+huRYIfvkMyxKfr7nrMPVz25Ir7523VB+DGNyR+Ya88TmWVr/zjuJbRXLDTi+6ilhRM/0tKuYeQ5rRLqlqpq6VSnbJSIRZBnRiAjoT2Vyl2w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 16, 2023 at 11:49:32PM -0700, Vivek Kasireddy wrote: > For drivers that would like to migrate pages out of the movable > zone (or CMA) in order to pin them (longterm) for DMA, using > check_and_migrate_movable_pages() directly provides a convenient > option instead of duplicating similar checks (e.g, checking > the folios for zone, hugetlb, etc) and calling migrate_pages() > directly. > > Ideally, a driver is expected to call pin_user_pages(FOLL_LONGTERM) > to migrate and pin the pages for longterm DMA but there are > situations where the GUP APIs cannot be used directly for > various reasons (e.g, when the VMA or start addr cannot be > easily determined but the relevant pages are available). No way this should be an exposed API. Please add an API that does the migration and pinning in one useful helper, including one to undo the pin. Then properly document it, and ensure it is a _GPL export.