From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 893E0C83F01 for ; Wed, 30 Aug 2023 12:08:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F720440149; Wed, 30 Aug 2023 08:08:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A75B440009; Wed, 30 Aug 2023 08:08:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED8AE440149; Wed, 30 Aug 2023 08:08:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DF4D9440009 for ; Wed, 30 Aug 2023 08:08:44 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 93233C045C for ; Wed, 30 Aug 2023 12:08:44 +0000 (UTC) X-FDA: 81180649368.15.AF0041A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id D9D4B1C0038 for ; Wed, 30 Aug 2023 12:08:42 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZjtW3pIg; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693397322; a=rsa-sha256; cv=none; b=ZgEFCokPszYT7L3CwecEuOEIma5LWGTPXy0pSa+zbKLXNQK5wmootCnUSZeqR+JO3NdHci m7yuD6B/yrxRA+lP/NzXYzDpqTG05RVU5tFk0jTeNtfghoVqc583gTsM6l7SFnsp1NgrYB myXuF+5sqELERCtCBl6B7OJALueb+pw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZjtW3pIg; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693397322; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NbJWoCOx2Ft9OMUClG80nlQLFeZZUsdNl4uLp0OM5Og=; b=KebypBlr9Ueu8uMDtYHQxN7XbHWPAYWzE8GvYk+K3gHT+f+0fkRlOMB6NpNwgPGJnmZezB nyEWykADOlCns8OO1d1Ne4rIDyiFyQMJ3vWOFHH/AZ+wPLeMHQQX3wxCrhMKp3EzGnBf5F qGQWtSfuNjiurtrjNn97OTlmrH9iZnU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NbJWoCOx2Ft9OMUClG80nlQLFeZZUsdNl4uLp0OM5Og=; b=ZjtW3pIgr7xhXH5l8qea/OAzAu XBG7uMdCv4+47puQN+F1oPJh+WjiVusDa5RJRYUjlh9BAhzqF4iC0DqjQrhrrAKH5p2R0DGOxTq+E hjrwQzZYlgtQ/Eq1eVo7R9nykn34zitpgxU9/fA8t/XIaz2lOEr5CBEu2htNZ3YCneU65eF/UBYVG MWo1H1gwvi+bNpaF3czbOvQ238xDmloZiI3ladTsgt0VcXsUfbHnqa7hsYhljPEmDGmqCa9CMZHi8 oTdZCdCj/LwKeivjqfPZK7SUbLu6FLEHL1xVhlU0rCUIXliUWttXKxZNuSrI83W6+Bm2yDJzpqIZY PB8jRBKg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qbJzv-00Ced0-EY; Wed, 30 Aug 2023 12:08:35 +0000 Date: Wed, 30 Aug 2023 13:08:35 +0100 From: Matthew Wilcox To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, Andrew Morton , Zqiang , Zhen Lei , "Paul E . McKenney" , rcu@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] rcu: Dump vmalloc memory info safely Message-ID: References: <20230830110402.386898-1-joel@joelfernandes.org> <20230830110402.386898-2-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230830110402.386898-2-joel@joelfernandes.org> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D9D4B1C0038 X-Stat-Signature: 4omdr8birfe7kut55qggkdfqnaquc4ca X-HE-Tag: 1693397322-859902 X-HE-Meta: U2FsdGVkX1+LBk0XPk9r/0dKbUeV+UuabQZkJjk59d14EiSN9n2nWY2P1IvUY7cvlMeda8QRNI+ROlUZm9YflSdC29bgbfUUCazJ9vr1dn9Ar6aiqq7OquBfZyv+2D+GxhBxyyjcW6xJbeytdmikuONAtjStOZomAjxxla00MCyBCL6VUY+CFUw0EtGlyOWHUAQvx5fQ9fz+uPxWQiXRFWtJB8HsIEn0cQKsB9rRWtMfP+EtTzvGPYBfsPGuwAYByVSC8wevxLuFqS0IS+471Q0LQ4v3tZlh8V1GTqSGZtmpfrjRXABaYtvC3goU6Fqajay97f1oPDdznsheRWu83dif0rdjWAkBeveI+2ia7JTy3dzcwMx6vCWAfVkpiIw0V+E1SOKuzdN01rhp3EjvdyNWreJ45Vpj9WHnlrDsQEpvhVR/WXVHVWmxYXb7gba2gE4XRgh8Z4pWoryM7WEc3TzJYZ+QaNoqeNQ4ocqyizAw4NtK/PP0uX3baI5MKVQpwmfYBamyTN7OFBtDvNGhQKENgT+RtmNqqRppnaA06uLsgO2fM3kYKNdypr59mRoc0v1RV2Z71/LqK19weGRnSUl4ePllZ/DR/vDE6wdQfui2M1tpAwb98ZWyaAkiKL12g6/OQUMjMx1o0pxzys6h2R047rZAjnGMUWaVV2mVqHr9bntg59SExWsJ9McL/DsAqZFb7skliV0jZ5yDsBNfVeDdyjWa2oW0X3+Eqk7rp3bHdMqDimyuSiUZGamVowTTLLXov6F0it4aZluw8OFSucfdDLbuDoaa9g3AJVSMifBX6RN8EkuXTXXv7pd3hGeSZoja5GR5LHzaTggXJJgrWxuGsS/EiFECo6xCi/sSCKUnQeaAndTpqSfPKVcbnoTxHA0r+i+mqhIQuC2fFDZfJ7CKU3VYW+VlNb2jLm8OyO7CXTwLnPtqGpxQOgvQbWfGWYrec/GZAUkuOTqHwig uDW9w5JO oDY0mmWC/ohtW03qCgCfhu6s8uiw/N+SkylcVUBddO/mY2tCzo+49gHy0D3iQNl1tEmtGinkbMwscDFuE4/mVMhPEwSUUHZ0U6CsmjZUPcbwhuRQEUphYFeEbMY/gmhKHhNTz0xVhwqjw6dAPjH8cHkzUs1MFkTw+Vw5eyatEZ3Us969nT921AaAEOgfL3BdwipgXpzopwNtiJdxquRdYawZxoUwkz8iN2WU97q5n3ryIMbK3SsCmvcmNhcM6YV9ehZnECid8hdOsvFNu1Xu3U0gLlUjMSqUGoNQX5OLnJ1IJijijvLBV5UEIsf187RLb/3kk2iyGU2xEZaqBiU0a2jBy8dUMn1B9hnG8WqhxiEYunIfNGP+t+YZTI+h707iYm88NdPHI55Z0CB1A0IyEds1lp2bvIywsOfn9+xg8Iev+1SENelcj0a+bY+lM4v7PQLiSJ2FD7S4SAYCE62W0pwxRXdbtOMnmJvq6vJxOVzvkxwO/Gj1C8Mk5fEQARbmbtM9UwiiP46UQyPI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 30, 2023 at 11:04:00AM +0000, Joel Fernandes (Google) wrote: > From: Zqiang > > Currently, for double invoke call_rcu(), will dump rcu_head objects > memory info, if the objects is not allocated from the slab allocator, > the vmalloc_dump_obj() will be invoke and the vmap_area_lock spinlock > need to be held, since the call_rcu() can be invoked in interrupt context, > therefore, there is a possibility of spinlock deadlock scenarios. > > And in Preempt-RT kernel, the rcutorture test also trigger the following > lockdep warning: > > BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48 > in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 1, name: swapper/0 > preempt_count: 1, expected: 0 > RCU nest depth: 1, expected: 1 > 3 locks held by swapper/0/1: > #0: ffffffffb534ee80 (fullstop_mutex){+.+.}-{4:4}, at: torture_init_begin+0x24/0xa0 > #1: ffffffffb5307940 (rcu_read_lock){....}-{1:3}, at: rcu_torture_init+0x1ec7/0x2370 > #2: ffffffffb536af40 (vmap_area_lock){+.+.}-{3:3}, at: find_vmap_area+0x1f/0x70 > irq event stamp: 565512 > hardirqs last enabled at (565511): [] __call_rcu_common+0x218/0x940 > hardirqs last disabled at (565512): [] rcu_torture_init+0x20b2/0x2370 > softirqs last enabled at (399112): [] __local_bh_enable_ip+0x126/0x170 > softirqs last disabled at (399106): [] inet_register_protosw+0x9/0x1d0 > Preemption disabled at: > [] rcu_torture_init+0x1f13/0x2370 > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 6.5.0-rc4-rt2-yocto-preempt-rt+ #15 > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.16.2-0-gea1b7a073390-prebuilt.qemu.org 04/01/2014 > Call Trace: > > dump_stack_lvl+0x68/0xb0 > dump_stack+0x14/0x20 > __might_resched+0x1aa/0x280 > ? __pfx_rcu_torture_err_cb+0x10/0x10 > rt_spin_lock+0x53/0x130 > ? find_vmap_area+0x1f/0x70 > find_vmap_area+0x1f/0x70 > vmalloc_dump_obj+0x20/0x60 > mem_dump_obj+0x22/0x90 > __call_rcu_common+0x5bf/0x940 > ? debug_smp_processor_id+0x1b/0x30 > call_rcu_hurry+0x14/0x20 > rcu_torture_init+0x1f82/0x2370 > ? __pfx_rcu_torture_leak_cb+0x10/0x10 > ? __pfx_rcu_torture_leak_cb+0x10/0x10 > ? __pfx_rcu_torture_init+0x10/0x10 > do_one_initcall+0x6c/0x300 > ? debug_smp_processor_id+0x1b/0x30 > kernel_init_freeable+0x2b9/0x540 > ? __pfx_kernel_init+0x10/0x10 > kernel_init+0x1f/0x150 > ret_from_fork+0x40/0x50 > ? __pfx_kernel_init+0x10/0x10 > ret_from_fork_asm+0x1b/0x30 > > > The previous patch fixes this by using the deadlock-safe best-effort > version of find_vm_area. However, in case of failure print the fact that > the pointer was a vmalloc pointer so that we print at least something. > > Reported-by: Zhen Lei > Cc: Paul E. McKenney > Cc: rcu@vger.kernel.org > Signed-off-by: Zqiang > Signed-off-by: Joel Fernandes (Google) Reviewed-by: Matthew Wilcox (Oracle)