From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEC25C6FA8F for ; Wed, 30 Aug 2023 09:20:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CC9828004D; Wed, 30 Aug 2023 05:20:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07D818E0009; Wed, 30 Aug 2023 05:20:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E866A28004D; Wed, 30 Aug 2023 05:20:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D85768E0009 for ; Wed, 30 Aug 2023 05:20:13 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9995DA0151 for ; Wed, 30 Aug 2023 09:20:13 +0000 (UTC) X-FDA: 81180224706.17.B58373F Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf26.hostedemail.com (Postfix) with ESMTP id 9CD7114001E for ; Wed, 30 Aug 2023 09:20:11 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=V0x+VpvK; spf=pass (imf26.hostedemail.com: domain of elver@google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693387211; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b3mfR1VNhnX8t7/rO2iFNZaVWO0Cq4zowvDh6il0OaE=; b=YReRjB6YjXu7uQL1JY/4Ib2cHiWvp3KMBy0n6RwYrTKZj+d3dVJf4ILgwyoERHe20trLK+ TJ3o087dK496IgpgTGw+HdumHn2eBI43Ikh8fTJfKkKSNWjVAhRvr0kbms59gJS6UrmUtY 1UdKhHH3G1ySn+q8RsiPYAH+sbbSmB0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693387211; a=rsa-sha256; cv=none; b=skrYgK6CM/Rr3UFQGLVD3EAxVgVPb7rkgBYiADGRHqX9EFwgl7jwD5jModxgMa/h6mZpDy OsaumhCRfNaTMBXBLCEUzWd7u2tvKoC0RUqUnqd99nOdSBSP2dgAQVZmYHr83K1HrdFGAZ sskq+cRmTHHG0CytBE7OL3mOapo62jQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=V0x+VpvK; spf=pass (imf26.hostedemail.com: domain of elver@google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-40037db2fe7so50171195e9.0 for ; Wed, 30 Aug 2023 02:20:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1693387210; x=1693992010; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=b3mfR1VNhnX8t7/rO2iFNZaVWO0Cq4zowvDh6il0OaE=; b=V0x+VpvK/Y/0Q4F/Q21v+ijKvpQ7sxH3IGX7DDGehgDJSiCY+VoK/U+dKFoTGpWvLp yNYOv1s1WzoQQL2yklHkscY1rECN37uy7DOuW/RWT8xCt9z4z0UuD3WhbqIldLsAS0MS SOVZUT1kttyXsOzMweWAGHqIW9pgqNtoF7dSqvM9rScIjUIkNmxEkItM6x/mNnWM5V2V SXHT5m38ASu1x1/O57xIiTShN9PN2j6VZITpLTo0pcRxAQto1mvDqPaTFhCqW3W1O/VA kqbf/qnuqQBbapiPknJCa6ugH7BeCItzgYjodbvIOqJpIwpt8BsKUTsMntyBi2y250xb LW9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693387210; x=1693992010; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b3mfR1VNhnX8t7/rO2iFNZaVWO0Cq4zowvDh6il0OaE=; b=TnxU6QV3vXLlNvM9/6FUwInv8Qq9VrmNBftNph9kzqc2yqWVUXHfRZLTTIzhT0iPx3 DLttdGA6hibXlgk6JP/jt4bbRdopbOqJeOfH6iBmXDgocnTuCazdHOxGD6h4zDwpF7/W abSovw8eNDBBA+n+lTKAyYW9gKFbN4BjL4JdkMLn1JBIp3icXPyH4qHgCiyJN16vpdD9 FicuLolP9zaSzI97ydNAzqb7cSnlYjxrMDsNHEGlQcrKwolC9Hc2seXhjyTsQl2LCdXG Yesr0g0aK+H/qNo2P4mreR7RshCRFVbUarOgQEc1HpTfEFuB2HdC/h7yPKOGmqsJ3Dm2 AzQw== X-Gm-Message-State: AOJu0YzvbXnyjZIPTOgWMdRn3woSRrtUvaYdHNGYN1VuGZODgH98YJXk I4vbutvfUqfxtBYI9eXdo5pqKGKWupu8Lzc74E84Iw== X-Google-Smtp-Source: AGHT+IEr3qJVf+Evdd0/8WrCb5RUc45X401I+nSpQJmzHBkwBH8GGI1/nZ4ZYAnqd1H3u+GWVTwhEA== X-Received: by 2002:a5d:4049:0:b0:313:f45f:74a1 with SMTP id w9-20020a5d4049000000b00313f45f74a1mr1221197wrp.51.1693387209795; Wed, 30 Aug 2023 02:20:09 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:9c:201:3380:af04:1905:46a]) by smtp.gmail.com with ESMTPSA id w12-20020a5d4b4c000000b0031416362e23sm16155248wrs.3.2023.08.30.02.20.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Aug 2023 02:20:09 -0700 (PDT) Date: Wed, 30 Aug 2023 11:20:03 +0200 From: Marco Elver To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH 14/15] stackdepot: allow users to evict stack traces Message-ID: References: <99cd7ac4a312e86c768b933332364272b9e3fb40.1693328501.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <99cd7ac4a312e86c768b933332364272b9e3fb40.1693328501.git.andreyknvl@google.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Stat-Signature: k3wg99hyc19cwk57nsd7utsygwa19q9p X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9CD7114001E X-Rspam-User: X-HE-Tag: 1693387211-770540 X-HE-Meta: U2FsdGVkX1+h8HRbbg4fdUA46m06kKWBFFJ5G9yQopLnyKN/5LIJItRKWFdeZDP8tTmGvs+IwIabcORHdWZHUE8ml43MoaFR23algVpjWLu5sFYvpKSFckjGHfndaNsD8+5RDbkK83B9DNYoDt+Gq3i0IwPj7+6CfhT/HKQH8Ua6CSa/aQ5Jq6zXjYWeixgE0dEzcIXQzI+FnhiH2aYHwelOLriJpEvuQKLM7dcyZCqYfzND8Ih+vcUiWghBVK8Jk0OMJoXGwbQfF4Hxu9De3TTh0G2N+lnDbgD0gEd7mA2/Nv9ywTBIaiFR5uSj/rTjVa9NPu5kuDK5IpF2J93+W2EXsxCGcctatKIck9XyJjGp2L7DefHMhxgHdcibax0tffELZfXoWIBrnaAg6IiBXmX7UY07iOPtCRhvBxNlCOJuaCd91RT3+ToavUzQxU6RBOjoDX7d2pNWjcP5fPUnoixyBL2xUtYOqtX9NPUC/hTfg2zuHzOP4H3R3u5Jk4EDpSBwTVSSQVItZbZAb/X0Z3XjPJw9E8FXS3nC7recACXRuMp5z/0j2SXYo3OXwRTmAv+svK94fyGm0rnyo2pwWgEfCdau1rcYL2YR0Vvs8lU2Y6QBBJtvgzqIz7ECzveq7Rr1125mUB9gJBTCRv1cec4vNqYA0C9qdOcjPVAkCKIRgshweYdrIiVAS4V2N9thVivbaXbzZ9pe151TZtECy9sh9T6mlFXpr1XfFimUZX9CWR7LguVWqdT/NSBCKsXl1WvxlAUQDX/C7/4dVLtniIMwP+4v79XJmkMbyF5gv8rTx5CRhOjZhR5B9XYoFVMhMq/3xvY8OMBWvLNAyFWhzkwBjCUxkQvwNTI19pEKBWTILcOr59GriOvw90RZS7L52yh9bIWrlIUSONrurvOmkIVvaECadm/Jc/cTjagLtCytfC2x1gceLb5IkUcNgr35/+SoVfqeSiQmMstwotQ AyTCiO+f fT3yQTPU+067RTZZfayMdOYDS5rEh6Dw5fOuG/A6srOrDAquxSxf27pzq8ikfZufV5Yv4bixrusCd6QguZx+xkvzhfUGpAALG1QfBffLv55EtwHd0dpOVv1clIDZBtCjBQX5qFC0d13pd/N//pkYAj2bgmL9pe/E/hvoVTu5t7SO3Y0T3TFo4obtKWnD6DFVaab3vdPtoJWitVGdIuFsn6npNW2qpiNBvkbg/xVMphezpMvp26q+goqJs7PnMn9B1cFet95aiSc/ln0/pwkCjsxXwZyuqftfhRJsAXapw9vS8zU9vwt76Y6IjGgL5edFITKrt7ogiUHJfMfMqzEMqN0SoDX8gOxFrysmUFtJgYUlT56A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 29, 2023 at 07:11PM +0200, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > Add stack_depot_evict, a function that decrements a reference counter > on a stack record and removes it from the stack depot once the counter > reaches 0. > > Internally, when removing a stack record, the function unlinks it from > the hash table bucket and returns to the freelist. > > With this change, the users of stack depot can call stack_depot_evict > when keeping a stack trace in the stack depot is not needed anymore. > This allows avoiding polluting the stack depot with irrelevant stack > traces and thus have more space to store the relevant ones before the > stack depot reaches its capacity. > > Signed-off-by: Andrey Konovalov > --- > include/linux/stackdepot.h | 11 ++++++++++ > lib/stackdepot.c | 43 ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 54 insertions(+) > > diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h > index e58306783d8e..b14da6797714 100644 > --- a/include/linux/stackdepot.h > +++ b/include/linux/stackdepot.h > @@ -121,6 +121,17 @@ depot_stack_handle_t stack_depot_save(unsigned long *entries, > unsigned int stack_depot_fetch(depot_stack_handle_t handle, > unsigned long **entries); > > +/** > + * stack_depot_evict - Drop a reference to a stack trace from stack depot > + * > + * @handle: Stack depot handle returned from stack_depot_save() > + * > + * The stack trace gets fully removed from stack depot once all references "gets fully removed" -> "is evicted" ? > + * to it has been dropped (once the number of stack_depot_evict calls matches "has been" -> "have been" > + * the number of stack_depot_save calls for this stack trace). > + */ > +void stack_depot_evict(depot_stack_handle_t handle); > + > /** > * stack_depot_print - Print a stack trace from stack depot > * > diff --git a/lib/stackdepot.c b/lib/stackdepot.c > index 641db97d8c7c..cf28720b842d 100644 > --- a/lib/stackdepot.c > +++ b/lib/stackdepot.c > @@ -384,6 +384,13 @@ static struct stack_record *depot_fetch_stack(depot_stack_handle_t handle) > return stack; > } > > +/* Frees stack into the freelist. */ > +static void depot_free_stack(struct stack_record *stack) > +{ > + stack->next = next_stack; > + next_stack = stack; > +} > + > /* Calculates the hash for a stack. */ > static inline u32 hash_stack(unsigned long *entries, unsigned int size) > { > @@ -555,6 +562,42 @@ unsigned int stack_depot_fetch(depot_stack_handle_t handle, > } > EXPORT_SYMBOL_GPL(stack_depot_fetch); > > +void stack_depot_evict(depot_stack_handle_t handle) > +{ > + struct stack_record *stack, **bucket; > + unsigned long flags; > + > + if (!handle || stack_depot_disabled) > + return; > + > + write_lock_irqsave(&pool_rwlock, flags); > + > + stack = depot_fetch_stack(handle); > + if (WARN_ON(!stack)) > + goto out; > + > + if (refcount_dec_and_test(&stack->count)) { > + /* Drop stack from the hash table. */ > + if (stack->next) > + stack->next->prev = stack->prev; > + if (stack->prev) > + stack->prev->next = stack->next; > + else { > + bucket = &stack_table[stack->hash & stack_hash_mask]; > + *bucket = stack->next; > + } > + stack->next = NULL; > + stack->prev = NULL; > + > + /* Free stack. */ > + depot_free_stack(stack); > + } > + > +out: > + write_unlock_irqrestore(&pool_rwlock, flags); > +} > +EXPORT_SYMBOL_GPL(stack_depot_evict); > + > void stack_depot_print(depot_stack_handle_t stack) > { > unsigned long *entries; > -- > 2.25.1 >