From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 219FDC83F14 for ; Wed, 30 Aug 2023 12:48:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E0D044014A; Wed, 30 Aug 2023 08:48:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69170440009; Wed, 30 Aug 2023 08:48:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5588544014A; Wed, 30 Aug 2023 08:48:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 45D67440009 for ; Wed, 30 Aug 2023 08:48:22 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 191C41A016F for ; Wed, 30 Aug 2023 12:48:22 +0000 (UTC) X-FDA: 81180749244.03.9E2A7AB Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP id D28D240012 for ; Wed, 30 Aug 2023 12:48:18 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=QymoGGmp; spf=none (imf11.hostedemail.com: domain of BATV+c04187f51a783b17db46+7311+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c04187f51a783b17db46+7311+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693399700; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IOWE/0M8BlcymUq1i49NiJ36nIsTbEwhbzVvvXqFMks=; b=7d61fhzuE0KqtZRIYzoyNibEIdFWV809iOqRppYUS7nUOv6iLSAUg4uZhB2IgnbEZdLPxN bYJle0qcS1ov7egEaCB32OswKitwydSO3mI60S9O7zA7+TMGAUuguwBIg0ESu523IHFIXz cv7+xAvqR6Q5Fp9MRkL0OQDJUEIlMfI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693399700; a=rsa-sha256; cv=none; b=5sSajEVsF9zJZFULoygsPiy7Oo8gZJh+Cmucu2QEqkTko6yMYUbw9EMJgYxU9u4f+F3l6S O9OvTJBpnXQnO0GNG2GZqlArOcPnf71E2qgrx5f1VPQ4ECroD1jLY5ETAl1u2EHQAuvIJE CH6wlihSUEeT1BFlWv7lTtWxRqYxtMQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=QymoGGmp; spf=none (imf11.hostedemail.com: domain of BATV+c04187f51a783b17db46+7311+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c04187f51a783b17db46+7311+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IOWE/0M8BlcymUq1i49NiJ36nIsTbEwhbzVvvXqFMks=; b=QymoGGmpy5KxS8E9NT36ocDUFW FnQpoW3j5rcesOV+zTgj13HGQTw5I5dMHi1Qh4AjEp5RNalo/sjDh8q61y5O1SNvKMaNG3z5tOK05 hXLu7s/J+VbEf+Ng2ivX+cNRVlCY+c1PIEZcwEgimLsbcZr/TBI5pV74seszbeQ4Ht/3tNFuqwx/j LukHJRG6ZJ8PhqCn89AtKH5QqGWV1gt72LUedCHf68SnTaGhvg5h1slQWuY+HF7+1xmEjwSMAqO2L 3KLO8gtaeQAnMLQ88GYi57SC4EJVZT+QWuFfHxKrv2MTQm7psgOH4P80HNUq2KTAlHuWvV1MGvghD 0QDvhsfw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qbKcE-00DVAO-1k; Wed, 30 Aug 2023 12:48:10 +0000 Date: Wed, 30 Aug 2023 05:48:10 -0700 From: Christoph Hellwig To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Zhen Lei , "Paul E . McKenney" , rcu@vger.kernel.org, Zqiang , linux-mm@kvack.org Subject: Re: [PATCH 1/2] mm/vmalloc: Add a safer version of find_vm_area() for debug Message-ID: References: <20230830110402.386898-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230830110402.386898-1-joel@joelfernandes.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: D28D240012 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: pnohoqdypgfpwi16hxf9bxhzwphwurx4 X-HE-Tag: 1693399698-546609 X-HE-Meta: U2FsdGVkX18pgiZt6DrL46SUlBbJrCDsyXdHrgXpDsbLXMwhKfpceNj5jiP+xRNeGDX6VcW9lTUtaV/k3+2KGGA8FwHamcYk0gz1XS9wp7YMkcpO9lhaugYqm6+7rHQFfgIX6LTY/L9F5ggJlWuBxFM2xTBv8aN8wjL9Sx0K85F5Pmpjn6fUnah52qRvsteLK951WV8iAYLPPxgBPTBMYmo6od6vZJlQBMXC3WQqmTK48pd1QugYIb3OARpA0scWyx9L2pmDH5VAEoadwY3zmqOMwyjayR7s/WiQW6bkp6Jph+KzhBWlYCyuiqxXXzRV6xrG8TwDFaCSCK8cjSe/et18+0Q/b503ekOr8AXxqTbac50kc8JxpQ1cGcLXcFVsrtWW+KiuNJRobPcjg+ws3rKyWNWd5r8+er1Y95giHomCtp/cD7WeWVuBUq71pI10+ObnOXZv5fVTNT67B69eUgq5u/wlZS9Kv4WWSxvLbvFcYeLQ81FUwxIajyfnnfviCY0bgi1+LEIRWFEy2IsgY6gPbRkPuMz1CjVNl18pW031ncKok1hce9yaEsxZzWzgBr/WdZwsY82z9rOgjUhPH3pyJcyeyDyIuBf2yYZj7rrc493a2VqNENpokKQJ0nF8R2yXVKf1P0FoZOb9P+sxEUFZ81iHYpXKx88xszsvcaROLo/XkId8E/4BNzSAfA1eQnA7ezLaXTu0l6osKWhcYGFQLi9roiL/Pt+AbBPYs1/9dSB3ITMCba0I0zotrLH32k15yZUlnoSZC1fCn3JiU1E8NvjZ7k03Xxr8vgJQVd1Np+6OhAegj5ryuIijvLp0h43dZl5sC/rQTjNL0OLDr5qH3OKOyeI30D+QVlTJyTgT6YnBKrY4UAq91ReEjceiArh9MCgQP28dsvj/v9tWNfQMt+Ue66xrMuRW7dwdZ9TNDhdyYsI8GSiQO5/eH5zHtLNHJQfdy6OxrrACz0r zte7y+Oy b6rCDslxRNbfm+myAblDPZOE1gJyMV8nSNLInnC++MhLvobOiqW5e9m3bncVk0SLBG7YbrGxW4p6OqwIaADZXadJMENqOOnrGRCxdVcpQNw4Lwao6ebhX5lQyyWg1OisQi8h2wyvNP/suRkYrPYwBuTtqfhWHR6+lmQABifmVHBXMrqgVqiu5pyy8/BkHqAGkQg36Cuy+ZH/t10SpS/D/c0gj52tGOO4HrO7fS393E9uZ5IpgFMe4cKvyGOrvbP67BrSbKW5I9fSsbzlTJrQb6cr7TevQXQwccVx5eTCSucNMy2FOP/04G2jY/0oSOhuolMippjeC43v7gZDvjjNPjVwHgX4iMtzaF5wu+DYu+0d5datsriMapa+/YydltzAXFmGuV1TwXxrWwuVNyyxJ6rO+nRG2w4rRKC6HPyFpYoEVLfNKHXSWrTJkicIyKfw6GNml31+wFHhtldm7/rF6wcofYb0cCvZTGk1prg+lbOfOzbA7Sk+59cwju7VCyAGc3fmO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 30, 2023 at 11:03:59AM +0000, Joel Fernandes (Google) wrote: > It is unsafe to dump vmalloc area information when trying to do so from > some contexts. Add a safer trylock version of the same function to do a > best-effort VMA finding and use it from vmalloc_dump_obj(). Seems like 2/2 to actually use this is missing?