From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A39F6C83F10 for ; Wed, 30 Aug 2023 03:24:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 320B0680003; Tue, 29 Aug 2023 23:24:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D15D8E000B; Tue, 29 Aug 2023 23:24:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C06B680003; Tue, 29 Aug 2023 23:24:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 095DC8E000B for ; Tue, 29 Aug 2023 23:24:57 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D67D7C0418 for ; Wed, 30 Aug 2023 03:24:56 +0000 (UTC) X-FDA: 81179329392.28.B2ABB58 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 3F3C6180017 for ; Wed, 30 Aug 2023 03:24:55 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=b8WMJ745; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693365895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VVA7GaUS5V1klkwOVyxNgdi/XPDy8SsdCWkheIYk4Uo=; b=rjqZznfaJJvm3Y+pbABA+Te2ydvHMdZM5vxnCC3o218PjFp6qDYk/B0G18/bsZGp69+OwL Sn375Oszm0W7bP2jDVkP+PadS3PK+5yxW24egH6MNb56vlUA7fHXpvLYV7Z9D5cZ/Cn03o 4TXHnHmidXukWHTJN6suIpCDxdWWyDw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=b8WMJ745; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693365895; a=rsa-sha256; cv=none; b=J+sRO9+LmWngdMXYuh33Zkasc60lkHW8o3to4Lul/CGgGExAzcZEOmGc8HFR4D26Lf5k8q gy/WVe8VOh+Xi8yz1+bvwmZGcklj13/zV3eRkeyoocMiRJck9XBSxTIWwZJuD3oKyaDW1o qiYI9Jw4HIwWSahz0Z4nWSNFEGlDYJ8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VVA7GaUS5V1klkwOVyxNgdi/XPDy8SsdCWkheIYk4Uo=; b=b8WMJ745RNOA9XNX/H2kPTp3d+ 6EVUGgGsrlbPBVjtmRaMekDE5AHSgQmC04vqvyoHA0Ed4mqRLa4qQ6Spz6mIwjHeHcC0J2/eyDW7u MPXGA7hwgum7RcSyqf7MF6u7iLHuoqbcC0figH1vUOIubewZ/6fb7NBo1dtho8/Bb2M4RjJRyze6p C9UjWZfhtXAXhi88Ov9WfzuigwXdqKvwJA9vLS43z4syUqqT6KEh9jGk1MYeJ43M6njQdAQ8gY6kb xevuOjX2+DM/PhBXZ342tqeoKZlGA+kIMcFrajOrKRlw8QRMvklNZ3xTkEz2NPW2nIx7G0Dikdroy aDQcGnxQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qbBp7-00APzQ-6V; Wed, 30 Aug 2023 03:24:53 +0000 Date: Wed, 30 Aug 2023 04:24:53 +0100 From: Matthew Wilcox To: Anshuman Khandual Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mmap: Define DEFAULT_STACK_GUARD_GAP Message-ID: References: <20230828035248.678960-1-anshuman.khandual@arm.com> <3622f8fe-00c4-298e-0b35-06bb61b92cde@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3622f8fe-00c4-298e-0b35-06bb61b92cde@arm.com> X-Rspam-User: X-Stat-Signature: qc3u3cb5kgngpbm6yri75qn3m1o96n6q X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3F3C6180017 X-HE-Tag: 1693365895-515317 X-HE-Meta: U2FsdGVkX1/tP4BV3x0KxRkOGieONU6k2f6sHvKZ0km9evxkXgLuRdNcChUE+w3aoOfJoiQ+3MV4jdnERrJ7nCK8hlFBtTrvAzJ3eRCb6vh9Zlby3YiGD8gkxMo0E8wSJjVSQ1rYFm++blaOUGwzJvScn9YD4brGFet0N7wVZrYhJo2OQtQy8FBnp/fgqrsL41TZ7LnslqpEk/hIhN380M8hJNJYaBTNsXDE6zgGb1hk+cqcTa240VhxMRG3Duj0mxdf4vn09t3u0nr+Cgs3I/oqZ5Hs/lGViYc60aYFFFoflgvaAw8arSaoAjHHUrdJOaUZdrPFHKxgUWjJBTKSZ0ot8+wb8J1LbT1/TPvOjMRljw1DrCvOMSFHWZOROD0eCIgghuePh4seA0+1MoRTAvhI0mrxsUb68peOOR/PY4/+c/aRRDZl0PBijQv78csz52S8T5pVSQR9jUsuLL6ubgSqlqEdAGKUT/p7897/B7J7/YrN2GyGzNx0F57dF8AzlyqK5dPwbzsoGvxeDZkmf+Vh0nOmNxFjZa8SJkdINLzpfTrWXtDNYZB05B8CnGW8dlNDR2Z06cMnV/MvPIfnlYJ1cCFyCD2slAzH1jUysFK7LgCYsf3ayBkX6z9klKftuHN5UQ70MXnHEWSLflq2VBbG4uzGGHg5IptvAx57ZJ6rRia5hxtNweKo2oHU+ZS8XOBWLqRHurJ2RZOpFtypJ2NebdoEbuBR+wf0tHfaWtFal5CTX71eXuBIuDq9+W1+R3iY6r1UBvTHaY2pbKuAFDxgBv3Rv77Flri0TaVtQoh2Gt5e+vdhw30Ams1X6Rmt2O8Gnih93Jkr9rI409EPWoc4AlKLQrfWrrd0QfWHS1ACi+4OMdjJ5bUbrFsYDFggyhc/ELO17TnK7fe81r+ErffTvNHDbN+IDJn2t7Vd6k8Q/l1yM0HhuOvwbVnFbnjudXyWJpNKzvci1tj0P2D 3ufw2knZ oS1MElEImHngbIH7vBYfSxDbCnwkBqjJ1OSSvWJUNb2ZNcC2VYzqDVPhzQFWdSyQf5GuSxsAdUVsc1lzFjOnX54ON+M1o/XdyPNs4UyuaFgtKw00iY9eBsdIhJUurKxOXng2sBRRTlKKgckDDsW7RJfvKteiY+4GA1TZA39PRyTg4ljliQWhYpvPosw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000060, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 30, 2023 at 08:25:45AM +0530, Anshuman Khandual wrote: > > > On 8/29/23 18:02, Matthew Wilcox wrote: > > On Mon, Aug 28, 2023 at 09:22:48AM +0530, Anshuman Khandual wrote: > >> This just defines a macro constant i.e DEFAULT_STACK_GUARD_GAP representing > >> the default gap, guarding the stack mapping. This does not cause functional > >> changes. > > > > But why have you done it at all? > > Just as a normal cleanup which also improves readability. hard disagree. NAK this patch.