From: Matthew Wilcox <willy@infradead.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/mmap: Define DEFAULT_STACK_GUARD_GAP
Date: Wed, 30 Aug 2023 04:24:53 +0100 [thread overview]
Message-ID: <ZO62hWK7r1zc1xsg@casper.infradead.org> (raw)
In-Reply-To: <3622f8fe-00c4-298e-0b35-06bb61b92cde@arm.com>
On Wed, Aug 30, 2023 at 08:25:45AM +0530, Anshuman Khandual wrote:
>
>
> On 8/29/23 18:02, Matthew Wilcox wrote:
> > On Mon, Aug 28, 2023 at 09:22:48AM +0530, Anshuman Khandual wrote:
> >> This just defines a macro constant i.e DEFAULT_STACK_GUARD_GAP representing
> >> the default gap, guarding the stack mapping. This does not cause functional
> >> changes.
> >
> > But why have you done it at all?
>
> Just as a normal cleanup which also improves readability.
hard disagree. NAK this patch.
prev parent reply other threads:[~2023-08-30 3:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 3:52 Anshuman Khandual
2023-08-29 12:32 ` Matthew Wilcox
2023-08-30 2:55 ` Anshuman Khandual
2023-08-30 3:24 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO62hWK7r1zc1xsg@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox