From: Matthew Wilcox <willy@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Guo Ren <guoren@kernel.org>,
linux-mm@kvack.org, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] MM updates for 6.6-rc1
Date: Tue, 29 Aug 2023 23:57:31 +0100 [thread overview]
Message-ID: <ZO532zzLXSKvpvb0@casper.infradead.org> (raw)
In-Reply-To: <CAHk-=wjtBk23T4bsA4wxyogvDAP0mWmPPvy=qaMWsySM=WOC9A@mail.gmail.com>
On Tue, Aug 29, 2023 at 02:31:38PM -0700, Linus Torvalds wrote:
> On Mon, 28 Aug 2023 at 18:43, Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > csky tree, arch/csky/abiv2/cacheflush.c:
> > https://lkml.kernel.org/r/20230815104604.54f65293@canb.auug.org.au
>
> At least this resolution in linux-next was wrong. It would just keep
> on doing a cache invalidate on the same one-page address range over
> and over again.
>
> I think I did it right, but obviously can't test (and am too lazy to
> build-test too).
>
> Of course, it won't actually matter unless you have large folio on
> csky, which is probably hard to impossible to trigger in practice, but
> I thought I'd mention it if for no other reason than Guo Ren to be
> aware and at least test-build and maybe think about it.
As far as I can tell, csky doesn't enable support for HUGETLBFS nor for
TRANSPARENT_HUGEPAGE and large folios are currently disabled unless you
have TRANSPARENT_HUGEPAGE, simply because they rely on infrastructure
that's only built for TRANSPARENT_HUGEPAGE. We should probably fix that
at some point; allocating in larger chunks is beneficial even if you don't
have PMD sized TLB entries. But the motivation to do that work has been
lacking; there are plenty of more important projects in the queue.
next prev parent reply other threads:[~2023-08-29 22:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 1:42 Andrew Morton
2023-08-29 21:31 ` Linus Torvalds
2023-08-29 22:57 ` Matthew Wilcox [this message]
2023-08-30 1:33 ` Guo Ren
2023-08-29 21:40 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO532zzLXSKvpvb0@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=guoren@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mm-commits@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox