From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CE9EC83F12 for ; Tue, 29 Aug 2023 07:27:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CA7B280025; Tue, 29 Aug 2023 03:27:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37A3F8E001E; Tue, 29 Aug 2023 03:27:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 240FC280025; Tue, 29 Aug 2023 03:27:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 157488E001E for ; Tue, 29 Aug 2023 03:27:46 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C73371C989E for ; Tue, 29 Aug 2023 07:27:45 +0000 (UTC) X-FDA: 81176312490.08.265B836 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf28.hostedemail.com (Postfix) with ESMTP id DD606C0021 for ; Tue, 29 Aug 2023 07:27:43 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=vRtPLaqq; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf28.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693294064; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dQVt7ZAS3h7P9TWs6MRywImntPzLi7vWjCeWqczW/dg=; b=ztTQ9f0ZmPn2dLf+NgoO6KHI1CUBneChPJLftVIwBWII9WCweaKZZBer1ZQ82UqCIZjdz+ c0gVM8lTl7gnUXWtP9EaYXllVBt/a+TJH8ofUs5ogM4YF5JEcZ4v6/YobpliJWwOepy91d ixR7+qClJJ5J8nmrTkHRDcSKmIWeg3k= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=vRtPLaqq; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf28.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693294064; a=rsa-sha256; cv=none; b=wg/fBCPkXYOYsl/xgx/ayokB6b4ebFlek/8YniIW0ZDhrJuWr79GLSXev9NJ0hG6Lwr3il x7l7lUNqD5fuk7uVAGt6CMJy9p4/73DgTW+np5sUs2t9Cgf4AXOZqxpRuP9Qjn7vttvqml +p08hTzaUzInsY1BFrI44H6U4g/qgQU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8B9F62184F; Tue, 29 Aug 2023 07:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1693294061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dQVt7ZAS3h7P9TWs6MRywImntPzLi7vWjCeWqczW/dg=; b=vRtPLaqq11XecAmTHq2dlcBEu/g6yqdBioRszoAaLNULFSMb19oU7qqGZT+5RLT0dTCl/s lSFUCG69b9+dF7PAvMR/seI8n+VXJUKB8Ske1TiNs6BC6TJryS8nzrbdYPEonTxhj3cNZ0 ragBTYGG3uSYLX6fMD7g+XhiJe7VIdI= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7CF96138E2; Tue, 29 Aug 2023 07:27:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id D1wLHu2d7WQRHAAAMHmgww (envelope-from ); Tue, 29 Aug 2023 07:27:41 +0000 Date: Tue, 29 Aug 2023 09:27:41 +0200 From: Michal Hocko To: Waiman Long Cc: Yosry Ahmed , Shakeel Butt , Andrew Morton , Johannes Weiner , Roman Gushchin , Muchun Song , Ivan Babrou , Tejun Heo , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm: memcg: use non-unified stats flushing for userspace reads Message-ID: References: <599b167c-deaf-4b92-aa8b-5767b8608483@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <599b167c-deaf-4b92-aa8b-5767b8608483@redhat.com> X-Rspamd-Queue-Id: DD606C0021 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: qt81q3d6xhpoyyg8jy9773o83ccn3qzz X-HE-Tag: 1693294063-970592 X-HE-Meta: U2FsdGVkX18X5SSz8Ws90BfMTOdZexVT+fo2opOh4C3Vmd6OUZ1urUH3mavC3YHOsst5rq+7X7xQIUHU3978oHByr5i1WiE2SdvmudPIY4u+hGrn0H3XEXRtdtGjaHFreVAWRCdzXe8uYYrwi7JSrRNc57fSOHPMJUm0MRm65scHeyeClL+kQBc3m5sbCKmZw/smrzHfFOx77mG21KhRSGFYkzzada7NRvwM0qv6AQn/8SBwNRuiokY8pF1RDwsPWkSYE9g85v3kewIYwuqphMTScxSJhpxchJZkyv/Q+tOTLNgH7U4/dYv/DBeI2YtyXJRVoFc/9NyMGP8iODZ9KB7VewgUfTWEKPJ2njaT2jHNjMwdJR0qXGokpl2Na3+eVSJ2e2n6ag8jAEPMiV3LLqkG2x8ujG0iCFJPK76xs0taMp0b2siXE1d0nL5YyOoR3QRDuDzwfJk8P1R5wdcTWDqYwP8iOaJaGEy/iedlmQk4lfyb8fxl/nGJlvKoqR8zDXrMS4QVYtZjdhX+MROrdEpa3ttOyoibJCt/n61HOq20oWtkLpayB9ZC7YAAStQgZpw151JsOc9uzIO8NG/PclO9oLYQKyzIoTNIoSH2m4h+i5IQCAofchdFGE/omyGh9vVndWkBCmWnqp2DFPMMucK54xiemgomYx8thMxbeOpcnIBW62rE1FRBN2eeWRQJFQPtOaYxwEoMN50Ae53RGmnSyFnLAvv77NJhyzYQEKhD/peZepmpJWwBbQJidAejrxr6jddG607q5MzrC0xu9Sq4e+I+KWdu2gUgfu9H6U0HPZ3sP9VurrIvK0lq79nJZf1t744Uw/IdfWMwumyk1hemPU76jbL2l/pjnZ2V1lXDCMdK1SISD4kijWlcK+0yzQCytwm8jN5B7eUwxJuoBmxMoKgTZUy2AHWZOr83P5/tY2GUDCpvj56oZK9pZwV483qwKhPbqLsXQrUvMm8 u4SyYf2+ LAz9hz3FtF+h9V6hP2ISV2GiVvD5BzYdYP+SE+JX9QIAe5us9HfJlwIvUpP694oeY/2YFzEg9zKwUJo5bSgTN5YxYzU3mw6fVggEhnxcRpa3fhGzgXsRpYvXl9ZW3f5cMd2e7de6d+b3jQ187PDFhPNH22w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 28-08-23 13:27:23, Waiman Long wrote: > > On 8/28/23 13:07, Yosry Ahmed wrote: > > > > > Here I agree with you. Let's go with the approach which is easy to > > > undo for now. Though I prefer the new explicit interface for flushing, > > > that step would be very hard to undo. Let's reevaluate if the proposed > > > approach shows negative impact on production traffic and I think > > > Cloudflare folks can give us the results soon. > > Do you prefer we also switch to using a mutex (with preemption > > disabled) to avoid the scenario Michal described where flushers give > > up the lock and sleep resulting in an unbounded wait time in the worst > > case? > > Locking with mutex with preemption disabled is an oxymoron. I believe Yosry wanted to disable preemption _after_ the lock is taken to reduce the time spent while it is held. The idea to use the mutex is to reduce spinning and more importantly to get rid of lock dropping part. It is not really clear (but unlikely) we can drop it while preserving the spinlock as the thing scales with O(#cgroups x #cpus) in the worst case. -- Michal Hocko SUSE Labs