From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D900C83F01 for ; Wed, 30 Aug 2023 21:18:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66473280047; Wed, 30 Aug 2023 17:18:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6150128003B; Wed, 30 Aug 2023 17:18:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5036C280047; Wed, 30 Aug 2023 17:18:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 40B0E28003B for ; Wed, 30 Aug 2023 17:18:14 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1730B1C975D for ; Wed, 30 Aug 2023 21:18:14 +0000 (UTC) X-FDA: 81182034108.28.1E23417 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 1F00180018 for ; Wed, 30 Aug 2023 21:18:09 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="llJXqS/a"; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693430292; a=rsa-sha256; cv=none; b=QUO722grtRAgArtFvcf5cP0n5Z48i9Q23c77oT5zskCy3QYT3ZflN+kQquJ0zcV8/iIFNl /W5R16+0qzRAmRgPoBJvSM7VuJSdQg6XjX5P1dnQb/mVWvPm+b/m/vv1AUNJYHN2ioIeeV mMd/I4bUyb1a2mlNpWzcHLueb7bA6Is= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="llJXqS/a"; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693430292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wMEggmZxL4goGk4wIRAVlREtoAybKHItWmob2C6lubM=; b=5704pWiuS4XBt+Y8Sw0YUR48iIIiIw7rNoAto46/8iyb7AhbRQV9G0xNWKm695ggUaT292 P31XxW1CRs9B7Ezitqx81xiIZ72TkFASBZXocvTRLX5ACsSGQAnIUN1yddSEnOzxGqWfeg /g139fzO38DN7r45HcuEY14lEjAUlP0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wMEggmZxL4goGk4wIRAVlREtoAybKHItWmob2C6lubM=; b=llJXqS/aqU/78wYjuMyvbcGWf6 S/KvkO/6Ce2cTAS51CSTeEBsicD7Vzm3cAIWiBRFtI0RUFcfwCLT0WW3oWi96wAUBtgQYO4UMfZqe JceZLNrzFwRLlnlITHPjeDXV0SmeS5SWbiKmO4I58vv1n8itO02cdOsR2BEwcmQzn/beQgmSeuiBe ygBdX/R4mgrlRYoA3nQVmGUxhTy0lEvE6R6uDtIdkwc2po0Xo0W4dAOxJ8MEbRIyUmAhpzj2mGbrL g318SBKNpqf892YiCGyCi/OH899J2pjyXQax/I+50mdDSF0n2VSHRO+fE5A1fVOD78WCZ5LRM8njP dgBqrarg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qbSZF-00F1N4-Fo; Wed, 30 Aug 2023 21:17:37 +0000 Date: Wed, 30 Aug 2023 22:17:37 +0100 From: Matthew Wilcox To: Ryan Roberts Cc: Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Christian Borntraeger , Sven Schnelle , Arnd Bergmann , David Hildenbrand , Yu Zhao , "Kirill A. Shutemov" , Yin Fengwei , Yang Shi , "Huang, Ying" , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] mm: Refector release_pages() Message-ID: References: <20230830095011.1228673-1-ryan.roberts@arm.com> <20230830095011.1228673-5-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1F00180018 X-Stat-Signature: 9b91zwdrts945wqfzh5su5wscmu7ocqz X-Rspam-User: X-HE-Tag: 1693430289-401299 X-HE-Meta: U2FsdGVkX19mzpJoZnOa64ybawwS/CdkNkT6RRFz5smfhPF/P29nv3/5sK2lsphq8j4sVpTQZyCpW3LRIQu4DHcNKsRe+jIGUdcFW1K0kMnEnZ5jCjbS7QvkFS93z2tMWIg9BKdC+JypAEmgbVwq8jGpQryeaBQy8YtdYiuOUodgLfm27Q5WL8NeKEeckysoBsbiuV0RCdHjk/NI4PNfhaNqniWUbNezlo5Hir93+Z9gOA04ScQA0TIwwxTDFO1QX8c4aUNe6D6YcLxExth1CxJf1UYbuQ/oCI1Wamf13ocRp0zm0W8Oj2MJ/RjHcQ+Uj0g7f+K7c64Oq68P+jF4FpY6Rx7F50c38v9nC7xrH+jmbzV2QtJQnuPrF929iS45Jd/K1Xas4mRsca7odIJX9bvP64DhWXeGaK5Ew/ZBkw9IHqWsouoNaQT/bXZAgRyZG15VdVBsWm13UXkXc8G6JfQos5k6NUdSnU8vu2OB6NzBzUprV57sJyKvEjHRK/HDeKj1O6FQiFZwat91VPY7vYS0V5ndr2JbgBcoxnNmMyVhgLklkvwYAsM3wTPgQUbPRmNPqREdX137vdE1ZN6MfxBjLtWIRB5CEyWPRRp83HSUdQyIH3HWoNnI7pdWSSBNon0MpiS9jYmbabDtit3+YdGAqqdM2rqrUjuRtZLvv+r0t2ZUxCBvmY7JweQqnIogJePoziY9krHOfg0u7vOKVJNYPx26jaSnEEhOAWYiAlY4/lv6GKPQqHeogo2DurlEL9I8DD4774lN1+9fQCRMIHcuoaKkyr/e64Hvc9KqV/RZ3nCmGC+1inRwGhWxyWCDIEVl9S3SRk32yzbzgjc0U55AJxywOxUBHmFdrCyfYFhsz7EnN6nVlJpaQzcfRo7KFk4wEyWAblpnvQwPjrlQZ8yiqTucHqOAkXhICV41L3XX6l//iFPxU5g1/sw7oSNjFgyGWPUPwZ5o2UncsIf 5hEkCGJU qat4ZMNJJgolbk5+cIovbgnzX4Ox3H7mNhVTy87mOSfNhEicQCtCGHPxhZUnIAh3IJWOvNwl0AummFhinMtO7ISqmVrmZln+VnLFpy2HyRIDlIXjcZK9ys9e3+RMjzXnRcfANMTnc9u0UhnHTbNDAxcGjKHcbKEE+iS59Fj5jWqmdIe9AjopRTt61eA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 30, 2023 at 08:11:07PM +0100, Matthew Wilcox wrote: > I'm thinking about doing ... > > void release_unref_folios(struct folio_batch *folios) > { > struct lruvec *lruvec = NULL; > unsigned long flags = 0; > int i; > > for (i = 0; i < folios->nr; i++) { > struct folio *folio = folios->folios[i]; > free_swap_cache(folio); No, can't do that here. Swap cache has refs on the folio, so it'll never trigger. > __page_cache_release(folio, &lruvec, &flags); > } > mem_cgroup_uncharge_folios(folios); > free_unref_folios(folios); > } > > then this becomes: > > void folios_put(struct folio_batch *folios) > { > int i, j; > > for (i = 0, j = 0; i < folios->nr; i++) { > struct folio *folio = folios->folios[i]; > > if (is_huge_zero_page(&folio->page)) > continue; > if (folio_is_zone_device(folio)) { > if (put_devmap_managed_page(&folio->page)) > continue; > if (folio_put_testzero(folio)) > free_zone_device_page(&folio->page); > continue; > } Must go at least here, maybe earlier. > if (!folio_put_testzero(folio)) > continue; > if (folio_test_hugetlb(folio)) { > free_huge_folio(folio); > continue; > } > > if (j != i) > folios->folios[j] = folio; > j++; > } > > folios->nr = j; > if (!j) > return; > release_unref_folios(folios); > } > > and pfn_range_put() also becomes shorter and loses all the lruvec work. > > Thoughts? >