From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 377A5C6FA8F for ; Thu, 31 Aug 2023 02:26:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C65D8E0007; Wed, 30 Aug 2023 22:26:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 576718D0001; Wed, 30 Aug 2023 22:26:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 464728E0007; Wed, 30 Aug 2023 22:26:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 393038D0001 for ; Wed, 30 Aug 2023 22:26:00 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5FFD5C04A0 for ; Thu, 31 Aug 2023 02:25:59 +0000 (UTC) X-FDA: 81182809638.25.CF04F55 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id BB42340007 for ; Thu, 31 Aug 2023 02:25:56 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NTE5rtIg; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693448757; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WvZo355H4sRaXT6dcpJuCYQoTvTM4NTFOhepAiKS2qo=; b=YcAapH1WI9Mn+3BYTJCtAkFpAQLttoAx59UY/UFR97WDR2i3KQICWHwimEuLIuwRuUDmer KtzXp/mCSAGTrBdEdydKABxDyF1TCt0hXqRddX797t2cjBCmk2AMnKWBqY32PwlKjgfPji NSTJMSdQaKH2GSJWBdgCHwcBfEiW7/w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693448757; a=rsa-sha256; cv=none; b=BMweXlnRsxebPpwKW9fExeYLsASkxGOfNigsE4WWElDeq/D8zIVdR6vDbt2hkbx+GoX0JG wLHBSnb/dxLNUAxhAJDHkYXJdWVMbLpPpWvn9Pm7+AZbFxkpOsmyahMfeZPrBanCJKsjwZ j3ZdBIMKx7e1KATqL2Fvmytxks3y5S8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NTE5rtIg; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WvZo355H4sRaXT6dcpJuCYQoTvTM4NTFOhepAiKS2qo=; b=NTE5rtIgr6W7Qi8piSZsGaq1TD Lofva6kduxuyWnvHtwhzt5udAdoWoquR7EsaAlyU+yr7L5CfJtaA2EtW6Dg8ZFGQo6+ijEoXKqePw PjaJ97avELLQKMiOGBiJy6bvgbxE4BsvksjDyneX6pOoFdHfJV39w3xB3Ktb+5G3I5K7Zkq14M6uF cPwA0Nrq4kPSzFLwS9JShV3fFLHsYh/ZASKvPKOCRCMuveZM9oWuaUccqHZkcLMuDF4C/hOkDfv2U uandfVcdzPCPr25SYRkHNOEsVTe5sHOA/KnR9kLCvqU/5rrNn5m2cUFXiivAvD5HU+pNVnBjDRDL+ CRYu2pKg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qbXNN-00GLLp-AY; Thu, 31 Aug 2023 02:25:41 +0000 Date: Thu, 31 Aug 2023 03:25:41 +0100 From: Matthew Wilcox To: Xie XiuQi Cc: akpm@linux-foundation.org, irogers@google.com, acme@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Yingliang Subject: Re: [PATCH RESEND] tools/mm: fix undefined reference to pthread_once Message-ID: References: <20230828122157.1541087-1-xiexiuqi@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: BB42340007 X-Rspam-User: X-Stat-Signature: e9huwaihkxeuzo4dxod8ghi7oabyrokf X-Rspamd-Server: rspam03 X-HE-Tag: 1693448756-725183 X-HE-Meta: U2FsdGVkX1+xCW6uHU8MNzMvOu8H609AnG4LnmzodAd4TkQXlf14DoeYf1yHTeT3uJDwwQCwzUBqdFMh4HGLDpDf+2HtDDGFbCaviilaxhC4MTMEmKdcbFi0d7mj5SW+PJlDTweDit81/fSOyIHCpjpxKGxW6J3jAESpW6Es4U0WdwGk8ZBRkp4WD0rft7S88mbCi8ZV8y8l5n3B5WBo96iU5Kjad6ePjiAXEPIqil1hIeaypmiGoco7+gDlrEcO/7oq/tnCYCxaCsl3+sYUeVAtnlTujmiCIHpywJ64VJUJZ4ySfIWMCRMsA1Zun1/k/3+m0oLewOn3S9tdstij9+iKtcC9nPBupZ7h3GSUMyFsZ+TtsU8DJiMhiKMA+bC8cc7F7JdjB6sqN3SiEoSLxdGuiBe4ZgoNH383S92FvD8kGuIxuPJWyhauTuAZddSo0F0Wodp4LfKG5nEPKQBweFM96JhZtC2qhTdHv9PmDSwEj9+01r7Rx/xFw65ZK7x89CJrMvA8UNtIxQ0Mudwu9WxpCeFVul/TDmgSJcjwSNQrrYgw5/Nc/qvO/N4yNHWaq1nD8KPCAfnvAf8WNEYi+gPiqjsTn1KwvaNyp8bqvcHpmkhCAmPrJay3pifk2F0s1uwn9DnxojHzd368u4tNiWdQSkjoJUtX9JLzUWLNwPzqOHwSCrYwe0h6JFbrhZCpjxG3fr4Qm9oXYhBpgnWk0b3nMS7pKBrRjitDMzK5MOCGF/0hST1L3W6ZM4/jYGOIpFYgEKeEKtK5L1TkL5BLKyjICnUFELd6CH84Zhzi18LhADEcWN888lLmAJO0S4aeZOFUIrjvvjqMLksnGozuENv5Gi5h+fAtGr0/8SapNoFRqUU6IzXlEx5ig0mSUSZ0h/16kg2x9olYptqtTxPQOogIq7KDOySWSiE5XG2eV2xqX7Nfuj1BIaSDvKvi6GtL+2is3hAJ/xB3a7xQO2o Y7JXu7Bs Zhw2VNECYgY438tKK4Rb2IlqBQp+GJkG2kAKc434ZnICySHy9Cd69vVN+T/NjirUTfYOekqJuCRGEsnrjFQ9DFE9i9EBpnPA1SQA4z6V96+rvjDzJLfksORI+VKwozKjOkxuliaVKP6JlP/5zJ3P32ItwrBdJQwuzeb9ifICvsR8M8eJ/E/9KXrLYwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 31, 2023 at 09:13:24AM +0800, Xie XiuQi wrote: > Hi, > > On 2023/8/28 20:58, Matthew Wilcox wrote: > > On Mon, Aug 28, 2023 at 08:21:57PM +0800, Xie XiuQi wrote: > >> diff --git a/tools/mm/Makefile b/tools/mm/Makefile > >> index 6c1da51f4177..9997b2e401ae 100644 > >> --- a/tools/mm/Makefile > >> +++ b/tools/mm/Makefile > >> @@ -9,7 +9,7 @@ LIB_DIR = ../lib/api > >> LIBS = $(LIB_DIR)/libapi.a > >> > >> CFLAGS += -Wall -Wextra -I../lib/ > >> -LDFLAGS += $(LIBS) > >> +LDFLAGS += $(LIBS) -lpthread > > > > Is this the right fix? I'm pretty sure you're suppose to use -pthread > > in CFLAGS in case there are other things the compiler/linker/whatever > > need. > > > > Thanks for your comment. I'll fix it and send v2. You added it to LDFLAGS, not CFLAGS. > > '-pthread' > > Define additional macros required for using the POSIX threads > > library. You should use this option consistently for both ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > compilation and linking. This option is supported on GNU/Linux ^^^^^^^^^^^^^^^^^^^^^^^ > > targets, most other Unix derivatives, and also on x86 Cygwin and > > MinGW targets. > > > >