From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36A49C04A94 for ; Wed, 16 Aug 2023 11:17:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58979280001; Wed, 16 Aug 2023 07:17:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 538078D0001; Wed, 16 Aug 2023 07:17:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FFE8280001; Wed, 16 Aug 2023 07:17:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 30AAF8D0001 for ; Wed, 16 Aug 2023 07:17:51 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DE8A9160881 for ; Wed, 16 Aug 2023 11:17:50 +0000 (UTC) X-FDA: 81129717900.16.64B3501 Received: from rere.qmqm.pl (rere.qmqm.pl [91.227.64.183]) by imf04.hostedemail.com (Postfix) with ESMTP id 91CBB40014 for ; Wed, 16 Aug 2023 11:17:48 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=rere.qmqm.pl header.s=1 header.b=Bz3QqekB; spf=pass (imf04.hostedemail.com: domain of mirq-linux@rere.qmqm.pl designates 91.227.64.183 as permitted sender) smtp.mailfrom=mirq-linux@rere.qmqm.pl; dmarc=pass (policy=reject) header.from=rere.qmqm.pl ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692184669; a=rsa-sha256; cv=none; b=Yb69iMyE7208xFaDPunBTWoHn9tuguJotjsmjnJrn3TRy1n4fFjG2qR0pVQj18O4DvsWUP m7RwLeiV4ywJ7Ck8CEvnMCmjtkdUMvOQIZKU62fp9hskbEkqvTcB4OG60du7SqWOX7VMJu qoip48PIYeJIn9CcBPD74D3Sy8lkJhQ= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=rere.qmqm.pl header.s=1 header.b=Bz3QqekB; spf=pass (imf04.hostedemail.com: domain of mirq-linux@rere.qmqm.pl designates 91.227.64.183 as permitted sender) smtp.mailfrom=mirq-linux@rere.qmqm.pl; dmarc=pass (policy=reject) header.from=rere.qmqm.pl ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692184669; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jrJbE9+qSL7IbBWVl5liDQCt6Ro4yqhrgcv+XgYwvMg=; b=SOaXduqSj3EEyPPIswqR7Cz1PgY2R/WPROkFtrDfZq0ESo3FpRVX8DxemuHi6PEyM+h7Zh Y22BPvvicmV8L5aVlUluP3jnK7ThCtSQvC8bRrcP8NxL1G1a8YOT4LybuYKJb2J4NkGoMQ n1t5LOfbfF1wBtH6hH8FVjRWQo8SbuA= Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4RQlwm16hDzBZ; Wed, 16 Aug 2023 13:17:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1692184666; bh=HPTBh1TZUwpwJ0n8YtW6jDQsKC75wBbqafxnMaIb2KI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Bz3QqekByN94TsO/Ae1JtkBo7JvQmNeBGJdzyp82ZcYrXVAD3o1/wK2vqqtgsrOpS MpHBUyxJ131EOsBk73z4kk1WWnpi0laZyz2I1c1rKViRIIpupwObLsYN5ZmMc9Zm/n 7zDKyHhOUHQUcFIWnX2YNZRtRRifZGYN3D2QPmXJFY9peFUFG36hiDc8DGYnXn5U7G WlRPRqrFTOkg6rQd+pkcoDRhfWawRe7duUTX45D78IxssuT4AnN88fiLnvUsezGlHu JZL8yfwboMeMhWGdXhgej4uz8l8Z4BZtmiM/NrAH7vjKdKPWmdJe13ykpj/jHRA0NF It04xWcjCCRrA== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.8 at mail Date: Wed, 16 Aug 2023 13:17:42 +0200 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= To: Muhammad Usama Anjum Cc: Peter Xu , Andrew Morton , =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= , Andrei Vagin , Paul Gofman , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com, Cyrill Gorcunov , Mike Rapoport , Nadav Amit , David Hildenbrand Subject: Re: [PATCH v31 2/6] fs/proc/task_mmu: Implement IOCTL to get and optionally clear info about PTEs Message-ID: References: <20230816103814.1522393-1-usama.anjum@collabora.com> <20230816103814.1522393-3-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230816103814.1522393-3-usama.anjum@collabora.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 91CBB40014 X-Stat-Signature: 93g6j9ednwre1xywi1hseufafzbus5bp X-Rspam-User: X-HE-Tag: 1692184668-146523 X-HE-Meta: U2FsdGVkX18cBLLPtp03Xf/8FphzETeB5xUEIu6TKbERcVlzoqGSWT98UIZK1bm6FT2foVw1I43Bqoj3bt8UCOOv42se8nOWLHGvBJj+gWQc6+RYEoGbvitfLo8UnGAhGUnX2Y/jHaZbpVJuZs5/kVtfn+FU6Ce+kVpOL/2f6kIIjqLVqEA4RHOb4GD5JjSxIK9ZQILd0Ywsh4oj6o+oQ+1kRY0hqQbTYDGLUvvbYiwBPqbdjZoHZg1n4eTzJ5NHGcmeu985Qz0EOMjchM/vrV/56VlKcgoIsYPHKCbRC+slKdvc+dMAr9COufdrW2s8TF5/QEU2nyya4aGn4eLdoh9xrEmdihgkjHVvsUnbWU4uHVSMqyO1hYp00GwcavAErCUuOzFV4CmpFF/o8e8pzHLLtkZTCd/hgS6pZb7KWKoiApdnlwXa2mKQjHFthYhlyT3z6mxigPOa6G2awVoIH+GcG7W25o3V1jApfRIC+dMs0PQP8P+J1MQFdrcJjARB3eBPoMlT9czRg3kMUQbGUKcitBAehCS1d/YJRcGXn4He1Eqqms4xefuooU79JqulDFG54bg0l4O+4PPMgmISqe1VIahfcoUJQj4+W1j+5cNUgbeEo2Ykv4KxJzEa+G36mWPQgzHbHg8L3QmBdGB+NrJ1XGaGW17gMWsZYt9zGOkPn/t2zIzK6uhqMJgB+gnjXG9ghQkGNG2kx4WUZ9fwVRS70wwcb+b8wOVoQlj+YeVdwG/Wie+Ufr6eJ+NVwiZNaGkvrQwq3lcQpSCMcr/xNzs9JbehMeD6Y779SkB39bv74BfBI2W7H5jhkJXBGmuzBc53yxRy4RThLG6vDyM5qMvBv5odo9zf/t8VobqNNQf3UyK/lb2WmBbwK14lo66tkIPCLrdPsVNzrBeQcoHL9LAgsdtPkhuntLBLfHbjK+La2PmduqtWV3FRq7pUqZUSYn/4if62LcygBcMspat 0V8lnNxy KeeG7spK1Psr9Z86sguo9UsKwD6jRq1g25e/21R/pDGjjjxnmuSSsWgojVbzAN7YFP9FQIhJlmaljt1j5xsEkS96SJ1pS6HiI6h45g0v4gGYTW89ms9n32X/H411ikVdTCmnsNACw2CyhiXc15yGArQVpUuKOoL8qkGdZDqHM75OHcHovSWX/eqeONQmHsRUG103W5HQxmIeGsnjJXj0XH27GMwSt1QKd4RhkKLTgt6U7UUtjEVUAD4wIsg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 16, 2023 at 03:38:10PM +0500, Muhammad Usama Anjum wrote: > The PAGEMAP_SCAN IOCTL on the pagemap file can be used to get or optionally > clear the info about page table entries. [...] > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c [...] > +static long do_pagemap_scan(struct mm_struct *mm, unsigned long uarg) > +{ [...] > + for (walk_start = p.arg.start; walk_start < p.arg.end; > + walk_start = p.arg.walk_end) { [...] > + /* The walk_end isn't set when ret is zero */ > + if (!p.arg.walk_end) > + p.arg.walk_end = p.arg.end; This is now redundant with the `if` after the loop. [1] > + if (ret != -ENOSPC) > + break; > + > + if (p.arg.vec_len == 0 || p.found_pages == p.arg.max_pages) > + break; > + } > + > + /* ENOSPC signifies early stop (buffer full) from the walk. */ > + if (!ret || ret == -ENOSPC) > + ret = n_ranges_out; > + > + if (!p.arg.walk_end) > + p.arg.walk_end = p.arg.end; [1] The one above. Best Regards Michał Mirosław