From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8107FC04A94 for ; Wed, 16 Aug 2023 06:46:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D00B08D001C; Wed, 16 Aug 2023 02:46:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB0078D0001; Wed, 16 Aug 2023 02:46:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B76F98D001C; Wed, 16 Aug 2023 02:46:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A83518D0001 for ; Wed, 16 Aug 2023 02:46:45 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6A9FC80E48 for ; Wed, 16 Aug 2023 06:46:45 +0000 (UTC) X-FDA: 81129034770.03.1B14137 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf11.hostedemail.com (Postfix) with ESMTP id 874C040002 for ; Wed, 16 Aug 2023 06:46:43 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="J+mq/ar9"; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692168403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+cWEnMzABAUhWZyHuEVUH87lQaPUcTG3DTD7piVJiYQ=; b=y7iO3b9aA+rw0xWJSDMGzHyThRU4uPLbWVcZBLGXbzSa8s2U5uTdkH6JRiOJBU01An6NKf 4przIdMBsjQKS+jnrPoRuehlZoTcq8mTHQsvzzlyHH+GsEBAPDeIaZx35N9GDzTRTD5vbB DRlD8xS1LeiTPKoEdqDCx4zUBefTgcg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692168403; a=rsa-sha256; cv=none; b=hOZ8qVPZN+XOytsYw1gqVEr/Es8iEjBC9wuxU3y7EX0bkGl6ENgucy4A4EZqw2hViMk0yR I7B8722jFX7GKUY9AFHLnKG5kzV4kdnBgLRQjq04HVi5VNvmDbd3uaUwbbM2nQxNad+4uP WpLKXJxdWTh1UpdejxP059BpawStiSs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="J+mq/ar9"; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CE1922189D; Wed, 16 Aug 2023 06:46:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1692168401; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+cWEnMzABAUhWZyHuEVUH87lQaPUcTG3DTD7piVJiYQ=; b=J+mq/ar9fFEbj29oumBleEFn5MNWpMAEvQPqpPG7rAePrWHZhU5znBTjkbPEQt9rjb08Qn hXLPVMStjYEmRLpV4O8IdWAsUihnPKlFI/deoB1/czHFxbniola7IuW8ON3X2XSRaWJiym oa7GPKbERzAQ4aU065qxqCvsTGgS8Dk= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A9F81133F2; Wed, 16 Aug 2023 06:46:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DsJxJtFw3GR6egAAMHmgww (envelope-from ); Wed, 16 Aug 2023 06:46:41 +0000 Date: Wed, 16 Aug 2023 08:46:41 +0200 From: Michal Hocko To: Peng Zhang Cc: linux-mm@kvack.org, shakeelb@google.com, akpm@linux-foundation.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com Subject: Re: [PATCH 1/2] mm: oom: remove unnecessary goto in oom_evaluate_task() Message-ID: References: <20230814063428.4111206-1-zhangpeng362@huawei.com> <20230814063428.4111206-2-zhangpeng362@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230814063428.4111206-2-zhangpeng362@huawei.com> X-Rspamd-Queue-Id: 874C040002 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: hdain6r7s7mjuepyir639g85ardnytad X-HE-Tag: 1692168403-279242 X-HE-Meta: U2FsdGVkX1/9b0YlUyxCrIa0u+A8aIHKk1NRZm2f19M6Ry5KltLOsWBgwAupvB6F0SxjkSQ0yo+B3p3tfASlPoKLM77KyTdSu+UXCIot4+n8dbzxr+rZuoR8B6TKw1ib0GdTVSY/NjTdoO0ggIMfutDQ6/xEB6apNQXX49HTb/8Fi2I5paqOklvhEHj88eEyZ4Xsgo7PGkNMroKaNT1cuIVm5lALsmflT4ZMcv8733QIcgIpZgZsBPheY/aoieOc+ovbR3ayI4XRaMXdwPKmk1LOxdPFPbx0EznaDrq0725EXYhPwfMHgtLa40lqjITgUnBdWKhwIcLt76nNUaJYwCduUMCCCwj6bJKzpRaCVYEzvqrk3ShRypbCty7FDXxpkwDYPLlROkgEZtT+/4FVN1WvuZV+YWDXsM/APpJP9ULob5S5Lju3vuepL4YeRXNuFJDorYs3Die5Obr/avPK9XTLoAoqY8RPKlm3WJTOeisU8we9gVGMINCinhpTc8Wm3gAqmwg3CLuK1ljQpd/7vq+2emuIGq135YVShSsD1rF1N6FZ3XnPpGh55/UOIP5r4/4gvySHe4gbAQzHDrYELyyk9JsTChRDr7JuprGhYrX3qP0tf3i3NtWeItxC64xQ9M06n1w2n+CAS3awJRnvjtnUbqGhjZsKaOzp515s9cYJP6tXgSd6Hf+IxybB2QbjfarV/4ecBm7F5ZCjyjBuJ3LcyuAHHgJILKMGuEUzYTKtTmgNs1eeZqbZeaC+Ifup6XqL22JS2AaPPMRt8bCnAfuvsLAgmVwytOYCS0zDI9+xsVW0qnXSkagKY+lLO54ypnI7tUaKxiilLHPJJAeS6+gYKvfFUdrgFwwntKUIS4oi4U1HPw24WISy/fNhXVIrdSLAPjccpUiBR43zSp6ctGvZyZizR4eCANnV4cKSmwopX7efU1uVtI4d7IaZLQYhXJoFrhMJmsPm9RJFNb7 PXNJE9Zj 1TPnMM6VGqsm/ZbDTJqq6PCE7VHa1WaicNe2iJHtxrmUPHysKPfKPkumWZGRgr7ZAY79uZr8l6RnKn+HN4W+yuJ2rdE5GH1hrF9/SvTZONXzCfWWpN+2JhizdYdHgDIXyjs0km9fCVf2BfcZGxr2ZdmaUhERvP2Gp9DP0dlaqAnlsU0U9eEKeyyfRT9Wvipv11Um+5tq5lkRhDnpDVUH8bSdB+hVViVHjdqoyXTIWIW5eaCbHAcnDBOavXFqxakbrTZ9VYucLOl1D+QnTN6x9CcFOIfQ0pFiY5PCmS66AHs22g7LdHylBZVBDCi0EaRFmu560o/SJtWXLBu8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 14-08-23 14:34:27, Peng Zhang wrote: > From: ZhangPeng > > Remove redundant goto statement in oom_evaluate_task() to simplify the > code a bit. No functional modification involved. Quite honestly, I do not see much point in changing the code this way. We still have other goto labels and also there are other changes happening where this label could be still benefitial [1] [1] http://lkml.kernel.org/r/20230810081319.65668-2-zhouchuyi@bytedance.com > > Signed-off-by: ZhangPeng > --- > mm/oom_kill.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 44bde56ecd02..10f7826c4035 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -335,14 +335,12 @@ static int oom_evaluate_task(struct task_struct *task, void *arg) > */ > if (oom_task_origin(task)) { > points = LONG_MAX; > - goto select; > + } else { > + points = oom_badness(task, oc->totalpages); > + if (points == LONG_MIN || points < oc->chosen_points) > + goto next; > } > > - points = oom_badness(task, oc->totalpages); > - if (points == LONG_MIN || points < oc->chosen_points) > - goto next; > - > -select: > if (oc->chosen) > put_task_struct(oc->chosen); > get_task_struct(task); > -- > 2.25.1 -- Michal Hocko SUSE Labs