From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84108C001B0 for ; Wed, 16 Aug 2023 05:41:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9606280005; Wed, 16 Aug 2023 01:41:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B481F8D001C; Wed, 16 Aug 2023 01:41:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BF24280005; Wed, 16 Aug 2023 01:41:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8E4E78D001C for ; Wed, 16 Aug 2023 01:41:35 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5B1BFA03C7 for ; Wed, 16 Aug 2023 05:41:35 +0000 (UTC) X-FDA: 81128870550.07.D86A8AA Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by imf18.hostedemail.com (Postfix) with ESMTP id 480421C0013 for ; Wed, 16 Aug 2023 05:41:31 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HIQyv57G; spf=pass (imf18.hostedemail.com: domain of yan.y.zhao@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=yan.y.zhao@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1692164492; a=rsa-sha256; cv=fail; b=qpcbOAWv2+NoPoyQ3gdNIUsTMIqI4lPP0p2CdPprdp/NKtOlq1dOu0VR+hXxna3+ZUowZZ QAjWOsCP90p+b0wV9QNSYIA8Zb7BRc3L4DGAggKTh4yVKd0ui9FQUDWKqzQ0XaMkUh4Bpu IT76O3IptY8bNqBgjy0bA5ZqyjYz7ok= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HIQyv57G; spf=pass (imf18.hostedemail.com: domain of yan.y.zhao@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=yan.y.zhao@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692164492; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=arHs/7LnORDXuRiaBFWp/1oH8EwCGJC+pnvE8VYvTYk=; b=WY03FKatFpyHb5E+Po7rONJDbuzLGC+hULBjwoBfgFAP0qVL+i2eGLIvP+/Zfplof8CdHE SYqJNK3TPGs6QByrZ1jMF+dR0w3DK39qSpabM+IRCGMTIPeXtxWocp2hDXZLpd5KYBK/bz JD0vC8EOMImP92NWMRrOy4kuMPf5WFw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692164491; x=1723700491; h=date:from:to:cc:subject:message-id:reply-to:references: content-transfer-encoding:in-reply-to:mime-version; bh=iAd1Lj/9A5FKiL2ZQd5eFHUWfaPQraeJaHf3/5mxF4c=; b=HIQyv57GuuCRabR/CSkuUPeJKr0jndqrnH375Y9s23+bKInAMT7PjWAz 5xU0yoEmVp/CY3xNYJlvyWMCFHL3N6G2ha/hmHuU/YlM+ZS2zj5orCwkd 6LL2FSc6Wlh0JEkSU44WKEk6VCpR9lL8Gm3DrwVZIu0ms9V+x+BgdLH6i U9tNSMRFpttJyLXpX6LZMl4zxofojQOkB7a73V/CCes/rlYWfLgw6Ajfs N17Hp/uziSpfWLQ/czzRmD1T/Wjc3gMbBrlypLF8zUBJASAXB+QcyM/lR pRECfh3h2Imv7O790qMzbE1DID02RMi1/z9Eudvp2KW/UG4GruIJiFdqg w==; X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="438791145" X-IronPort-AV: E=Sophos;i="6.01,176,1684825200"; d="scan'208";a="438791145" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2023 22:41:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="848349662" X-IronPort-AV: E=Sophos;i="6.01,176,1684825200"; d="scan'208";a="848349662" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga002.fm.intel.com with ESMTP; 15 Aug 2023 22:41:26 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 15 Aug 2023 22:41:25 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 15 Aug 2023 22:41:25 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 15 Aug 2023 22:41:25 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 15 Aug 2023 22:41:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UqfOjydtXdpcIbP2Dsby4s5+VJrUlQHscy/kRune3w/Z7esaRezFromzAbidQRoZsP+G5MRwqXVkKKxM9Gih8Uso+A+SMnZEFzUOXvo25pMYszOAuthy7+pAiJZNL13J83c+wGgbNYAgkrfbMziIuMVhzBBF3nEigA++N/yYdpZYvMBERKahinHrang9YbFKL9pEOlGT1R+NFMHthlgks8VawW6E1fRY1/CDRfPChSObVFJOxJevspRHsCanr6W1JzO2HQcxDOWMX+RTx+Xz6Rzdgml9xbVHoSBnIfzDUELKC34NBcWdZz/4tqTHPlp0RbiPKG/0HrNqYbUtghrHbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=arHs/7LnORDXuRiaBFWp/1oH8EwCGJC+pnvE8VYvTYk=; b=RbLT5GawYum0KyEDfwDcVR3N/u78t2i6dYjVNjLdNBmuhDprR/zgDx7T+UHg5l3DhX1DLARfhsGFiEy5atH4MnklzcmQoBupzGpyFGWq3zHDML0hyBvlz9/nfb6fMQa9nlia8EOL8lx8zUWBeFZ+qQu0mvR19oX9xalP9jR93O1DhYbrZ5sXgpt3+gGFjT2slHnflMYOzRUXmwDgZKREvHSNtCOHzvC+X1ZBK8MdKg9RrNn9Ap2enehIoVt+qNhfdqvMG3kfwdFxUKLxKMO+gjaXB3XvxX859zzUu5FfLWgoaguiddhPfb9VSagfqW5NWBqxvIMutqmRK1qsTaDZfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS7PR11MB5966.namprd11.prod.outlook.com (2603:10b6:8:71::6) by PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.22; Wed, 16 Aug 2023 05:41:23 +0000 Received: from DS7PR11MB5966.namprd11.prod.outlook.com ([fe80::1b1a:af8e:7514:6f63]) by DS7PR11MB5966.namprd11.prod.outlook.com ([fe80::1b1a:af8e:7514:6f63%2]) with mapi id 15.20.6678.029; Wed, 16 Aug 2023 05:41:23 +0000 Date: Wed, 16 Aug 2023 13:14:20 +0800 From: Yan Zhao To: bibo mao CC: Sean Christopherson , , , , , , , , , , , Subject: Re: [RFC PATCH v2 5/5] KVM: Unmap pages only when it's indeed protected for NUMA migration Message-ID: Reply-To: Yan Zhao References: <107cdaaf-237f-16b9-ebe2-7eefd2b21f8f@loongson.cn> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: KL1PR01CA0095.apcprd01.prod.exchangelabs.com (2603:1096:820:2::35) To DS7PR11MB5966.namprd11.prod.outlook.com (2603:10b6:8:71::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR11MB5966:EE_|PH8PR11MB8107:EE_ X-MS-Office365-Filtering-Correlation-Id: 62a2fc6f-034d-44b9-61cf-08db9e1b6ce3 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6SdqYN/I8ZFBplJ9qDrDKbTeWMz6McFG8CB09yqX9vRlIGm6o6LCvOcGOeGGenltwgXXKrmvqKiPqUswMzOe0gRPYDq035VGLz70kPnXilK1fc5SbMavhhbHWf49Owu+HrfhCRZ/Rl4yk3qxKLTpGo1voPnbGTjiH8ZJlJrJFRIk+mpoxGq3vm6sJdk4E64P49go5tkFSaZXbxOPatkT5SbkIUBqW8yMcVmiOPVFqt8bY3jD0qJrl1CeX7+RZJDC1xmTGQAW7j/ftqIFeRNGpajHQs5iHbxY+KS9vbtBzkWJXYrPPSr0elO6eV1Hk7NvPFR1RkJ37CUQ0u59/LX5hXweH7+/BlhORhiC7Karg/0sxe4Okvvq4IIJF5FtEU7WeUSp6FGYx4IjGBwKWRJfnyCgBitcEuxWlqgikZjt3AaCZQJCnFdM6S5NXVj4Zvq5CyBfE4f1zJDbblZWLvWJoapTp8ldfihrewT5a7TzcBANEQZDN+QndIetAOOCcm0b+7amkRlSAEx/ZfP1a6Fcv9R4EwruQRsotJe1dek7h7Acf0B5MZ0l4D9PU09DIQs9Zz3kcEQsb7khzO8t0sHXwQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR11MB5966.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(366004)(39860400002)(396003)(346002)(136003)(1800799009)(451199024)(186009)(54906003)(66476007)(66556008)(66946007)(6512007)(6486002)(6506007)(2906002)(478600001)(966005)(26005)(6916009)(7416002)(5660300002)(83380400001)(41300700001)(3450700001)(316002)(8936002)(4326008)(8676002)(38100700002)(82960400001)(86362001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFZmNFRWTWFWU1JaRFdTQ2lQY3BDSTcxOWx3am1mMzJMTzFxTkp3LzYxN0Fu?= =?utf-8?B?K3NtaTE2b2tQTVA0T0w2MkdGai8yT1RmWXoyTGRsYzhwSG9oZmZTdm0vbTZy?= =?utf-8?B?K2h0R0tUQ243bnQxaTFQMW5XdG1MU1ZKTHN2WTNkT1FhWmMvVU5RS2Yyc0Vh?= =?utf-8?B?ZEVzRjFOWnUvdGZsS1FiRU10WHZxQmR1RlBkNGl0KzZtWFl1M21KSGd2dWpQ?= =?utf-8?B?TUdzaVBybUZHVjEybHlxNEpjaWFZL3V0VWJZLzJNUE9wSXdVQ3VhTWlFME5V?= =?utf-8?B?MVFISkJWdm5WdXptWTI3Tnp4WDZLWmc1OEQ5OEZFWlhNQ3pHZDJTMCtYQ3NF?= =?utf-8?B?WHVNRDJDL2liemZUYjRxbTJjUW90Q2lDcmV6Kzcrbk1MTXE5MVM4WHdZK0hl?= =?utf-8?B?aXdFMUNjdExqRG9uc2pOZmd5d0g2Q2dyRWVuSHpPQkhZQThEMEVYeVM2TjZ3?= =?utf-8?B?UVVMT296Tm54OFE5cmhiejcrdUd6dEdwY0NnRXRXK1VMSHB2U0QzWGxLVWY1?= =?utf-8?B?S2tMOUNaZmIzZTdzd3dlbnN0WFNTZUptWi9Cdk56Q0xtTStvR2xVZU0wQ1oz?= =?utf-8?B?eTZXQmJDUlpXR29FMFZicEdVSTZDUWNSN1NzMnByNlVpbGlTMXZyVDhPNWRq?= =?utf-8?B?bGxPRnRlL2lCRmkremJIOGtpTUkxMnR3dVlPNDU3OTV2OFc4eEFEdzdRUVc4?= =?utf-8?B?eWRlT2EweHc3WVNkdEZMSDNzMUR0OUllcTBzOHNEbHlpcks5K0ZrQWdEUjRa?= =?utf-8?B?WXBRN0p2ek01dFkyOXN4YTZ5VWVQeTFBY2phdzF1blJYNEJkWXRUMWtZemM1?= =?utf-8?B?Tmp4NVJqczl5b1dzMElvVk92eWY2VVNQeXl5VEZ1aTBXbldCcUtXN0VpeWt6?= =?utf-8?B?QmpqUWlDenhFRVVsQlNCUTh5U1pzOURCOEVvRVA4OEJlam1aNUgxWFRhYjBN?= =?utf-8?B?VFdlMTVocHgyYURlWnBZQlRoaFFqYkp5eitDMG1hMFZLMGVlZGtTb2Q4WFNM?= =?utf-8?B?N3orK3pzaXV2Y05XVDZEV21WVUlLYkRzeUg0QkZtQ1BxT1FVM2RFK3JraEZV?= =?utf-8?B?anBIQmhBZnYvTExIMmJXdnRTN2VXNTVCMDdFWkwwTExkc0JtYkdWZ090QnhG?= =?utf-8?B?cTBnR0FnQlBkTDYyMlAwVGIwNEY1OTJqM0Y3aExpVGFWbTJ1ZytMM2t5VTc1?= =?utf-8?B?eTczZWhKY2hvcmhRZi9JdzE5MXFLRFk4cFRnYzBsQVBDNFMrR1lYVWl3QnVQ?= =?utf-8?B?ZXRyWHJuUDE2MURydCtFRUJVU3gwTEhDMHdXUGFzbFdHUVFZUUZ4OWNPSzZ6?= =?utf-8?B?RVJoTkJvQnNhNjRwR0NadWtENjl2Q1pIR2xWWVk5RGE4QzZSaU9vR2xzTU1T?= =?utf-8?B?aEdodFM2NnNwaWxwMjNyTnhPSzQxblNZZlNXZ2hGTm15OElRZklRNG0yOFJW?= =?utf-8?B?NEg1enM0TmpXeVExRU9RL2pYQlNLbWttQWJPekZKMmVibnVickdyYitKUEJl?= =?utf-8?B?bDBkSjZjc3U0ZHZDc1puQjdyckdZQjAwL2JxQTJJRkp4QWdCTkJ1d2p0QzNN?= =?utf-8?B?YW9IT2RCZlBidUNMYU1yazlpek9vWUdGTkVxSXNjK2tESkkxWUs2cTdRRjZs?= =?utf-8?B?Q2ZabUJianB3anF2elVMaXhJdU14VnZWSnNKaEdIS0Iwanl5NExlYnhEdW1Y?= =?utf-8?B?SjVKcXZxT3dYNXl2RGxRTndRRHZOdXFIQyswWk1qcnJPTEMxb1p2eDY0V0ZI?= =?utf-8?B?eTVyZ2hjempOQlNBQ2tCek12QnFUWUE2VmVDVlFuSjJpMU9qT2k5dkxUTXYz?= =?utf-8?B?d25GQndYMFlzTnZkQ3FWUWlNcStidldRL0VWd2hFUjdNZDRKREpwQytpSm1B?= =?utf-8?B?cjh4MU1XdUdwRER3aG8xdFhQVHNoVTdkTElPWFVhQWpZZWFTQ2Q1Ym1paGFJ?= =?utf-8?B?REpzeUgzMWVpMlNJdEtrUDQyZ0duNC83ejYrZGRHZ00rb3FLUGdqZ2drbWxj?= =?utf-8?B?NGlzZ1d5Mm85YnNrOHRxVW5NV3RPcmtRcVVPSEZNU0tnaUxTNGNMd1ZyaVZD?= =?utf-8?B?OEpZdkJVYUJEWTIvenRrN2xvNm1oVnp5bnJ1Qm92YW9ybURydVprbnJRTmlX?= =?utf-8?Q?yVLkTQTQqa3u73RCEp8tQksXK?= X-MS-Exchange-CrossTenant-Network-Message-Id: 62a2fc6f-034d-44b9-61cf-08db9e1b6ce3 X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2023 05:41:23.3341 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vPOFnyGgN9UWAxwVxK5sCPxrGWyr1HDDdMPtPH52J1RVzusLEuHvZO214yfiJaqWbwNM9R01ls4uRVXBfdCL/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8107 X-OriginatorOrg: intel.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 480421C0013 X-Stat-Signature: qctctu1pagshfk3kf81qzeffz3wk7mr5 X-Rspam-User: X-HE-Tag: 1692164491-125298 X-HE-Meta: U2FsdGVkX19yfj/jsGfZwjh9JOpHp5WhZ29W6GFx/BJxJOTmz8p/kru9cO1khBPlyrnHqtJprUOn6K57FUdbi54Ih8JMPYBTK/Kwwd9uOuvVL/5xw24crYi2L5kD3ItkFEW9EoH2XoHzuX6kzqWeFpVuXlaW3FL+nWd4aS7+wWZmfa9yo2tzfpQusaH+KS16Lh0mr7qSxT7vQwMoZgc5FeNPr3MvDu20smsJV4yoE3JwjGZ9ullSrfjEUXvzWOdZKdagm6CaV9q0HzVGUN4zGrINqASk+doCCABsafawDjJfpmZX2DIHnP5eZDjFWq//7AaQDrF/rbh21mv/TzMJn/DUzzm/sIDQn4uuW19gB3qo/w8bro5FW5op/7p4fv8LdcoYrsymnz/Z+X1rRC+4OfN6V6KKicP41rQh6oa0brohERYiaRPyBtyTziI2g0t3E1hV4uLxyVos4DrhqiyGkXbcUkMnutc4PJ7aAAw6cxoI4cF2NsTQeZmm73j34l3cjeSdZRHtI1vH8oQIz/Hh9g9XgARYhG8vzhpIclE9+XAINYoPRexIgUmkKwKjWzKewCHO3paT3p/gAKzmkk89qpg3/cKMtCuO5nR389jsSglvSJUOLUcZ9vDJGIKK+ePMxZyH3oWkeqJ1Ic8vriFRzasxVel0cwAVrFIbRSTtVd3oOkku/ishnVTyb21m9XqL6uSzk2qpljd/jxfSV3SEa4uHycYw2ZhW3/bSyk5S2swQUxQB0kiSJM8tF6Xld0cf/L6VsaUYn9qwihZXlcH6O8CRtOIwJdBri5v7FzaKx22JX8iuRWHrheeEGODNxS9iz+5p2vKDQSWYmWnJms6bx14V4A2aKA4Z5TuABVsFyn6RtL9AK2Of5NXbk/tSItADveusZmdcPAho3ObJ9FpMg4nkTvQ6TTD5lylT2ftAKnveCs/I+hQ/lrvseTm5d52ovixp0LcgxWZXSTiPPrQ niuGkNPO PM/0bkylVK9Enc1tYrGdlru3z8by9wau3mPbuXzZQTHLjw5BZ23AsWDzcAxP8oPXlS+tCQ6UU5A3/lRDvqW6i/whlLcvjCqtHDf1IBBOZwtw1d9NVMvueNA5DrM8bxRBoUtZd/hopsnqOvjA9xI/RPmYWhZoZO9AAuk2HsAF7Z6LdOMnQzDvx9EFiTHUyhDHCx37PKMnFzCcMBO1y4H0qQcYLXGrJgReQCizHlb4NX6555Tv4kTNI9p9LFQ252SRmn8FsxBmeUDvnnAg0B9UPsnOr/CDKTUN7bwvUzBisxvAOpIYKydNbomGaTX/eBKYeBbd1SphbdRUKG0S/0mMDGa4Qw6aafgfhENGwzIpAcpOyYbXyq68E2eHewyy2KrInArKo+LmIPy84fNzpjDnL+qgI0ss0m2FIZzx4AwUFED3vS38QgNUKamr5iueG+Y6sHvEHx+C52FnPf24pNNTcWn29n0OQd8c7D71oY7khQIhO+PM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 16, 2023 at 11:44:29AM +0800, bibo mao wrote: > > > 在 2023/8/16 10:43, bibo mao 写道: > > > > > > 在 2023/8/15 22:50, Sean Christopherson 写道: > >> On Tue, Aug 15, 2023, Yan Zhao wrote: > >>> On Mon, Aug 14, 2023 at 09:40:44AM -0700, Sean Christopherson wrote: > >>>>>> Note, I'm assuming secondary MMUs aren't allowed to map swap entries... > >>>>>> > >>>>>> Compile tested only. > >>>>> > >>>>> I don't find a matching end to each > >>>>> mmu_notifier_invalidate_range_start_nonblock(). > >>>> > >>>> It pairs with existing call to mmu_notifier_invalidate_range_end() in change_pmd_range(): > >>>> > >>>> if (range.start) > >>>> mmu_notifier_invalidate_range_end(&range); > >>> No, It doesn't work for mmu_notifier_invalidate_range_start() sent in change_pte_range(), > >>> if we only want the range to include pages successfully set to PROT_NONE. > >> > >> Precise invalidation was a non-goal for my hack-a-patch. The intent was purely > >> to defer invalidation until it was actually needed, but still perform only a > >> single notification so as to batch the TLB flushes, e.g. the start() call still > >> used the original @end. > >> > >> The idea was to play nice with the scenario where nothing in a VMA could be migrated. > >> It was complete untested though, so it may not have actually done anything to reduce > >> the number of pointless invalidations. > > For numa-balance scenery, can original page still be used by application even if pte > > is changed with PROT_NONE? If it can be used, maybe we can zap shadow mmu and flush tlb For GUPs that does not honor FOLL_HONOR_NUMA_FAULT, yes, See https://lore.kernel.org/all/20230803143208.383663-1-david@redhat.com/ > Since there is kvm_mmu_notifier_change_pte notification when numa page is replaced with > new page, my meaning that can original page still be used by application even if pte > is changed with PROT_NONE and before replaced with new page? It's not .change_pte() notification, which is sent when COW. The do_numa_page()/do_huge_pmd_numa_page() will try to unmap old page protected with PROT_NONE, and if every check passes, a separate .invalidate_range_start()/end() with event type MMU_NOTIFY_CLEAR will be sent. So, I think KVM (though it honors FOLL_HONOR_NUMA_FAULT), can safely keep mapping maybe-dma pages until MMU_NOTIFY_CLEAR is sent. (this approach is implemented in RFC v1 https://lore.kernel.org/all/20230810085636.25914-1-yan.y.zhao@intel.com/) > > And for primary mmu, tlb is flushed after pte is changed with PROT_NONE and > after mmu_notifier_invalidate_range_end notification for secondary mmu. > Regards > Bibo Mao > >> in notification mmu_notifier_invalidate_range_end with precised range, the range can But I don't think flush tlb only in the .invalidate_range_end() in secondary MMU is a good idea. Flush must be done before kvm->mmu_lock is unlocked, otherwise, confusion will be caused when multiple threads trying to update the secondary MMU. > >> be cross-range between range mmu_gather and mmu_notifier_range.