From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A27DC001B0 for ; Tue, 15 Aug 2023 15:54:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 125138D0011; Tue, 15 Aug 2023 11:54:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D5728D0001; Tue, 15 Aug 2023 11:54:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F056F8D0011; Tue, 15 Aug 2023 11:54:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E3C7E8D0001 for ; Tue, 15 Aug 2023 11:54:11 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9D28F405F8 for ; Tue, 15 Aug 2023 15:54:11 +0000 (UTC) X-FDA: 81126785502.09.4835AE3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id A96982000F for ; Tue, 15 Aug 2023 15:54:09 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=p9jXINvw; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692114849; a=rsa-sha256; cv=none; b=FuVC5i65lU3al7Ljml8yccJgTK/l+37L4xtSnY3DszJjAP8iSrhMViEaUHPEBBxfnfuD88 6VmjiDXT2WDgebNK5u8sqdSeCJAPOGeyiRJbwrAmSO01rSsUDHcebuUjFgTrf1ZsJOeivl Z4BlOD9MRlh5SwlMLcpjDGpxYA09tpM= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=p9jXINvw; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692114849; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YqM3sFIAr0dPlzpnG5UjR2YT4bCJ1GeRfuoA0iMwHhw=; b=rIH/tZoSy+lgHfhnZmkp2+CcaSfWXeRoUDPxe/9ON8idRiPbriMxPa6zH+YfiYSXcTEBg0 Y9XAcaGZ4IrLVGQb5Q/gQYIaUZucX4mq5FfYj2Cn23yir2kRFeWXrSxRXRv+Ln1+XHBVaV QSB0P1AmfcBs70JLk985+mgrmPk1aI8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YqM3sFIAr0dPlzpnG5UjR2YT4bCJ1GeRfuoA0iMwHhw=; b=p9jXINvwL96c8P5rdLOwOWWDEQ TRGHeh5zMeOeGxnAZcmNcQbJD4mvNJMXlzBwO8/1JYZs+vMhetvD9K+8L1ks6gYF4QTUfsh4ntyC+ BPSeES8+/beN1mbbtqMSOK4Brfq6z+0mmtwb0jRMYShEa1X8k+RRpijbMvaUzbw3s7ifW1ZFy9fsS /YwemLInbb5fOxQZcpgzdDAoyYjeWOHRayAwOXfasu52a1j4XfoiNHiFHY3cKFYsNgsVKCB1Byr6k /adjwv66R4kqZJMCiseto46usSLKk+plP3OSFxZvf722Iw7I5lY9v6RT9o0/iPt92oALkH+nYUTS0 4cz1BkOA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qVwMk-00957r-QY; Tue, 15 Aug 2023 15:53:54 +0000 Date: Tue, 15 Aug 2023 16:53:54 +0100 From: Matthew Wilcox To: Jesper Dangaard Brouer Cc: netdev@vger.kernel.org, vbabka@suse.cz, Eric Dumazet , "David S. Miller" , Jakub Kicinski , Paolo Abeni , linux-mm@kvack.org, Andrew Morton , Mel Gorman , Christoph Lameter , roman.gushchin@linux.dev, dsterba@suse.com Subject: Re: [PATCH net] net: use SLAB_NO_MERGE for kmem_cache skbuff_head_cache Message-ID: References: <169211265663.1491038.8580163757548985946.stgit@firesoul> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <169211265663.1491038.8580163757548985946.stgit@firesoul> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A96982000F X-Stat-Signature: fdgc6rqx73mystcp1ks734ammztfk7m5 X-Rspam-User: X-HE-Tag: 1692114849-814985 X-HE-Meta: U2FsdGVkX1+383X30b3t5TWy4iBpXvL0TxaSOBofR7r46sjdjsl0T7Q7igp4RMnfeNRXJYFzM+6FIuamUj/9yiScoEIPlDJGdcT7HZmNcSNYuVToSENDJxuzHnf78tK9sdJBv2kdxg7whlmOaeXNjCLq8kFF4ijoMLJ+hN/jvU1ZY4r/BEkv02fp8hPbo1HvVwox4q5CAk+0YPKQ4kzo52cyA6VvC+oL4KhTCfXBTdSWK8JQForgjrQdnxV0JyA2BDrekFADtynDiRyurqzVhrjwErojNHEpX0TGcIqY16E0AJ9YSMv/+i95vIA0NK58HirTo4nhZVmr1EXbKMiQnWGuLwm/EEyY6c/qos5dXMVPp53SV9do4M51TCeFnPiABeJsViwM5NdiGe7wOHHDuUTEOqruWnFMCosZhyy5exBHVa57LLvwXpnFGc8iwZGCscHlipTc9xL/eJhnKAxbvBeLPlFuBtTyMpZN8TwNbaek8bXflnfvlQCN5ajBWEklVbWGYZE23VzK/gByIDZoI85+0zEYS+vBANlS0FCHkryMUa5tGkEtUBaFzKO42uYcHd1j9k0jRjGsBRoxCiIacMqLkAhYl4PCZP0RRuax3fcRd7IZXVZseUkqEbmTn7cM3BBBgkHaua/OyT/Y+V9T5qqK3Dz27/0h5dRY3swPwwmW6jeAXAFQXi2sL7kP+TimsZ5NqE8tmbejvMiPwIAGkP/Zd0uOHXt9jH6rd1z7LZPs1qXByjNCQV6IerWv5yttkXNxDdy2J0nwnqc0RdSbUDAM4ztQa/NvX5C+ZsV5w9r1GeDdkUTL1PxYTyyirGiG8y7QrU02Bi9oCj0h0K7PmCUMvQwoAlk6hYA0ipkwUz1AxMlZM7xZrRyoCWpnZledqw3s5nU/O0V7gbv42K/Qg06NjEaioWovlZ/nSBK4rcrfLHhD10Zo7TtmQ+VFskJB4X4gmriL2dwl9yB19Si gaZzdVlA xYC/AJ+lwl62ch/Owl2tj8EPcbdRZI8RgKG6bo2ZEVLJZ7k0AHnU17r8JtsdpGe5bKeni9eQeQpqWPuSzpqcpgg3Cwm9yH0aN28QoqKtkinjNkqQmZ+XNpB2ITr7RSm+PWOEjXH40ok47hg6GUXT12gsf0YcKGAb4Oc2l0hEf0b50GBcM3WZx+MQtnpmpIGFVNnDlOlUAveRMJUJ/z4fGgCalQmhjkI7pdkw+RRFxw+tVb9tdbNzc4r/kFo+shs+W8v2NQmLRBxBvzPAqnJWkzQjmjSaLwIh3LIKiBBD1DqwA9iwmVpxXoe+FTaW/BTuAoiZz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 15, 2023 at 05:17:36PM +0200, Jesper Dangaard Brouer wrote: > For the bulk API to perform efficiently the slub fragmentation need to > be low. Especially for the SLUB allocator, the efficiency of bulk free > API depend on objects belonging to the same slab (page). Hey Jesper, You probably haven't seen this patch series from Vlastimil: https://lore.kernel.org/linux-mm/20230810163627.6206-9-vbabka@suse.cz/ I wonder if you'd like to give it a try? It should provide some immunity to this problem, and might even be faster than the current approach. If it isn't, it'd be good to understand why, and if it could be improved. No objection to this patch going in for now, of course.