From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F46C001E0 for ; Tue, 15 Aug 2023 10:58:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5893190000B; Tue, 15 Aug 2023 06:58:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5391F8D0001; Tue, 15 Aug 2023 06:58:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4014790000B; Tue, 15 Aug 2023 06:58:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2FE8F8D0001 for ; Tue, 15 Aug 2023 06:58:41 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0270E1A0CD5 for ; Tue, 15 Aug 2023 10:58:40 +0000 (UTC) X-FDA: 81126040842.12.367F5D8 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf06.hostedemail.com (Postfix) with ESMTP id 207F5180007 for ; Tue, 15 Aug 2023 10:58:38 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=nCzEACRx; spf=pass (imf06.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692097119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TjwLfv27498tFzVSmNurY4B5Fz6kQ6juEBRem4lqZwI=; b=m3xDG3COELsYZIcQZqtpwiNfAfWXrRPZ/TIsLWmv5sPn1KQZyahaaAw1pVD5FZY/jPLr6b xph3qkYf7B2HqQiK4kX8ea3mH87ppYP6rSiUUkd4Ui+h2znGnF8xWVuvIicfC1IVe6DYyS QVTZmnfDLIBSsEjIe1kJiSw74Z+aNcI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692097119; a=rsa-sha256; cv=none; b=HYFOr4aBj7m6zqMbgRW+GSn1ktvzAFvi3Lw8+Q7PIyAbuny0u0IdsyozjXrsRgxAx5WkXD tYnGZlYAfW50A2xiPbcJpOy2cAlu3u8Wu/t5MWyHFcCkJWjJl9PIHKf2sTXRnB2YusGdZz TnvamHeL1N4ZxepgfEnurVAftC+HLUM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=nCzEACRx; spf=pass (imf06.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 9D2F221986; Tue, 15 Aug 2023 10:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1692097117; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TjwLfv27498tFzVSmNurY4B5Fz6kQ6juEBRem4lqZwI=; b=nCzEACRxHN9GdHj0/9XXEm1Jul4w1kPJ5CA4Knrn3M3HGPhABhXiWAu24izy8W43tZihlz yWSfPMob/aKWs+bhK6g2zHAvvLfk0GkNN1N7Hw+kbXCgT/YUrUHzetuFsr5GTeXaVcFN9s nssEb7ePbNgNzINEC4A1hXR31pTwtvM= Received: from suse.cz (pmladek.udp.ovpn2.prg.suse.de [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 582962C143; Tue, 15 Aug 2023 10:58:37 +0000 (UTC) Date: Tue, 15 Aug 2023 12:58:36 +0200 From: Petr Mladek To: Andy Shevchenko Cc: Marco Elver , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: Re: [PATCH v3 2/2] lib/vsprintf: Declare no_hash_pointers in sprintf.h Message-ID: References: <20230814163344.17429-1-andriy.shevchenko@linux.intel.com> <20230814163344.17429-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230814163344.17429-3-andriy.shevchenko@linux.intel.com> X-Stat-Signature: qoi7yr8dnw43uajhmfmjtwaar4awb8ow X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 207F5180007 X-Rspam-User: X-HE-Tag: 1692097118-223193 X-HE-Meta: U2FsdGVkX1/K+thBLv4eHo0Wq5DZ1WCusE/n54VWkBGbNKJBJSJndiXEccazyqkPMEQSawPN/pytqGOCvF344M/wB7u8iNZp4rm4kFvy3nVadTIl5u2MPnX+kMXuGjwPAavkbFWgOK8AErouehpxbwsqDDczfAAteUT3M1Q5FVA/mIOb9wLgqMP/LJrLDlVG74kXAj4z2ukBzR5XPEAJFH7UJjpxBnK/PV3OV9bb3HHI7qmfkhduseqTk8KYFcmUsbH89Wi6MjOnbZzmSA8Th52rntxImUkGF8eEC0Iw8YgcoIIQVFeQhfYrxhFzmp0Fed1lXtwem4QHWXlSVOfDtlfR+rX7ddy8v9Hi79CNFiW1NcDkzaeP3dwotWCtwVpPvoIa1HOOs1YEUhQt3Zn0AFSrDTB4v9ZuNC75V2yntklQEo6BNcgdh4Sz9DwnY2qxeoANEKX45vi2QGsYumFKDM3SJvpOBReUR0jZ/tZ1N5JonqO5e4u3vSSaHKrI8RQEsfAX76DRb3uu+p4w+uzcwZIjB9WyPrnguDk5fWe49LhlVJWKXUhEE587mPxTL+qkQ90m5cD9EBlUUcRBx43pTIgqa2mljwMTBuvwXacPl/QwdaBCnnf8UXUVRBlzr6MyaKj7wJcmFyH0no855YgTbQj6imVHlnognPXMSyt9eU/DPEQTNKDEREJbbJ51+Y0+zbdgnI0oFOthrMB1/54m32hVbzlzG72MBfmVT95ms1OeM85zhjK5xPSWla3Ks2+EwGSY46YZi/AyG2RhCzcAy6K+kc3WhyxRMYKEShsZ09cg0WCFzH/BrSvf9KcZ2AbNQWbOgOtLli7HCNckyOUaMrayGEtQChyTfLc+S4YKLd+ySsJ3Z05rvRd4ZWOWIdEDRl8xHl9fKnsoKfEY5XWq4MTH7nhE/q3nSfisaHkJa9S35iJQltLQHwN49swd9ZBKr9PCZxe3Mj9fJkfJ86h VSLMUU1k v+xkPYfdSSMplvaMeXK+4R5DjBn3KEnUQ8lp36kBeZNarO+RYITPUyXGeY2ig4fhBh9WZzGguV7f4dvlkJx3KA56TULZfz+YSBW2b6R/TG5XQHLo6xBKNMY+5r9wTxvH7wr7HikrXirLLT5csrmQaX2qwtgFuF3ZLHisNgch8TmVXFFgxUkncN36B3nHTy7eYxI4fWuJnS4QtyA83sCFBFh+74WcDsO4NYvHKJGPz9cWuIfeCuy9HPVXwCPLCryPxClZn9+242XGrPYjkgcJvHLRgQ8dZHgGHbmnD2sH6SSCW2N0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 2023-08-14 19:33:44, Andy Shevchenko wrote: > Sparse is not happy to see non-static variable without declaration: > lib/vsprintf.c:61:6: warning: symbol 'no_hash_pointers' was not declared. Should it be static? > > Declare respective variable in the sprintf.h. With this, add a comment > to discourage its use if no real need. > > Signed-off-by: Andy Shevchenko > Acked-by: Marco Elver Reviewed-by: Petr Mladek Best Regards, Petr