From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEF76C001B0 for ; Tue, 15 Aug 2023 10:40:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CD958E000A; Tue, 15 Aug 2023 06:40:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 356638D0001; Tue, 15 Aug 2023 06:40:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26BF48E000A; Tue, 15 Aug 2023 06:40:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1755A8D0001 for ; Tue, 15 Aug 2023 06:40:01 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CC3D7C0910 for ; Tue, 15 Aug 2023 10:40:00 +0000 (UTC) X-FDA: 81125993760.30.00C83CA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 467844000F for ; Tue, 15 Aug 2023 10:39:58 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf01.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692095998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3gyv+Fe2kRF4t4UAImyxMYlz2KWNWd/t5KZRm4sI4P8=; b=ygP3TdNn/LTm+kEtM299eW1k02wRvd0bA8mCEVNBM9bMBkpD9peelh1gFNvsbcfg6X+F2x KY0SMQ3IaN3Z6wnOkXNdIupMmo2WKPqI68EKLinVPqBhbfEki/A4W9Fwg7k6ZiYetsFhnR EHFy6RCbeXO6hdl5g1jVEFLSWyeAPWg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf01.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692095998; a=rsa-sha256; cv=none; b=d4b3ZULWzYhziqok52QL7Ihot4Zp0CyDkgy/xkwnYWkwzrnBxGAL2wgVMAbVl7VjYIvrxf OkGl3I3PGTNJvTJ1TQLIZbRNWtFg6z6xyfGgLcuQXE3m1XCNvCCI3O0mW7R8vU01VHJVI0 GuuvtEkBWqkMxfIKIdMZAY0pwMuoZvA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2A61B65297; Tue, 15 Aug 2023 10:39:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9224C433C7; Tue, 15 Aug 2023 10:39:54 +0000 (UTC) Date: Tue, 15 Aug 2023 11:39:52 +0100 From: Catalin Marinas To: Xiaolei Wang Cc: akpm@linux-foundation.org, vbabka@suse.cz, glider@google.com, andreyknvl@gmail.com, zhaoyang.huang@unisoc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/kmemleak: use object_cache instead of kmemleak_initialized to check in set_track_prepare() Message-ID: References: <20230815051358.802035-1-xiaolei.wang@windriver.com> <20230815051358.802035-2-xiaolei.wang@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230815051358.802035-2-xiaolei.wang@windriver.com> X-Rspamd-Queue-Id: 467844000F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: da9ihk5tyn8hxzmdx5yxcy4re3t1w971 X-HE-Tag: 1692095998-248540 X-HE-Meta: U2FsdGVkX1+jh+RfIISnQDtir91+Fd7cme1uRuX1HvfXKsM/QygISQ69q+Rbjddx/Ao7MaJP99hkqfZ5l7m351SgbKiArzozVnRoA+ayB6CPEAq9zBYSTvDrLhA3ncXvLUPEdbI806oOkZoBMtF45DQYqPEuCXkVdDbBpAxAJpjczSNnRgb8kiexeFMS0FqI7zJcO9lK5IKYb3LLitWUipp3jfKSvnQm931UFJbpViUvEhFksqt+SmCbYaSGQKU9EEMmfZB75ZS3lj2ffVPaKCMiByOhCEG/g/zoCg/WRJFtm5TPSxbrKajNVTLpIxA7pfl8uGi9a0L8S1elpM2rrqov26yR8PmiHyXEoR6uuu4/YXjY1be/mBqGZ9O99ig16NONwr82wqj4INvxcKoGcBoiPaLREiYJ/yECDnz2aPzYMG3m3XuLmvzirdLf5/yYmfpyPQDzml/o0QR72eSYeRrHf2Hc8Dg/78ZNmOJ9Bb09veRX1m0mdJMv4sNQ619dgKAjJEGzLBm5dgVLegdu+CLAuDDScZgvpei3P9kom6PEB0C05KnMP3/PxWGNvYejlozXJ+Mzs53ajHuaYODVF5dcCmdC8cfjKSrpsTmrHw3syFRBbR39cYP97MBonJTDXjIJQ9w66ZW3vdO0LnrSyZKKTESQ/JM/rBNGZbnvvp7gscFD3NjimgvCwA/3Fkea1ikWnKxw2Ek1eqNyhsVlBtqCX7ZzqXGjlBntNnLgxDuT52GQ0AE5D0eVJ4Icp4nzf+OSIpi6C27k+JhgegExiUOwfgOdLo0YqLJtKJ1KIG9U8xUo2ZKEVOiVDLkxzAaqvQREbXB6qx7+Bb1h/qhmOu0phrkPTkp8RDLcrlJfRA4JtA8CtUkU++MnckOBNzFhMI7YsOZW7yQ1cvn1kLWQw+auh11TVUmYeFe3wUnXHJQhACN2uoDG1WP9vROZrwKmDYr/+3lGSqzKmSYJ34k Y8PTV+Qr tDym6XPLPJAyYR/+Xn8dRJLLMqu0rSIPT6C7qPkZztXGOZTTkAKiYFjhX5QHn03u9LY4at3ewxWC+46VKn0uXqLjik9Pr0fi/1PGaLIS2awvkNdZ9ayMr26PszjpUl1W6mUFopGxpN3seKN5UQCemnpeMAHPO5Dx9C+TgZ1AIzif0MBbPdkTIMIG7ZPt5mJFG0shkbXhwUIXMeDYhdHhOmZUsUKsfi3dp4R20NPrCXeOTWGzjhSbfQXa4UePfpOJmsdxiTfnsxFuQQy+lD5tGEWrq1XMJSNqqZpJBCEZzXW/IQj+cOvKpxv7Bpjykk1eYiW87H2CrcghSZrhQeMtfgC0ciseRzmhDhQ28rsKjzHaxONk+fkkfp7++C3gqYLfFdjOXNV9A3+pgk/TSJoSwkG/YjUgz0sEHeEHOiFdms7FqEpI/oKJ6gld1UCi3ejw41JBGlyYPRykDagdPzhXyy+rOGyP07XxbtiC8YRSf5aFhFgc9Vkpxmu0Gs0PTaZFgL/uxKcGpAJNG1VY9eQ0DL9Hxz2dnrf2cfYrYp71nPFmKLsunmf57gVfO5WWlk9DTqvIkuPDCeWghcNs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 15, 2023 at 01:13:57PM +0800, Xiaolei Wang wrote: > kmemleak_initialized is set in kmemleak_late_init(), which > also means that there is no call trace which object's memory > leak is before kmemleak_late_init(), so use object_cache instead > of kmemleak_initialized to check in set_track_prepare() to avoid > no call trace records when there is a memory leak in the code > between kmemleak_init() and kmemleak_late_init(). > > unreferenced object 0xc674ca80 (size 64): > comm "swapper/0", pid 1, jiffies 4294938337 (age 204.880s) > hex dump (first 32 bytes): > 80 55 75 c6 80 54 75 c6 00 55 75 c6 80 52 75 c6 .Uu..Tu..Uu..Ru. > 00 53 75 c6 00 00 00 00 00 00 00 00 00 00 00 00 .Su.......... > > Fixes: 56a61617dd22 ("mm: use stack_depot for recording kmemleak's backtrace") > Signed-off-by: Xiaolei Wang > --- > mm/kmemleak.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/kmemleak.c b/mm/kmemleak.c > index a2d34226e3c8..04bb4cdbb402 100644 > --- a/mm/kmemleak.c > +++ b/mm/kmemleak.c > @@ -610,7 +610,8 @@ static noinline depot_stack_handle_t set_track_prepare(void) > unsigned long entries[MAX_TRACE]; > unsigned int nr_entries; > > - if (!kmemleak_initialized) > + /*Use object_cache to determine whether kmemleak_init() is complete*/ Nitpick: please add spaces after/before the comment delimiters. I'd also make it clearer that it's not about kmemleak being initialised but rather the stack depot. E.g.: /* * Use object_cache to determine whether kmemleak_init() has * been invoked. stack_depot_early_init() is called before * kmemleak_init() in mm_core_init(). */ > + if (!object_cache) > return 0; > nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 3); > trace_handle = stack_depot_save(entries, nr_entries, GFP_NOWAIT); Otherwise: Reviewed-by: Catalin Marinas