From: Tejun Heo <tj@kernel.org>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Michal Hocko <mhocko@suse.com>,
Shakeel Butt <shakeelb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Muchun Song <muchun.song@linux.dev>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: memcg: provide accurate stats for userspace reads
Date: Mon, 14 Aug 2023 14:47:55 -1000 [thread overview]
Message-ID: <ZNrLO5PAEZw4yjI9@slm.duckdns.org> (raw)
In-Reply-To: <CAJD7tkaXwoF-faApweAmm7Db7jAuS3EO7hVvdyVtqW_rE+T9Vg@mail.gmail.com>
Hello,
On Mon, Aug 14, 2023 at 05:39:15PM -0700, Yosry Ahmed wrote:
> I believe dropping unified flushing, if possible of course, may fix
> both problems.
Yeah, flushing the whole tree for every stat read will push up the big O
complexity of the operation. It shouldn't be too bad because only what's
updated since the last read will need flushing but if you have a really big
machine with a lot of constantly active cgroups, you're still gonna feel it.
So, yeah, drop that and switch the global lock to mutex and we should all be
good?
Thanks.
--
tejun
next prev parent reply other threads:[~2023-08-15 0:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 4:58 Yosry Ahmed
2023-08-09 8:51 ` Michal Hocko
2023-08-09 12:31 ` Yosry Ahmed
2023-08-09 12:58 ` Michal Hocko
2023-08-09 13:13 ` Yosry Ahmed
2023-08-09 13:31 ` Michal Hocko
2023-08-09 18:33 ` Yosry Ahmed
2023-08-11 12:21 ` Michal Hocko
2023-08-11 19:02 ` Yosry Ahmed
2023-08-11 19:25 ` Michal Hocko
2023-08-11 20:39 ` Yosry Ahmed
2023-08-12 2:08 ` Shakeel Butt
2023-08-12 2:11 ` Yosry Ahmed
2023-08-12 2:29 ` Shakeel Butt
2023-08-12 2:35 ` Yosry Ahmed
2023-08-12 2:48 ` Shakeel Butt
2023-08-12 8:35 ` Michal Hocko
2023-08-12 11:04 ` Yosry Ahmed
2023-08-15 0:14 ` Tejun Heo
2023-08-15 0:28 ` Yosry Ahmed
2023-08-15 0:35 ` Tejun Heo
2023-08-15 0:39 ` Yosry Ahmed
2023-08-15 0:47 ` Tejun Heo [this message]
2023-08-15 0:50 ` Yosry Ahmed
2023-08-16 0:23 ` Shakeel Butt
2023-08-16 0:29 ` Yosry Ahmed
2023-08-16 1:14 ` Shakeel Butt
2023-08-16 2:19 ` Yosry Ahmed
2023-08-16 17:11 ` Shakeel Butt
2023-08-16 19:08 ` Tejun Heo
2023-08-16 22:35 ` Yosry Ahmed
2023-08-18 21:40 ` Yosry Ahmed
2023-08-21 20:58 ` Yosry Ahmed
2023-08-15 15:44 ` Waiman Long
2023-08-09 13:17 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNrLO5PAEZw4yjI9@slm.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox