From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC875C001DB for ; Mon, 14 Aug 2023 18:54:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28C58900007; Mon, 14 Aug 2023 14:54:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23CAE900003; Mon, 14 Aug 2023 14:54:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 104D9900007; Mon, 14 Aug 2023 14:54:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 01DEE900003 for ; Mon, 14 Aug 2023 14:54:37 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C0129409D7 for ; Mon, 14 Aug 2023 18:54:37 +0000 (UTC) X-FDA: 81123611394.27.4AB3F5B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 56AA0C0014 for ; Mon, 14 Aug 2023 18:54:35 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M4V4FnB0; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692039275; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=igkdo9cOm/OvdG54WgkKwtpnvmKDjEIs5/xewVmFgn8=; b=rRvbc0048XfpKBQp95iEnLl3urS8ZuWyODbcF+JSMu/KFxa/e5k9pRRs1eCfJ/R7OXBAj0 lJWQLFzCXO8MNuTTgwspgN4IObklTVN3682QcjRT6ZJR6Zzy9RSADRFMJ4XzXgdmMpyXLv fVJnA5BKTSdN5UC5aPuTmUlt04j4+rM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M4V4FnB0; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692039275; a=rsa-sha256; cv=none; b=RldJAdo6ftzVoThB3GgCEwXOigrL05eegwUwokfyTQFQSa8dUfQQzBDbLFr+0Fp5S5Va/p tL6GMZyUXSArULIQY7b6jXYg3uthjc7SneCQzLQziZ5PfgxVjXxLwouhrfFaTYMOYJ5i6i DlIVS9tvan0KzgfZLsPKaSo88r6zZAg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692039273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=igkdo9cOm/OvdG54WgkKwtpnvmKDjEIs5/xewVmFgn8=; b=M4V4FnB0EPPDh52f2oayWaH+XZhuLTizmW1QTFZuAPktRPbhhCx1qmTjSc6QIeNxsVtJD7 7sTKkewoVSrKg3zYfkSEYKW6yDUm4/wDWM/8qSsx2sD5r5bFd1EU/CogOr+iA9It/Vd0LD f06SLQK9xSHI76JOZc+9LxNbGrjRDVI= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-92-zCRmBRMVOI2OpSR6zGvC0g-1; Mon, 14 Aug 2023 14:53:12 -0400 X-MC-Unique: zCRmBRMVOI2OpSR6zGvC0g-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-645778904dfso8675186d6.1 for ; Mon, 14 Aug 2023 11:52:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692039140; x=1692643940; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=igkdo9cOm/OvdG54WgkKwtpnvmKDjEIs5/xewVmFgn8=; b=e2RtW5zaHbTQLk38KSR2IM22WqHGnhx+ts7K9GOQfk5AIZCARyuhUhUO1lZU11MNvH VAdZglGcGnOXCcD1IVxAU52NmySUWk/n+9BInygRI9It2Ik983NIGyJEzKOZvMKfevVY GZQbQA8AKoe9Hw5GZIMPT+yb1va/oAEntNwWiuZXVHkEIZUXK0kdD9eDXskfRv0B32la Jxizhb0ZJUXc3vEIqm5LRQ7pbodPfIHVxu38GalJVKIhmoqWZY3uMZBLQk7c5YIOMpEA xDiNvmr9LGyDrxBWoiSUvTHNavRdSNGxeiGNLrgycyvupvX1lZEUS2d4savXi916zqQ6 IBOg== X-Gm-Message-State: AOJu0YwvzX0M664kE9x+4Pp7G/Iz1ifTrs1jLMW/aDmfdZAyuymPXMg1 3p+IH61YfvlK3D8Z48HM709G5/iuGWAH2ad8mWY7iINN0ar5RnaVV1dANHV0Sbvj4LU1RJvhkEm qToDdb93mcH7LWDg8TedAIip/Zz+r0GV2wUZLYkJlOLRg+fIhvvazizNwT5/s3guM7Nmb X-Received: by 2002:ad4:5f0f:0:b0:625:aa48:e50f with SMTP id fo15-20020ad45f0f000000b00625aa48e50fmr14434233qvb.6.1692039140538; Mon, 14 Aug 2023 11:52:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFrALdj980XAQhySV6fg3YjSPRn7c73JooppkvwmK5v4lICFmqgAg6/maXEDqd7+1omZXTykg== X-Received: by 2002:ad4:5f0f:0:b0:625:aa48:e50f with SMTP id fo15-20020ad45f0f000000b00625aa48e50fmr14434213qvb.6.1692039140266; Mon, 14 Aug 2023 11:52:20 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id q12-20020a0ce20c000000b00647290bd591sm553315qvl.121.2023.08.14.11.52.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 11:52:19 -0700 (PDT) Date: Mon, 14 Aug 2023 14:52:09 -0400 From: Peter Xu To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Mike Kravetz , David Hildenbrand , Matthew Wilcox , Andrew Morton , Yu Zhao , Ryan Roberts , Yang Shi , Hugh Dickins , "Kirill A . Shutemov" Subject: Re: [PATCH RFC v2 1/3] mm: Add TAIL_MAPPING_REUSED_MAX Message-ID: References: <20230814184411.330496-1-peterx@redhat.com> <20230814184411.330496-2-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230814184411.330496-2-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 56AA0C0014 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 1ntkbibd4pbaxn36d7hthexywus6r9ua X-HE-Tag: 1692039275-832546 X-HE-Meta: U2FsdGVkX1/64diYu2FLFgbqc6LUaThVcDk/8z68xj5J9/0Er/0irDr0Bcv1PaIWsRQ0QLSav2ffq5Hdw0xckNzCciZpH9hL3137YrXD40aljzhAXzV7uMfJpQ8k+zWsq2kVsjd9mjFf0FOeps9MLP9yWCZTkTupg/uas2w/+Y8SjyxviTGFCXUFIkiQ88+MBNdAj4cGdh3ljNGBE00jStGm2xOY93yEfv5wialYeEK4hykXaiDq2OT86j7nX/OLnzLwlYaS5/11qlsAZCoKDaSLjYF5GBU8izVg9KrLmPrz907EBZnlKUpMUDId3b2vAV9JCLEV0BRrvSSYAZHuf4hPWV1YRFYnEmS2jxnYYYyLQKwPWr1svu5uYzFd9TvcOhnHHtADSw6O4JZbCJDq8PkEj7e02AOCQ1QBTTn5yTSn6tbmFq2ixGEMM0QfCppDBG0XIKzpEwOKOnYY5VLGA46fxEDuUmAuXhW1/hcptAoep2CPb1/xip5I588p53W15rDhwzu/2JrBgTf7ujhk1vYPJ0qjra+ogaI09J3kfn5RMfeVVogxGQrMbeye+nOnTi/FWVw15qGceE3YKpYF3WKcNot/Aj+2oMrhgOJWBhtqg+RR22PLuhS1eTz7d2nDQUO/Sd13eOG5XU0FvqOtDhjafeYHjH+7tZwW2uXBP1DepjQ5cZtLdleEUBDk910TQimtwoL7LhqTSHQEzGtCY4k5rrQYPvEGXKneZLTC2nepH6ZTWFZ9JLm92ypURqe7DXMX94HfSB2ASKav/D6e7D5ptSrDYTSa8A67VZXCCJXwAd2Q3mhxmE86rODEjTUJlvlyBS36fpe50uEDlxwtLxlk9u5uOylHawjagt2PtslQ1wDnkALLoNJ82phqhfXkAlzcuE1+SA5NfU+wjWy0Uv6VkKvhXGWMW0gvNbJyF0ML0x8v59acImnH/Ci50GEwEYfPoZ4C9LuZzF9sncg Cz7OFcGx yN5DtYkGbiMz2uXTUtAfoQD2pGfG2jhgr1s4JUwVUfnplAqQUcf0x2h3GLZCQ5K4BepzIJNmUOPHdFYYYhHUHeQpCB7G61ofdFi5iNUHdXCrd1iCmSJTq/IZmq7wlewlT/FOh+dWeatcfiqCo3mA6kSEevJNaKYWKQloyV1LeR/Hyv0TiR/+l5cBbqQGJwvbeN4nXpkUS4YR0zT4jhew5wqz1eeLrheDYCUhGdkpXbH0k3o2Jn19A4/0PLk8wGRr40wfPswdd1ZsZP4CYQfLAaShq8A3xWgM6zCDE5L0HhMFIqSHI7AgPio02OEZ+DDbAs9VQ8Fs97P2N214CP7E7FoPMbiIJ/4ywIWPcJEZjIpDTEqw/XIU5tl8PCF3qsMDsqqpjqMr5DRu2KtTWjWGk7VzvGtdhgWuPZd3khqXhq9BmlyWBNZCnLHZnfg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 14, 2023 at 02:44:09PM -0400, Peter Xu wrote: > Tail pages have a sanity check on ->mapping fields, not all of them but > only upon index>2. It's because we reused ->mapping fields of the tail > pages index=0,1 for other things. > > Define a macro for "max index of tail pages that got ->mapping field > reused" on top of folio definition, because when we grow folio tail pages > we'd want to boost this too together. > > Signed-off-by: Peter Xu > --- > include/linux/mm_types.h | 9 +++++++++ > mm/huge_memory.c | 6 +++--- > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 291c05cacd48..3f2b0d46f5d6 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -248,6 +248,15 @@ static inline struct page *encoded_page_ptr(struct encoded_page *page) > return (struct page *)(~ENCODE_PAGE_BITS & (unsigned long)page); > } > > +/* > + * This macro defines the maximum tail pages (of a folio) that can have the > + * page->mapping field reused (offset 12 for 32bits, or 24 for 64bits). > + * > + * When the tail page's mapping field reused, it'll be exempted from > + * ->mapping poisoning and checks. Also see the macro TAIL_MAPPING. > + */ > +#define TAIL_MAPPING_REUSED_MAX (2) > + > /** > * struct folio - Represents a contiguous set of bytes. > * @flags: Identical to the page flags. > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 0b709d2c46c6..72f244e16dcb 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2444,9 +2444,9 @@ static void __split_huge_page_tail(struct page *head, int tail, > (1L << PG_dirty) | > LRU_GEN_MASK | LRU_REFS_MASK)); > > - /* ->mapping in first and second tail page is replaced by other uses */ > - VM_BUG_ON_PAGE(tail > 2 && page_tail->mapping != TAIL_MAPPING, > - page_tail); > + /* ->mapping in <=TAIL_MAPPING_REUSED_MAX tail pages are reused */ > + VM_BUG_ON_PAGE(tail > TAIL_MAPPING_REUSED_MAX && > + page_tail->mapping != TAIL_MAPPING, page_tail); > page_tail->mapping = head->mapping; > page_tail->index = head->index + tail; I tend to also squash this in when repost: diff --git a/mm/internal.h b/mm/internal.h index 02a6fd36f46e..a75df0bd1f89 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -428,7 +428,8 @@ static inline void prep_compound_tail(struct page *head, int tail_idx) { struct page *p = head + tail_idx; - p->mapping = TAIL_MAPPING; + if (tail_idx > TAIL_MAPPING_REUSED_MAX) + p->mapping = TAIL_MAPPING; set_compound_head(p, head); set_page_private(p, 0); } -- Peter Xu