From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97F06C001B0 for ; Mon, 14 Aug 2023 13:23:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 059A86B0074; Mon, 14 Aug 2023 09:23:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00A568E0002; Mon, 14 Aug 2023 09:23:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3B278E0001; Mon, 14 Aug 2023 09:23:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D42F86B0074 for ; Mon, 14 Aug 2023 09:23:48 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 84AF240BFB for ; Mon, 14 Aug 2023 13:23:48 +0000 (UTC) X-FDA: 81122777736.21.BC2CA0D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 3CD0E40013 for ; Mon, 14 Aug 2023 13:23:44 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZAzrCQUw; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692019426; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T8Pbi+AtdsCBMxSWZKRpPW1Wq89VMiXjiZzvJl2OWrg=; b=S/DHMxXey9+x0MT879aNe6HDjz32vhJAm3/O+E09xWZ5rIXH4k3IDhHXNea8mIjoA9XJho NunKGkiEiHC0WmqNPUwB367EyHmxLv5Z5/RCDIPmJcjImacF57Tj/bTVjDCGI0ifISKudt 7akcH0h1bOJacupqs4K4XjlLq3gq9Hs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZAzrCQUw; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692019426; a=rsa-sha256; cv=none; b=JpYgXbgxf4y0MQgVGs5alq4AZeQln62S8+Cv1QhHGphfxXpmr2WoGgI1pQw9bFrd+gdy3r /Rnr7zmLMPJfDMPtNgEY1wmQCIXp5SmH0nRCcHLt3c5LGyDtigfA3f4afesXYzKr332Z2h 90o9Ex7m0Gkr0ztEh6DrM+AXwY6hrWA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=T8Pbi+AtdsCBMxSWZKRpPW1Wq89VMiXjiZzvJl2OWrg=; b=ZAzrCQUwDaAiLY4rZgSiHtfOqx IW4PK1p+wQl0ChvH7y0wpWHWR1LYToASBwSu0e0rdS9Xca7PHdv361bc0zWtqxALBw2YbZE8gTIzw 13sjIAlCgdMAwDNFKrSkxr9EgUQKWPHkeNvYBf8QbDUyMjHiTJLz1zL0NHqF32I0riLKJ51lf4FaP WXfc4pqsB+rzHH9681o5Kp/D8rqmKoSAfEFvs97UULXP66FtphZ0I3Hq6RhsECX25jD1y3TKWr1aY lyGixDvt6jM913leiyLRLYy667PvsQDGi2bPZnuVG0g3Qk20/qMhJAdDhUc5bligeE0bPItFzdYq3 NbVRDT0g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qVXXc-002BRU-Pq; Mon, 14 Aug 2023 13:23:28 +0000 Date: Mon, 14 Aug 2023 14:23:28 +0100 From: Matthew Wilcox To: David Howells Cc: Alexander Viro , Jens Axboe , Christoph Hellwig , Christian Brauner , Linus Torvalds , jlayton@kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] iov_iter: Convert iterate*() to inline funcs Message-ID: References: <3710261.1691764329@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3710261.1691764329@warthog.procyon.org.uk> X-Rspamd-Queue-Id: 3CD0E40013 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 1ge37b3tpz5g6tydufys8n7nnrcq73jq X-HE-Tag: 1692019424-975088 X-HE-Meta: U2FsdGVkX1+ufsmzYvUvcp2MEwjrJbowYZMSMOviudglyYohg3IdVvXaiYTiUUWmsocnYt+J3ugT2vC1hEXJ8IVYfi/Epce4Bq+ajjSSPTJVR5sZI2MAdHnhuOi7BQ3S7VTkjmYgXMPdKL4R7rlQ1kf4avms/JngDlGEy6XgMi4VSnJEb69g5nR8TPuS1NiEfbmHpKJ06vAU5kSbcIcyLkvNfcvRMnSl8RHu0fLOMjmssDtBcwtes3JpxqGc9SUh1EZX4jSiegsvLdITj9OfDxdHjsP5ej4sFHg8sIurPuIRaNHcxQzEd+Y7dK/h7AhgYVEkx3/ltVSAEGTHclW5lgbACmY/3bTtpoxwMTU9rj3HyWvjwevhogBenh1YuuGc4cKcqF4x2MxOvr1jMYHGSfV3+URsAf/5jw4syKj+mDJo5dNkatK53nZpNc1bsn+LZgtiFU1hjs5bE7TXQiQJAutnRl+wdzwnhZ/YklgtQ8MUWY30qJc83ImI/q9ehoO/H5t6cHCDjv6SCrA4eSHUb+QOw/4h7XpLPX6FULByjPHIU+5WOO7U3yL8vp5fsPvljKJ1sntyYoznANbNVrz/7fibfJIcDshmjmA0yBoa30BhFE74YJwhAyJpL9g5AoE02Iyrbrk0YCd54hApyINUQT0yg3jlY8/7R7Hiwo78XOCH0/FOPNHLGmAW8v1AOmZ2TVOoksow8xddDk5ULRJvxzS9dGCnzHdc7EIbJfYIYKXuWcBbaFOShLGVI0t6avpAizGJWfBMJUmMs8TQ1/8vt1tGinV46XVGrAou1stOxuljinxP9CW+HPVVA98/imcIJ6dzTuqluPnGGGbQjcth3Liafb8/AkucZk9PWbnutycRDFi0DXdOu8mLFwTYX4qXfvbXyvj/iT2B/T5BczQwQtpPxNrBOfF896YrElhumfQDUMcAiL3efkcrFV37Rr6mtVkDpHidW5YAXh3lRe3 +/bgvCs3 Oqf3252e2lN+JqgGFU16TiEYxR3vnZrNuI8QmLmaRhLZVpNVfJAMb+Hj8q3WnHG42Sz1D6OqmhCqk2pfH4d/uwdktRLBQGvZw2UPmLSlY1UBpkw0sNbcQKqhyM6Oyl7vu1PFCoO85lCt04bE+jNse+M1n+Nj/5E2Vh7UIp2jqXBsG17DvqHY+0mZA0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 11, 2023 at 03:32:09PM +0100, David Howells wrote: > @@ -578,10 +683,11 @@ size_t copy_page_from_iter_atomic(struct page *page, unsigned offset, size_t byt > kunmap_atomic(kaddr); > return 0; > } > - iterate_and_advance(i, bytes, base, len, off, > - copyin(p + off, base, len), > - memcpy_from_iter(i, p + off, base, len) > - ) > + > + bytes = iterate_and_advance(i, bytes, p, > + copy_from_user_iter, > + iov_iter_is_copy_mc(i) ? > + memcpy_from_iter_mc : memcpy_from_iter); > kunmap_atomic(kaddr); > return bytes; > } Please work against linux-next; this function is completely rewritten there.