From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F4DEC001DB for ; Mon, 14 Aug 2023 12:28:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D9206B0074; Mon, 14 Aug 2023 08:28:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7898D6B0075; Mon, 14 Aug 2023 08:28:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6781C8E0001; Mon, 14 Aug 2023 08:28:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 58C8B6B0074 for ; Mon, 14 Aug 2023 08:28:51 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2F913160801 for ; Mon, 14 Aug 2023 12:28:51 +0000 (UTC) X-FDA: 81122639262.29.B305F41 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by imf05.hostedemail.com (Postfix) with ESMTP id A1E6710001B for ; Mon, 14 Aug 2023 12:28:48 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CJChbZQ6; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf05.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.151) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692016129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sW3GoTngdmEh8EJSLPl4WhJdz/gjww5oqwmrnvdAlW4=; b=2qX7lG71e9LkaUxNZa/z91PwHGDFQfaLB8PdFssMbUuAYg8XQ0ldO7zjSgU2qp+Hfn0uAa oEWe64wDXeREOFuf6UoXk/MbOEWJa0igQ8SenvecvZTk8EUe/TD13rvGpG3G5CpM1XRZDz lsgOHgZl9KBXXfh392U8PxKlyMOvoZc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CJChbZQ6; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf05.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.151) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692016129; a=rsa-sha256; cv=none; b=uUQlVl3ICmpHQp0rJyHuEKvAOKMJzC+5/72eS+VJQ6KLdFbaKUNTyWAj3Jid2Aw/B1Ly9j 8EPP6cDJpS9NXRy+8YXA9aM2pdgkZ7eJoQy2sv8kBi91wpU5mEZcpuJ2mEKdUQHJxyTbPO w86QfaqZ+cREuMi698roSQGvfe7Yqds= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692016128; x=1723552128; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cpc4XVuM51SJ2B/O4lQNuNKlc1XAvLGUzgMfcbN3Plk=; b=CJChbZQ6kTImozG2r+6fs18OptRQ1tIzikokp+AOJOrS8eTZrdwwrGaB p7mffot6iP6+mLaJK+o/4ySQJnEBRaoFy+PzQvMhbS/3xOLhbS4yqxrt7 M2mRNzNrqnOIk7tsmWTvd4+yHHeRya/62xxNEYoDvfWvt3/OgGa27p3mH L83PMJ3zOiTabmfef+2KPQF0PP9mlPSVKcnc6oyLLwc5STmc02OzhFDnw PhsNwQLw+q4uZXlLIaW2PwGhaWs6xnE3PWed8Ff5VS0yPyv3DyaLNojzX 2ASV3fM6gAP6jWLrpZvgWLnTloK37rdxcwi63OHlE8ijoZpbV5tAxV24/ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="352353563" X-IronPort-AV: E=Sophos;i="6.01,172,1684825200"; d="scan'208";a="352353563" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 05:28:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="823434944" X-IronPort-AV: E=Sophos;i="6.01,172,1684825200"; d="scan'208";a="823434944" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 14 Aug 2023 05:28:43 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qVWgb-004XHM-19; Mon, 14 Aug 2023 15:28:41 +0300 Date: Mon, 14 Aug 2023 15:28:41 +0300 From: 'Andy Shevchenko' To: David Laight Cc: 'Petr Mladek' , Marco Elver , "linux-kernel@vger.kernel.org" , "kasan-dev@googlegroups.com" , "linux-mm@kvack.org" , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: Re: [PATCH v2 2/3] lib/vsprintf: Split out sprintf() and friends Message-ID: References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com> <20230805175027.50029-3-andriy.shevchenko@linux.intel.com> <900a99a7c90241698c8a2622ca20fa96@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A1E6710001B X-Stat-Signature: nw4c89owq7784ug3w8uorgb6wbb4iobc X-HE-Tag: 1692016128-479050 X-HE-Meta: U2FsdGVkX1+XHK9Dnkha+liuJzoAuiGwnxgGT91ac544oyUXPzoUhC1EorPGy9CzgLXceZYLewGdKcJvOyVtcuT+XWeruMqqn4R1RfPG8vM22zf9hz/v4p/06u+c7Otxl6nDRhO5BHxsMZVedz0078TOFO0+KW8sMHhbZQ97rM92Lxycj6fS6Nq//wfg6hWZ/RjVYUv1TVXdmyW1ZB/birPHxOnjQdNUeQPtgo6auVE9Ah17QLfj1hPrpQluWIFQ+7DccwqtVP4mdrs/MBCoKM28SmXcbkg8VInYmAn0PdPDiKVw789ak5olKYBHhUjOAhiutFIOf5ojzSM1SW7sJZUiTIIHDb/FvnyVnqvZgei5f5oFaF3niUU9/IRzEZ4ggNvQFgN9G/nuELyL6AFWEtqkUpOcZhPOp2T40DTwP82owVP31Lt3HzM0U0gzn33XRd9vlAbR11fUow5vqQ1zuYgSiDTuK7r2G0LaEy0CN4yxeWyZdJ9yUSg50YSMY0zlqY/Kh3BbhVXE3svO6L61c8kzmgtCthr+8gveEkRXNJW6FK2gGwXPq/j+1HxeWX/AEoPVaA1XzYRBx6BiEyhb585LDA/a58takW08iQJU12rQwAK9rLq3Q0H/rEA3f5njexZSNZG/4/pVnMdMnQntFGlGRWah75tfiOdWqGi1cYfqvfrqzDR+HyfYFEzxn3yO00BHyK4+UYVZ/PcwyzhhKrgfvyBqtWf5ZQLWYYJQ+ptLFgUKmNeSS7KDuYr2PXD6s20/L8EXtSlHJxMIEHQ3EjTQHWWYUk/oZCQO5kqmV9itAUxq5GdX+CtArHCOk7uhCsuG5CbOXWlX/nArSmHCow6MINsGc3a/zF1W+AFGmIhuHCYRFPq2XgXh9Obrol+qjx5EW0kDxtuAUayDMqWulcUM9gwx7V34fLwI4dbSRszT0VjIRrpGc4XHYibnVknVlEN7oR6qJXJb7/Df60F PQH0bPLY o0rBuuJRgTivlibV1iBtfhVpT7bHsKNJHtxwlccqKNTi7u1zA+2qFVmuRJRDs7YMc00Ynwd4WguUfMOfL79iWXniLdXhOafnYQiZdIcveZBuPaF3tqT9UZcikcjt89hTmAFOrflowvuEyOmLLpM+imaXWUUC22x08qzc5MoCW2aipx9nM8DH9v3QmMrz7nEdfb2M52WHGgJc5DvoOJqye8FEH2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 14, 2023 at 08:12:55AM +0000, David Laight wrote: > From: Andy Shevchenko > > Sent: 10 August 2023 14:14 > > On Wed, Aug 09, 2023 at 08:48:54AM +0000, David Laight wrote: ... > > > > If you split headers into so many small pieces then all > > > > source files will start with 3 screens of includes. I do not see > > > > how this helps with maintainability. > > > > > > You also slow down compilations. > > > > Ingo's patches showed the opposite. Do you have actual try and numbers? > > The compiler has to open the extra file on every compile. > If you include it from lots of different places it has to open > it for each one (to find the include guard). > Any attempted compiler optimisations have the same much the > same problem as #pragma once. > > With a long -I list even finding the file can take a while. > > Probably most obvious when using NFS mounted filesystems. > Especially the 'traditional' NFS protocol that required a > message 'round trip' for each element of the directory path. Right, as I said come up with numbers. Ingo did that, so can you. His numbers shows _increase_ of build speed. -- With Best Regards, Andy Shevchenko