From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 802C1C001E0 for ; Sat, 12 Aug 2023 03:54:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 738656B0074; Fri, 11 Aug 2023 23:54:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E7CB6B0078; Fri, 11 Aug 2023 23:54:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D81B6B007B; Fri, 11 Aug 2023 23:54:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4FECB6B0074 for ; Fri, 11 Aug 2023 23:54:05 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1A7A340334 for ; Sat, 12 Aug 2023 03:54:05 +0000 (UTC) X-FDA: 81114084450.27.5C37F21 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id C5DC9180004 for ; Sat, 12 Aug 2023 03:54:02 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vvAsJnRm; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691812443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xBw8S2t25NvV6xm2v69vkPjn0JZeQvnFHogn7wPBjNM=; b=iUh+tnpXJIbr7cAsjspVpA2yWl1+XJbbySqapdnxAZFRY35XCYOvefkAz0IHdxFXujPsVe i35R6v4mu79PljCbDCVuAGdJxiOFo0dhM8hGvkZ90VuTgl6iEeVz9yjHwjAX8nyPFHl5+K JZE77dSr7hfleg5JnbHvcIzxRP7UJl4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vvAsJnRm; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691812443; a=rsa-sha256; cv=none; b=AITFXshMLxuD/2jPsgL5cwRfo5v/iQ3kna/r2xkAlLXPea5hzubj/cW/Hm0zcXWFCTCTrG IsJaXbQsj/+ixP9aCwK+3H4z30dVzyzR9gdB++zez81e4ThmpzaWl9mjbrMQrWuhliNPbr A6TnPsGqULcG7BLAqPPXH3wug+AUXwk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xBw8S2t25NvV6xm2v69vkPjn0JZeQvnFHogn7wPBjNM=; b=vvAsJnRm8qzQFpGeY/JN59m0HK YzBWt53ndgoVYSp22PWJuxGxgo5PenUsfeGPDc9dj1060h3BxB79RlIXAwaHp5iIrDH/DZivDIC0w pOKPUB8j3Vb/KjFVv5idzckX8GNcdUIZyO6FUQs69M+aeZHTRl//jyt6U25Ehil9r4modsN0iH+SF eGSWs/3YJYmJKMl09AkjkVvwgjgQSomO3uxCPyPk+uY6m/BeysgDvi+neN5MlQYmZcIoMGFRbqQrd DAM1pmu4aENro3yi57HOiyVE36607fLKO6/i1ajGMJ7iVG0AE23i0uFkFUTRWvHthKYlre/3hY9yI VvoxQghw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qUfhK-005CME-B2; Sat, 12 Aug 2023 03:53:54 +0000 Date: Sat, 12 Aug 2023 04:53:54 +0100 From: Matthew Wilcox To: Peng Zhang Cc: linux-mm@kvack.org, akpm@linux-foundation.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com Subject: Re: [PATCH] mm/secretmem: use a folio in secretmem_fault() Message-ID: References: <20230812015835.3041694-1-zhangpeng362@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230812015835.3041694-1-zhangpeng362@huawei.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C5DC9180004 X-Stat-Signature: fp1k3kyptu65gew7mcqbswfznqqq7gbo X-Rspam-User: X-HE-Tag: 1691812442-892094 X-HE-Meta: U2FsdGVkX19I0trqdpWwPlrYQiC3bUITy8RdeGDTGvSqIvHRPfofDU4JB2OBFlqgaPBMMrz8h3LSyPoMF/scNZCYt1nUjzJmgAW8kb1ZPuUb6SesHijxkUK6a+B9ifCeVn9b85yknSNJxpdpsfPrr94z/HyJ6W2yRuAEweCQrJ6yUDP2CnaUa2FqoQs/oYE3SxIcX7ohXW3MPlYDy7L5IVgUgzX2QsKR5S7L1gpjymDLbfLtjeFN5qFnyznGidSfoy1hs8qgftyUhGtPkTC0rhCKEcv90eEr3qDGBg95rsD1tu2feZXzQCn2fuBOqf7Hz2Jffx2AC4Buh92rXRnlEuyXsjAGVlSsSorMDqtx9ACtT+IBK9Ojo5+P5WdFEbJbnglY7/u+O/QmBEg9NJDuzakk9fMN3zdzOddXv4RAxrnM8wuGkAJpsyYDcAY7xTUEYXUrrUwPjut8uDIeOYnFpaRQppOHsEDBqnKa4XuINDtVVhtx6pV/9WVxhKbV7wA2qOfWXtL2+jLL+4BQBVZn/vWSgRlRowVzuvsN09+wFtAV0DOUHZ2iPDBCeyUUkWH+9tv80WTDVk445oDL/KGYW3IEFlyplDkcJhmmtom9LmCek/ME3zClltPD0/tNDkvs7FTM3EqSqqUHZreyibXU2sMzPqbzVSf503Wa9/RGwhYWtx597Ce+f9P+Kd6/7lMxfnPbxIMtnj0AKrsMhQl/qDvbo6d+yiZNDNIT/V+gi8u38XHOgCkiKyFWpX8pGBSnFZ7QPI3IRTuY100ZddEcdP3OaWhTMeN5PIM9PDinml/PT98IwGSgtqZWtzU1WGnxImQd7jyuP0wqXwTnnOUpIS//WXTAkNpJ//khsE7fIWija3A0iVAn0u6Mpt8TlRxt9J4X6fV1Y0b+9YAv0ZnLd2tk+7M1kUNDDE0C3poWpObOSt2FRwbDNWyrio1k08ph1QPOA6jf4GrnPPOfP/h ACmbwUTP r8U9BGu/84LTp0q4XyjWXH5C9GV9iN7o2OBjpUUI2QFjF9pgWDimEscuhw+91Bkpkq465sNZaFavVwoxg20iFd2rkBVoSTeDfDyj51Lz0KM3pFyzN+lBd85HYBZcKtro9eQIcFTlZqnqqgqxpK0kq/4dxBfdYRCSHoDgrn6+y1xAx3X/gnr3KFFTs157AgSWukUu2VmiEBjU7byikQJEWuv3V6IOEWy5WR5/UB4jyp++DByaLy5K4iGBme76IrJPxIsOm0fiYvJAmsv8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 12, 2023 at 09:58:35AM +0800, Peng Zhang wrote: > From: ZhangPeng > > Saves three implicit call to compound_head(). I count four! > if (err) { > - put_page(page); > + folio_put(folio); > ret = vmf_error(err); One. > > - __SetPageUptodate(page); > - err = add_to_page_cache_lru(page, mapping, offset, gfp); > + __folio_mark_uptodate(folio); > + err = filemap_add_folio(mapping, folio, offset, gfp); Two, three. > if (unlikely(err)) { > - put_page(page); > + folio_put(folio); Four! Reviewed-by: Matthew Wilcox (Oracle)