From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 470C4C001DE for ; Fri, 11 Aug 2023 20:51:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FDBE6B007B; Fri, 11 Aug 2023 16:51:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 886016B007D; Fri, 11 Aug 2023 16:51:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7289B6B007E; Fri, 11 Aug 2023 16:51:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 653916B007B for ; Fri, 11 Aug 2023 16:51:41 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3A5AA81234 for ; Fri, 11 Aug 2023 20:51:41 +0000 (UTC) X-FDA: 81113020002.13.D8F5E8B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 1BCDA40010 for ; Fri, 11 Aug 2023 20:51:37 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ND/zo0nf"; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691787098; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T8aVoixM0xxO+gfsUyyhZDp4bChNMHCVGjLRMPROvP8=; b=QqHyBt2yqtgFux6lbKRkRXgsQahZl3CAQlcUq1lhVJ1tgMJ7yQYqMdzTFR8mif7aetljps yvj4w+DWLNK4i6AgnDw1gW3BrbZnY/VA0INKJAPDZMwKO4hgc+YCSgzHDF2NLTd6/krJyW riOpaPeyrOcNPxpo3ieypq3o8QW4PaE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ND/zo0nf"; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691787098; a=rsa-sha256; cv=none; b=SAvQpVc9zKM/487eQQNlgV0B/MeApmlRp3D8UCJEDTEESz6itlbMqFxSIb/7gLrI9S7obx sc23MfYAcpWph00YkLwcB/EeBv6IwV0ipgqp8XxkSqIIXk/QqqN9e5CdzAB9fqWPmeglBe EUmz4+apliJbLe7YLsThCUVhkjtkgMg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691787097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T8aVoixM0xxO+gfsUyyhZDp4bChNMHCVGjLRMPROvP8=; b=ND/zo0nfbyrtRPuOhDKVA89mjhP7jQ/8rPPwXm/ydLLvYZAGMrS1jlCMXrP6qVqp/yMhdc YpXEJa/3fXPMNheY6Ng7/wjbHVTjv8AH7/bHk0VZjOb9V18azI9IKNFOCPdyjhoMCfb3Hi MdUgI563ajbPd2qA89pZLO7KZULDgdI= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-VS9w6xjoMwSEPywyw-8dDw-1; Fri, 11 Aug 2023 16:51:35 -0400 X-MC-Unique: VS9w6xjoMwSEPywyw-8dDw-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-637948b24bdso6297756d6.1 for ; Fri, 11 Aug 2023 13:51:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691787095; x=1692391895; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T8aVoixM0xxO+gfsUyyhZDp4bChNMHCVGjLRMPROvP8=; b=IaYpqGXwu+qagp5Sla4n7yKwLlqhq93zowPd08GOadmgx2pj8/RgGYABn3Jw0a9rLt YLFnLPKy92NPWPG7kcjIHXuEDP/a2Q0y80sOyG13vtxAGzxH+6sncyifk0YE7oztIOB+ Zb6ozLf1eSr/VAYkEVxHDvyunRr7LShvokWi9xpC9ol/c4RQ3xYpHy5I3etUyP2VddpS y1Jdgr5iOHvsxiawG/UNODcKRz/ymAl+9tV97kpAEB9AamAC3MMKieGOFrtDZsF2OBN/ jP7xtYwGAoXY5RrjfGewKYwGQNgPCdLGA7QG4QSTm5v+q+QvYXMpimH+ZVfu3XiGIMxn VPIA== X-Gm-Message-State: AOJu0YyIusPOnmlylqwAWl0DDZ56oOJRKAxiO3JnzVIW08h40AkgQXDD +3yPh/XhGOrRghIRz4FyI/zGfyvsbV6RxCwzlzYsyjtciGp17w/+XvImKYdKbZATLFlozouI8ki tQpzyq7+UkUM= X-Received: by 2002:a05:6214:3002:b0:63f:7d29:1697 with SMTP id ke2-20020a056214300200b0063f7d291697mr3549008qvb.2.1691787094964; Fri, 11 Aug 2023 13:51:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEsPsGGsWG+AWvL3NdKiHHIMNHgjAVmUCW2ANACa31+gfznIUk9YVZFCFV5mZXxugGUYOyp/w== X-Received: by 2002:a05:6214:3002:b0:63f:7d29:1697 with SMTP id ke2-20020a056214300200b0063f7d291697mr3548975qvb.2.1691787094629; Fri, 11 Aug 2023 13:51:34 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id f8-20020a0caa88000000b00637873ff0f3sm1479316qvb.15.2023.08.11.13.51.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 13:51:32 -0700 (PDT) Date: Fri, 11 Aug 2023 16:51:30 -0400 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrew Morton , Brian Geffon , Christian Brauner , David Hildenbrand , Gaosheng Cui , Huang Ying , Hugh Dickins , James Houghton , Jiaqi Yan , Jonathan Corbet , Kefeng Wang , "Liam R. Howlett" , Miaohe Lin , Mike Kravetz , "Mike Rapoport (IBM)" , Muchun Song , Nadav Amit , Naoya Horiguchi , Ryan Roberts , Shuah Khan , Steven Barrett , Suleiman Souhlal , Suren Baghdasaryan , "T.J. Alumbaugh" , Yu Zhao , ZhangPeng , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH mm-unstable fix] mm: userfaultfd: check for start + len overflow in validate_range: fix Message-ID: References: <20230810192128.1855570-1-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: <20230810192128.1855570-1-axelrasmussen@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 1BCDA40010 X-Rspam-User: X-Stat-Signature: fasur3zm751he51zcqz1fcmy9a5tu8a3 X-Rspamd-Server: rspam01 X-HE-Tag: 1691787097-72186 X-HE-Meta: U2FsdGVkX1/uZxVkezA21xHR+ORWVxsyHexeFWq2OpY/3oCEkKN4WHNGlhVuj/qQHYwmaZIJ4wOxoGIZMsYU9ExUDyIkVGZ94gy8P3UrUUPDHqCEeRopUb+LFV9Pd1mtfGNSkWDNe+MmBT0+e3oAmOVQbxczhN9Qyypo8hmn+j6K8oR0veCaPnVGQbh260S/Il4zwfwM4gffYarLUjSxNak1ggjHUMQ1/Xy9LyBdsp0gzUB48+eYJymjoiV5HeHICgXMJBGeOlxQTg0jsn0jer3dFqNsvtusZZ/9Oz9F0sWprnyk3CSHhHPH1F9y3xF1j2yJnquIutDE66tkk9K2rThVrhNmPB2jYttr8H383P47GYVkqV84z8HHmnwWUOos4dNuuQrGUdIE9SQ/ZgyicCXNZvGsgWx+Jyqt28AUYe2fnInd2wyns876ZUJY5PfdGP1QIdf2pRk0rpt8QqVUrvmZ/uDJcBBCIBdgnV7+Q/BE0s2gX2o6TNWXY8Xs1WhFJmPTTf7fKccXnYAC/+WJt6wv5GKynd4WitFKf1qLjaaYe4rN2bbKdColjmBvHBHrZlm0LZwv1IWSamw5oKNPCsCzStaBGgeQVLTnug90iHCOS5spvFfkkVNaDA7dTQFwJsc20Wt95favU34fGg9/sf8teNFuf+qn4XKaLxkNTdCggR05FLCTGoYx9rkJ3v8Hf1ZrUSpI8PQgFUWXInyfMGBfkkwXnM5wJlh8t8o7IHFwYMXA3t/Q7QqKQAjnyfdG7murpYmRmJpPvj+uT1MTYZEJ/6fr5eNAnGBk0Nkbg4AfGUeImKf7i5YeAaU/YCbnM8E+xugPao4KkauSueF5qX5MLNseFcc5Q2Xpl4u2vRyQw2WVvSfxnLf5iAEEehp+bPbpz7rbEwiD4PTCcG5DNZeeq4e9hUC/i+TkFe1jkQEtMzRKqqWV8pPJfQ2aulEVvDpF/lvFOTfQHogttXd K6vMLYFq 72HgI7qjJvSIh6gbQPG9vZKKNPF0IqIkpJYPpq5cKFtwl0V++zf1HCNPIHoB27/ztVwln2Tg3V/rGIcfuemAK+lp/Gn/A3uK+cQsZG4pCI1JuQClLAl08bI2oKAnETPe5WeRMK7i106q25ULFm8/+SzeqNf1TAt+UOPo9Ie687d6BDNPpISIWrl1gqCzpdl98G5/loTdAcb+U445zAIzHP9X5WKMw+UQ53oSudwM6DvA1ujA6m8JW6peVHCZWJdxfw2EzM/12TbDutKMTPi9JUAT7a7hJ4Mt6RLjzwv96kmG+oPTNKur6xLcx1Hw9U9ouHhpSoKTQM3etkOjmWKTbmvF7qzN7GwCoiTdA2ecOsqfZtNb021+lkCHMIecFUmrQM4+uJ0Jye1CjOy3Q+zJKdV19IUdBBWlgGiDzTYo56ag2hb+7PQiUd5KJmBTEdwLQckkbTl2YTx5a6xMEFD9a1gom+hIw4yOrbF1fpbm/zwQC1oa0o/ObfALPoaC7T+/ZpAS2RSuIIrDYfKcANyb45Th4+WYqeSVXYUxA7xF87CJJTwu3X7ncltZ86f2ENEjoK7ekwQ+kANrsjLG/9lB/JGDXdYvkAqWCIhEcvjFWoFkPlAt1RZVkMScIzw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 10, 2023 at 12:21:28PM -0700, Axel Rasmussen wrote: > A previous fixup to this commit fixed one issue, but introduced another: > we're now overly strict when validating the src address for UFFDIO_COPY. > > Most of the validation in validate_range is useful to apply to src as > well as dst, but page alignment is only a requirement for dst, not src. > So, split the function up so src can use an "unaligned" variant, while > still allowing us to share the majority of the code between the > different cases. > > Reported-by: Ryan Roberts > Closes: https://lore.kernel.org/linux-mm/8fbb5965-28f7-4e9a-ac04-1406ed8fc2d4@arm.com/T/#t > Signed-off-by: Axel Rasmussen Acked-by: Peter Xu -- Peter Xu