From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63845C001DE for ; Fri, 11 Aug 2023 16:36:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 021766B0074; Fri, 11 Aug 2023 12:36:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EECE36B007B; Fri, 11 Aug 2023 12:36:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8DF26B007D; Fri, 11 Aug 2023 12:36:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C66F16B0074 for ; Fri, 11 Aug 2023 12:36:15 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8DC76A088F for ; Fri, 11 Aug 2023 16:36:15 +0000 (UTC) X-FDA: 81112376310.15.F809E57 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id D0A3B1C0023 for ; Fri, 11 Aug 2023 16:36:13 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691771773; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ry//bg6gDu/5gIyJEyt7/XbSvZMnX5826x2xmdE8Jp8=; b=pZ8DGkqM1a2NzKfsMfmwiStExAyJlrEHHYyYOmXc9T+IlOTI2kH0C0ooTFitNA/jMNBbMH /wYaj0uuo0bIQDHnXmAeddDnYdNqxaopR9MQxwqXXjV0eO1szg6jL0CDQ9cN+53EjbI742 Fkn0we/pwL16S9Mn61JAx7+8iokiS7U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691771773; a=rsa-sha256; cv=none; b=IVWSUS8qNJMIRIsjMjyixFIkbHyQzI3DPvHwwmmahYgO5ZabmEsqg4PZF+pNbwpaMS9XDr jhunw2UCPzSuBL+WddOQpVMje0exTCHEKWDXbcSL1l3QNFsC7jTJogqQnib0nMzydfJCdR kaL47cRynpmKeHQ0OmUm1sbcrnm0B5Y= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CA45C65728; Fri, 11 Aug 2023 16:36:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80FC3C433C8; Fri, 11 Aug 2023 16:36:07 +0000 (UTC) Date: Fri, 11 Aug 2023 17:36:05 +0100 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Kees Cook , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v4 07/36] arm64/gcs: Provide copy_to_user_gcs() Message-ID: References: <20230807-arm64-gcs-v4-0-68cfa37f9069@kernel.org> <20230807-arm64-gcs-v4-7-68cfa37f9069@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230807-arm64-gcs-v4-7-68cfa37f9069@kernel.org> X-Stat-Signature: ze3mzo8we8fbzisr813jp8tcoeorq74w X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D0A3B1C0023 X-Rspam-User: X-HE-Tag: 1691771773-554622 X-HE-Meta: U2FsdGVkX1+KI0No3XgN1TYZDcyNb+reeKsmb3hoogoCtYb2L3nxxJ7+RPSsZEv6BanUvdmP1195XCkFR/5evskFosfK+z5bp37CJQjJCUlxFbPQyNVqFb1aGi5fRDlNHDMfGQ36HBFZbctc94fdCLjEaCK0wp3OB3oe7bkKSoK6Hq0NjA4hcPAKhYCuiqHMhEapOeJ0WqmIQ8smfX0DdiocVxM5YYQRyBBKDjC2R4k9DzbQW+FgXT9wPyXfC63++q6TQyGFQ4rARWHLKsfowJ2WtJnwa36KWnumj4TLE2RKY4RQrgzjnnhunuDpGBpeOFvnTg1dtRJTrocTrbzzaAiuLANvf9zr42cAaxU4sp1g55OHSQFSGJUn9pHtYu8IeYRKFBlcf+o9ljIvZQ7i88WytZ23LL3cKeZfhwf4mFUuufyy3sdMLpa96wh2sLLSstTk6dzs8mGNOe/6sJkXo+w8/x3/lpDGxZBvBGrEY2YU4EqZWaOkWA7cQRIIXRfHMWh0Tg5pnSgJ9P3p95zvcrLWEGszrlKckCkGDx33oKYOf834+eLI/c+IW3mf1A/w4xBu/2UUCC4D81fOiJFI+ATBNZ6Lbu5zy47Df5iCKjoxH7uFRvyVeV8DdahVnhAI6wtEcP9Tr6UG9IQ5RGoc5raa7/FYwYtZBUI11rrdFpr50FwIk4abrkWhyS1dDLHIZ4T5lY460oHQfcWwIiG/JNAScnIJcW7cZVNbN8sFBf4vXUe55FCWHh75Yc9jdwCgCPCVxlqpDLriFLpDZ0yZCwi5tAs3F8diJ2gY2fhBSFmSxpt7ZkKS9tMUn530FHB1iRDnbY6/J60Qum4y0XrpaYJx772zT4o2XiYxQRWZ3aml/Qm5gFRQMPf9194Mw4JNh5pESLnyT9Vane+mG4hQevjq6VC5jWLhniA9OMO0ruoIz3jRNHe42by5uNIo3hM2/IvJCve7omcmMRHXT7E tmAD54EC 598MPybP3CQAAuS6oz72ZgcW073KfiWwxbGjWuJoFMadRMSyeNpWcROzMkH7sw+60qAxMs6vdoUhYax/KRiLPF2wtUS98iUM+I6fs26Db9uWIGhyTXE3Rm/RYoDMmYp55qYkpmIEHD+nB2MyarUMiVF8/UCnb8b4ElOugNXV4CkU+Owa7CX2lkdKzqPTaNI4KcTsAZqmYoxCIhjeplRc+MmxQpR2TU4b0kXovld4qnS/Yl7SYUfQrwMNmSoEVRkSIGN1knPc++WxQ4lR73tgA+uvpq9paIi2k7PERFRaOrVGwhkHTkwdFtF43wfiYk1fqNTQcfJFRJgubdaRjB/hIGrNbehxvPDENqE6WLXf+zRpWedBSDApEdEspXz68scl60H6IY0SYswe/boavnVajAnVglvZBPfPrH7oNdl+lD0qSFmQOBZ+8AZwR5u0XmUlnj+ttvaYEGfAyU7paUb67BPvoGdE3UL9VzBFl/YYcCH6o2jks/KQtLKq1ozF5Ddad2e5iMlJpv5qBPdDkLOtgrCViMO5mwfyz9EXNS7DAj1Bkc4MqQvRa7nxIHQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 07, 2023 at 11:00:12PM +0100, Mark Brown wrote: > +static inline int copy_to_user_gcs(unsigned long __user *addr, > + unsigned long *val, > + int count) > +{ > + int ret = -EFAULT; > + int i; > + > + if (access_ok((char __user *)addr, count * sizeof(u64))) { > + uaccess_ttbr0_enable(); > + for (i = 0; i < count; i++) { > + ret = gcssttr(addr++, *val++); > + if (ret != 0) > + break; > + } > + uaccess_ttbr0_disable(); > + } > + > + return ret; > +} I think it makes more sense to have a put_user_gcs() of a single element. I've only seen it used with 2 elements in the signal code but we could as well do two put_user_gcs() calls (as we do for other stuff that we push to the signal frame). -- Catalin